)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"6db240afebc0b81b444b0df0103d97d161b4e51a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"We decided we don\u0027t like this syntax, so I figured I\u0027d clean up this"},{"line_number":10,"context_line":"file while I was playing with it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Encountered blueprint per-to-cbr in a book store."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I861b9bfcb98782a2f0b46ac5bff09664a13d339c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAOn%2F%2FrVM%3D","line":12,"updated":"2013-04-29 15:01:23.000000000","message":"What does this mean? :)","commit_id":"671174d0f04b1e714ed677b7abae4ba0c82fd053"}],"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"a5cf9ccf27704fdb674eee462a2fb93c33320005","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            return  # no previously attempted hosts, skip"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        last_host, last_node \u003d hosts[-1]"},{"line_number":244,"context_line":"        LOG.error(_(\u0027Error from last host: %(last_host)s (node %(last_node)s):\u0027"},{"line_number":245,"context_line":"                    \u0027 %(exc)s\u0027),"},{"line_number":246,"context_line":"                  {\u0027last_host\u0027: last_host,"},{"line_number":247,"context_line":"                   \u0027last_node\u0027: last_node,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FrVY%3D","line":244,"updated":"2013-04-29 15:00:35.000000000","message":"So, this is a 6 line log statement now.  Just curious, but is there a good reason not to compress this a bit onto fewer lines?\n\nThe thing I liked about locals() was how succinct it was.  I realize there is a general consensus around going explicit, though.","commit_id":"671174d0f04b1e714ed677b7abae4ba0c82fd053"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"e9799eedc8d8dd932c4ecc91be8d1e0d694290a4","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            return  # no previously attempted hosts, skip"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        last_host, last_node \u003d hosts[-1]"},{"line_number":244,"context_line":"        LOG.error(_(\u0027Error from last host: %(last_host)s (node %(last_node)s):\u0027"},{"line_number":245,"context_line":"                    \u0027 %(exc)s\u0027),"},{"line_number":246,"context_line":"                  {\u0027last_host\u0027: last_host,"},{"line_number":247,"context_line":"                   \u0027last_node\u0027: last_node,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FqfQ%3D","line":244,"in_reply_to":"AAAAOn%2F%2Fqvo%3D","updated":"2013-04-29 23:21:46.000000000","message":"Makes little difference to me.  Either way you\u0027ve got a 5-6 line blob to read in the middle of browsing through the code. :)\n\nI won\u0027t -1 it over something so trivial, though.  I was just curious what others thought.","commit_id":"671174d0f04b1e714ed677b7abae4ba0c82fd053"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"9b6002ca36cef5734c84655f74e7cc8f8053242e","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            return  # no previously attempted hosts, skip"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"        last_host, last_node \u003d hosts[-1]"},{"line_number":244,"context_line":"        LOG.error(_(\u0027Error from last host: %(last_host)s (node %(last_node)s):\u0027"},{"line_number":245,"context_line":"                    \u0027 %(exc)s\u0027),"},{"line_number":246,"context_line":"                  {\u0027last_host\u0027: last_host,"},{"line_number":247,"context_line":"                   \u0027last_node\u0027: last_node,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fqvo%3D","line":244,"in_reply_to":"AAAAOn%2F%2FrVY%3D","updated":"2013-04-29 21:04:27.000000000","message":"How would you feel about creating the dictionary separately from the LOG.error(), i.e.:\n\n    values \u003d {\u0027last_host\u0027: last_host,\n              \u0027last_node\u0027: last_node,\n              \u0027exc\u0027: exc}\n    LOG.error(…,\n              values, instance_uuid\u003dinstance_uuid)","commit_id":"671174d0f04b1e714ed677b7abae4ba0c82fd053"}]}