)]}'
{"nova/tests/unit/api/openstack/compute/test_api.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"208fc0a5a1d1a79088c4249872dfd5656492b965","unresolved":false,"context_lines":[{"line_number":177,"context_line":"class APITestV21(APITest):"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @property"},{"line_number":180,"context_line":"    def wsgi_app(self):"},{"line_number":181,"context_line":"        return fakes.wsgi_app_v21(init_only\u003d(\u0027versions\u0027,))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    # TODO(alex_xu): Get rid of the case translate NovaException to"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_2f505c0a","line":180,"updated":"2016-02-08 16:46:06.000000000","message":"Why not mock out \u0027load_extension\u0027 here?  What\u0027s the deciding factor on whether or not it can be mocked out?","commit_id":"9fbe683bf712fb374d7af25397a61b65a653c147"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"5ddd03d366f25f9a2b6419fc8e02521c3db09661","unresolved":false,"context_lines":[{"line_number":177,"context_line":"class APITestV21(APITest):"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @property"},{"line_number":180,"context_line":"    def wsgi_app(self):"},{"line_number":181,"context_line":"        return fakes.wsgi_app_v21(init_only\u003d(\u0027versions\u0027,))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    # TODO(alex_xu): Get rid of the case translate NovaException to"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_a911a353","line":180,"in_reply_to":"5a5ae5dd_2f505c0a","updated":"2016-02-08 19:03:04.000000000","message":"That mock only makes sense in the legacy test code path (wsgi_app_v21 vs wsgi_app).\n\nThe bigger optimization in this file was basically: \"stop doing that expensive thing, period\". That is, moving the fake WGSI app creating out of setUp reduced the number of fakes created from 36 to 6.\n\nThe mock was more beneficial when 36 fakes were being created, but it still helps reduce the runtime to under a second.","commit_id":"9fbe683bf712fb374d7af25397a61b65a653c147"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"1f04f5c39040089dfd80e9a997589c1df574ece8","unresolved":false,"context_lines":[{"line_number":177,"context_line":"class APITestV21(APITest):"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @property"},{"line_number":180,"context_line":"    def wsgi_app(self):"},{"line_number":181,"context_line":"        return fakes.wsgi_app_v21(init_only\u003d(\u0027versions\u0027,))"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    # TODO(alex_xu): Get rid of the case translate NovaException to"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_cdb501d1","line":180,"in_reply_to":"5a5ae5dd_a911a353","updated":"2016-02-09 18:18:07.000000000","message":"Thanks for the explanation. My eyes had glazed over the fact that the wsgi_app_v21 here is different than wsgi_app above which led to my confusion.","commit_id":"9fbe683bf712fb374d7af25397a61b65a653c147"}]}