)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"db8b348065d8815bdc29377a86850aee2712c19d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the number of fakes created (see ncalls)."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch also fixes a couple one item tuples that weren\u0027t actually"},{"line_number":14,"context_line":"tuples because they were missing the comma."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"$ tox -e py27 nova.tests.unit.api.openstack.compute.test_flavor"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a5ae5dd_34944b41","line":14,"updated":"2016-02-08 10:22:34.000000000","message":"I would rather that was a separate change, but OK.","commit_id":"9e29ba9afc47cc09538f76bca01ac245bd4913bb"}],"nova/tests/unit/api/openstack/compute/test_flavor_disabled.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"6bd2d6f000ec6c69fca0017405ab85e550ef48a8","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def _make_request(self, url):"},{"line_number":77,"context_line":"        req \u003d webob.Request.blank(url)"},{"line_number":78,"context_line":"        req.headers[\u0027Accept\u0027] \u003d self.content_type"},{"line_number":79,"context_line":"        res \u003d req.get_response(fakes.wsgi_app_v21(init_only\u003d(\u0027flavors\u0027,)))"},{"line_number":80,"context_line":"        return res"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _get_flavor(self, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_95598790","line":79,"range":{"start_line":79,"start_character":60,"end_line":79,"end_character":72},"updated":"2016-02-08 03:14:51.000000000","message":"Can we put some NOTE for explaining why we need to put this \",\" ?\n\nI guess the other people will misunderstand we need to remove this \",\" in the future unless we put the NOTE.","commit_id":"9e29ba9afc47cc09538f76bca01ac245bd4913bb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ebda55f85d6a0e078fb8e5e9becae59c3872610c","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def _make_request(self, url):"},{"line_number":77,"context_line":"        req \u003d webob.Request.blank(url)"},{"line_number":78,"context_line":"        req.headers[\u0027Accept\u0027] \u003d self.content_type"},{"line_number":79,"context_line":"        res \u003d req.get_response(fakes.wsgi_app_v21(init_only\u003d(\u0027flavors\u0027,)))"},{"line_number":80,"context_line":"        return res"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _get_flavor(self, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_3f8509ce","line":79,"range":{"start_line":79,"start_character":60,"end_line":79,"end_character":72},"in_reply_to":"5a5ae5dd_50179d47","updated":"2016-02-08 08:48:09.000000000","message":"OK, maybe we can avoid such situation.\nI was a little worried because I faced tuple values on unit tests as bugs and needed to fix them.","commit_id":"9e29ba9afc47cc09538f76bca01ac245bd4913bb"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"a4804412908d942cdc614d6dd0612783d4c7d9bb","unresolved":false,"context_lines":[{"line_number":76,"context_line":"    def _make_request(self, url):"},{"line_number":77,"context_line":"        req \u003d webob.Request.blank(url)"},{"line_number":78,"context_line":"        req.headers[\u0027Accept\u0027] \u003d self.content_type"},{"line_number":79,"context_line":"        res \u003d req.get_response(fakes.wsgi_app_v21(init_only\u003d(\u0027flavors\u0027,)))"},{"line_number":80,"context_line":"        return res"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def _get_flavor(self, body):"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_50179d47","line":79,"range":{"start_line":79,"start_character":60,"end_line":79,"end_character":72},"in_reply_to":"5a5ae5dd_95598790","updated":"2016-02-08 03:28:44.000000000","message":"I don\u0027t think we should comment this since it\u0027s just how python tuples work and isn\u0027t unique to this code in particular. \n\n    \u003e\u003e\u003e type((1))\n    \u003ctype \u0027int\u0027\u003e\n\n    \u003e\u003e\u003e type((1,))\n    \u003ctype \u0027tuple\u0027\u003e\n\nI would have probably used a list (rather than a tuple) if I were writing this from scratch, but I grepped while working on this patch and every other caller is using a tuple.\n\nGrep also showed that there are a bunch of one item tuples being passed in as init_only that didn\u0027t make this mistake.\n\nBut yes, it is a strange corner of Python ;)","commit_id":"9e29ba9afc47cc09538f76bca01ac245bd4913bb"}]}
