)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4dcd800356ca562ecf5f265b4a9136ed548378aa","unresolved":false,"context_lines":[{"line_number":266,"context_line":"CONF.register_opts(instance_cleaning_opts)"},{"line_number":267,"context_line":"CONF.import_opt(\u0027console_topic\u0027, \u0027nova.console.rpcapi\u0027)"},{"line_number":268,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":269,"context_line":"CONF.import_opt(\u0027enabled\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":270,"context_line":"CONF.import_opt(\u0027enabled\u0027, \u0027nova.spice\u0027, group\u003d\u0027spice\u0027)"},{"line_number":271,"context_line":"CONF.import_opt(\u0027enable\u0027, \u0027nova.cells.opts\u0027, group\u003d\u0027cells\u0027)"},{"line_number":272,"context_line":"CONF.import_opt(\u0027image_cache_manager_interval\u0027, \u0027nova.virt.imagecache\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_4b55761b","line":269,"updated":"2016-02-09 20:06:44.000000000","message":"You don\u0027t need to import opts once they move to nova.conf, so you can delete this line.","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3f3cefc30f06fb1f01b3428fc3d9a0e44df8ddff","unresolved":false,"context_lines":[{"line_number":266,"context_line":"CONF.register_opts(instance_cleaning_opts)"},{"line_number":267,"context_line":"CONF.import_opt(\u0027console_topic\u0027, \u0027nova.console.rpcapi\u0027)"},{"line_number":268,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":269,"context_line":"CONF.import_opt(\u0027enabled\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":270,"context_line":"CONF.import_opt(\u0027enabled\u0027, \u0027nova.spice\u0027, group\u003d\u0027spice\u0027)"},{"line_number":271,"context_line":"CONF.import_opt(\u0027enable\u0027, \u0027nova.cells.opts\u0027, group\u003d\u0027cells\u0027)"},{"line_number":272,"context_line":"CONF.import_opt(\u0027image_cache_manager_interval\u0027, \u0027nova.virt.imagecache\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_e45d6fed","line":269,"in_reply_to":"3a57f1b5_4b55761b","updated":"2016-02-09 22:08:21.000000000","message":"Done","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4dcd800356ca562ecf5f265b4a9136ed548378aa","unresolved":false,"context_lines":[{"line_number":310,"context_line":"               \u0027kernel (usually 1-99)\u0027)"},{"line_number":311,"context_line":"    ]"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"CONF \u003d cfg.CONF"},{"line_number":314,"context_line":"CONF.register_opts(libvirt_opts, \u0027libvirt\u0027)"},{"line_number":315,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":316,"context_line":"CONF.import_opt(\u0027my_ip\u0027, \u0027nova.netconf\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_8b092e34","line":313,"updated":"2016-02-09 20:06:44.000000000","message":"This needs to change to nova.conf.CONF, with an \u0027import nova.conf\u0027 added to the imports.","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3f3cefc30f06fb1f01b3428fc3d9a0e44df8ddff","unresolved":false,"context_lines":[{"line_number":310,"context_line":"               \u0027kernel (usually 1-99)\u0027)"},{"line_number":311,"context_line":"    ]"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"CONF \u003d cfg.CONF"},{"line_number":314,"context_line":"CONF.register_opts(libvirt_opts, \u0027libvirt\u0027)"},{"line_number":315,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":316,"context_line":"CONF.import_opt(\u0027my_ip\u0027, \u0027nova.netconf\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_04652b44","line":313,"in_reply_to":"3a57f1b5_8b092e34","updated":"2016-02-09 22:08:21.000000000","message":"Done","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4dcd800356ca562ecf5f265b4a9136ed548378aa","unresolved":false,"context_lines":[{"line_number":322,"context_line":"CONF.import_opt(\u0027key_size\u0027, \u0027nova.compute.api\u0027,"},{"line_number":323,"context_line":"                group\u003d\u0027ephemeral_storage_encryption\u0027)"},{"line_number":324,"context_line":"CONF.import_opt(\u0027live_migration_retry_count\u0027, \u0027nova.compute.manager\u0027)"},{"line_number":325,"context_line":"CONF.import_opt(\u0027vncserver_proxyclient_address\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":326,"context_line":"CONF.import_opt(\u0027server_proxyclient_address\u0027, \u0027nova.spice\u0027, group\u003d\u0027spice\u0027)"},{"line_number":327,"context_line":"CONF.import_opt(\u0027vcpu_pin_set\u0027, \u0027nova.conf.virt\u0027)"},{"line_number":328,"context_line":"CONF.import_opt(\u0027vif_plugging_is_fatal\u0027, \u0027nova.virt.driver\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_ab3aeae5","line":325,"updated":"2016-02-09 20:06:44.000000000","message":"Also not needed.","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3f3cefc30f06fb1f01b3428fc3d9a0e44df8ddff","unresolved":false,"context_lines":[{"line_number":322,"context_line":"CONF.import_opt(\u0027key_size\u0027, \u0027nova.compute.api\u0027,"},{"line_number":323,"context_line":"                group\u003d\u0027ephemeral_storage_encryption\u0027)"},{"line_number":324,"context_line":"CONF.import_opt(\u0027live_migration_retry_count\u0027, \u0027nova.compute.manager\u0027)"},{"line_number":325,"context_line":"CONF.import_opt(\u0027vncserver_proxyclient_address\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":326,"context_line":"CONF.import_opt(\u0027server_proxyclient_address\u0027, \u0027nova.spice\u0027, group\u003d\u0027spice\u0027)"},{"line_number":327,"context_line":"CONF.import_opt(\u0027vcpu_pin_set\u0027, \u0027nova.conf.virt\u0027)"},{"line_number":328,"context_line":"CONF.import_opt(\u0027vif_plugging_is_fatal\u0027, \u0027nova.virt.driver\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_e4b9efed","line":325,"in_reply_to":"3a57f1b5_ab3aeae5","updated":"2016-02-09 22:08:21.000000000","message":"Done","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b5eb98abe3bc647a5655aa1fcd33b0a3759807dc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"from nova.compute import task_states"},{"line_number":67,"context_line":"from nova.compute import utils as compute_utils"},{"line_number":68,"context_line":"from nova.compute import vm_mode"},{"line_number":69,"context_line":"from nova import conf as n_conf"},{"line_number":70,"context_line":"from nova.console import serial as serial_console"},{"line_number":71,"context_line":"from nova.console import type as ctype"},{"line_number":72,"context_line":"from nova import context as nova_context"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_1a04a213","line":69,"updated":"2016-02-09 21:39:22.000000000","message":"Not a big deal, but if you respin, the standard we have more or less settled on is to have `import nova.conf` here, and `CONF \u003d nova.conf.CONF` below.","commit_id":"d43920d4ed09a728df3abd157004a79a5c97c215"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"1378122eefccca030c93b9ffbf293bf86da7fdd9","unresolved":false,"context_lines":[{"line_number":66,"context_line":"from nova.compute import task_states"},{"line_number":67,"context_line":"from nova.compute import utils as compute_utils"},{"line_number":68,"context_line":"from nova.compute import vm_mode"},{"line_number":69,"context_line":"from nova import conf as n_conf"},{"line_number":70,"context_line":"from nova.console import serial as serial_console"},{"line_number":71,"context_line":"from nova.console import type as ctype"},{"line_number":72,"context_line":"from nova import context as nova_context"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a57f1b5_0f5f51e6","line":69,"in_reply_to":"3a57f1b5_1a04a213","updated":"2016-02-10 17:54:31.000000000","message":"OK.  I hadn\u0027t done that initially to keep consistency with the other imports being all \u0027from\u0027 based.\n\nWill update since I need a rebase anyway.\n\nThx!","commit_id":"d43920d4ed09a728df3abd157004a79a5c97c215"}],"nova/virt/vmwareapi/vmops.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4dcd800356ca562ecf5f265b4a9136ed548378aa","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027system.\u0027),"},{"line_number":72,"context_line":"    ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"CONF \u003d cfg.CONF"},{"line_number":75,"context_line":"CONF.register_opts(vmops_opts, \u0027vmware\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"CONF.import_opt(\u0027image_cache_subdirectory_name\u0027, \u0027nova.virt.imagecache\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_ce0df438","line":74,"updated":"2016-02-09 20:06:44.000000000","message":"Should be changed to CONF \u003d nova.conf.CONF","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3f3cefc30f06fb1f01b3428fc3d9a0e44df8ddff","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    \u0027system.\u0027),"},{"line_number":72,"context_line":"    ]"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"CONF \u003d cfg.CONF"},{"line_number":75,"context_line":"CONF.register_opts(vmops_opts, \u0027vmware\u0027)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"CONF.import_opt(\u0027image_cache_subdirectory_name\u0027, \u0027nova.virt.imagecache\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_84c7db44","line":74,"in_reply_to":"3a57f1b5_ce0df438","updated":"2016-02-09 22:08:21.000000000","message":"Done","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4dcd800356ca562ecf5f265b4a9136ed548378aa","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"CONF.import_opt(\u0027image_cache_subdirectory_name\u0027, \u0027nova.virt.imagecache\u0027)"},{"line_number":78,"context_line":"CONF.import_opt(\u0027remove_unused_base_images\u0027, \u0027nova.virt.imagecache\u0027)"},{"line_number":79,"context_line":"CONF.import_opt(\u0027enabled\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":80,"context_line":"CONF.import_opt(\u0027my_ip\u0027, \u0027nova.netconf\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_4b2c96ab","line":79,"updated":"2016-02-09 20:06:44.000000000","message":"Also not needed.","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3f3cefc30f06fb1f01b3428fc3d9a0e44df8ddff","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"CONF.import_opt(\u0027image_cache_subdirectory_name\u0027, \u0027nova.virt.imagecache\u0027)"},{"line_number":78,"context_line":"CONF.import_opt(\u0027remove_unused_base_images\u0027, \u0027nova.virt.imagecache\u0027)"},{"line_number":79,"context_line":"CONF.import_opt(\u0027enabled\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":80,"context_line":"CONF.import_opt(\u0027my_ip\u0027, \u0027nova.netconf\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_c4b4f3d2","line":79,"in_reply_to":"3a57f1b5_4b2c96ab","updated":"2016-02-09 22:08:21.000000000","message":"Done","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"}],"nova/virt/xenapi/vmops.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4dcd800356ca562ecf5f265b4a9136ed548378aa","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               help\u003d\u0027Dom0 plugin driver used to handle image uploads.\u0027),"},{"line_number":75,"context_line":"    ]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"CONF \u003d cfg.CONF"},{"line_number":78,"context_line":"CONF.register_opts(xenapi_vmops_opts, \u0027xenserver\u0027)"},{"line_number":79,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":80,"context_line":"CONF.import_opt(\u0027vncserver_proxyclient_address\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_8e37fce2","line":77,"updated":"2016-02-09 20:06:44.000000000","message":"Also change to nova.conf.CONF","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3f3cefc30f06fb1f01b3428fc3d9a0e44df8ddff","unresolved":false,"context_lines":[{"line_number":74,"context_line":"               help\u003d\u0027Dom0 plugin driver used to handle image uploads.\u0027),"},{"line_number":75,"context_line":"    ]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"CONF \u003d cfg.CONF"},{"line_number":78,"context_line":"CONF.register_opts(xenapi_vmops_opts, \u0027xenserver\u0027)"},{"line_number":79,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":80,"context_line":"CONF.import_opt(\u0027vncserver_proxyclient_address\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_44d8031e","line":77,"in_reply_to":"3a57f1b5_8e37fce2","updated":"2016-02-09 22:08:21.000000000","message":"Done","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"4dcd800356ca562ecf5f265b4a9136ed548378aa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"CONF \u003d cfg.CONF"},{"line_number":78,"context_line":"CONF.register_opts(xenapi_vmops_opts, \u0027xenserver\u0027)"},{"line_number":79,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":80,"context_line":"CONF.import_opt(\u0027vncserver_proxyclient_address\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"DEFAULT_FIREWALL_DRIVER \u003d \"%s.%s\" % ("},{"line_number":83,"context_line":"    firewall.__name__,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_4e3104ec","line":80,"updated":"2016-02-09 20:06:44.000000000","message":"Also not needed.","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"},{"author":{"_account_id":8190,"name":"Drew Thorstensen (thorst)","email":"thorst@us.ibm.com","username":"thorst"},"change_message_id":"3f3cefc30f06fb1f01b3428fc3d9a0e44df8ddff","unresolved":false,"context_lines":[{"line_number":77,"context_line":"CONF \u003d cfg.CONF"},{"line_number":78,"context_line":"CONF.register_opts(xenapi_vmops_opts, \u0027xenserver\u0027)"},{"line_number":79,"context_line":"CONF.import_opt(\u0027host\u0027, \u0027nova.netconf\u0027)"},{"line_number":80,"context_line":"CONF.import_opt(\u0027vncserver_proxyclient_address\u0027, \u0027nova.conf.vnc\u0027, group\u003d\u0027vnc\u0027)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"DEFAULT_FIREWALL_DRIVER \u003d \"%s.%s\" % ("},{"line_number":83,"context_line":"    firewall.__name__,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a57f1b5_e4032f75","line":80,"in_reply_to":"3a57f1b5_4e3104ec","updated":"2016-02-09 22:08:21.000000000","message":"Done","commit_id":"dfc6429d9c05b399224facb67ff7720c3c234893"}]}