)]}'
{"nova/objects/compute_node.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"96497613b7e909d1f9ba44c7dd27035f35bbf409","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                    if value \u003d\u003d 0.0 and key \u003d\u003d \u0027ram_allocation_ratio\u0027:"},{"line_number":194,"context_line":"                        # It\u0027s not specified either on the controller"},{"line_number":195,"context_line":"                        value \u003d 1.5"},{"line_number":196,"context_line":"                    if value \u003d\u003d 0.0 and key \u003d\u003d \u0027disk_allocation_ratio\u0027:"},{"line_number":197,"context_line":"                        # It\u0027s not specified either on the controller"},{"line_number":198,"context_line":"                        value \u003d 1.0"},{"line_number":199,"context_line":"            compute[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_66087a29","line":196,"updated":"2016-02-09 16:58:25.000000000","message":"your default in the previous patch is not correct for this to work.","commit_id":"d36714668ea52c07ff4e39860c5b594e453dbfd8"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"6692dbf60e82eddaacee421ed1dc5a728851e099","unresolved":false,"context_lines":[{"line_number":193,"context_line":"                    if value \u003d\u003d 0.0 and key \u003d\u003d \u0027ram_allocation_ratio\u0027:"},{"line_number":194,"context_line":"                        # It\u0027s not specified either on the controller"},{"line_number":195,"context_line":"                        value \u003d 1.5"},{"line_number":196,"context_line":"                    if value \u003d\u003d 0.0 and key \u003d\u003d \u0027disk_allocation_ratio\u0027:"},{"line_number":197,"context_line":"                        # It\u0027s not specified either on the controller"},{"line_number":198,"context_line":"                        value \u003d 1.0"},{"line_number":199,"context_line":"            compute[key] \u003d value"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a5ae5dd_86e1f600","line":196,"in_reply_to":"5a5ae5dd_66087a29","updated":"2016-02-09 17:03:29.000000000","message":"so actually, its probably better to change the config default to 0.0 in this patch:\nhttps://review.openstack.org/#/c/245619/3/nova/compute/resource_tracker.py","commit_id":"d36714668ea52c07ff4e39860c5b594e453dbfd8"}],"nova/tests/unit/objects/test_compute_node.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"174e6488c84dd9263f532084b6d59112cea58c88","unresolved":false,"context_lines":[{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def test_compat_disk_allocation_ratio(self):"},{"line_number":461,"context_line":"        compute \u003d compute_node.ComputeNode()"},{"line_number":462,"context_line":"        primitive \u003d compute.obj_to_primitive(target_version\u003d\u00271.14\u0027)"},{"line_number":463,"context_line":"        self.assertNotIn(\u0027disk_allocation_ratio\u0027, primitive)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    def test_compat_allocation_ratios_old_compute(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"dae33548_edc0cc7e","line":462,"range":{"start_line":462,"start_character":45,"end_line":462,"end_character":66},"updated":"2016-02-16 17:50:29.000000000","message":"meh I forgot to modify that when rebasing... :-(","commit_id":"bf368e8764d50fb6215febda8a4197787b196ddc"}]}