)]}'
{"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2bad4e909383dbd3912802be1cb258362df7d02b","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"    @contextlib.contextmanager"},{"line_number":1250,"context_line":"    def import_file(self, context, format, size\u003dNone):"},{"line_number":1251,"context_line":"        if format not in (imgmodel.FORMAT_RAW, \u0027ploop\u0027):"},{"line_number":1252,"context_line":"            raise NotImplementedError(\u0027Ploop can only import raw and ploop\u0027)"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"        with self.lock():"},{"line_number":1255,"context_line":"            remove_func \u003d functools.partial(fileutils.delete_if_exists,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_2e169255","line":1252,"updated":"2016-02-11 16:28:20.000000000","message":"missing translation","commit_id":"a04e42d027ef81f9332c069903614bf1490cab64"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"ab938ed3ffefb146c385d0edb28abdda41e7bc9c","unresolved":false,"context_lines":[{"line_number":1249,"context_line":"    @contextlib.contextmanager"},{"line_number":1250,"context_line":"    def import_file(self, context, format, size\u003dNone):"},{"line_number":1251,"context_line":"        if format not in (imgmodel.FORMAT_RAW, \u0027ploop\u0027):"},{"line_number":1252,"context_line":"            raise NotImplementedError(\u0027Ploop can only import raw and ploop\u0027)"},{"line_number":1253,"context_line":""},{"line_number":1254,"context_line":"        with self.lock():"},{"line_number":1255,"context_line":"            remove_func \u003d functools.partial(fileutils.delete_if_exists,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a57f1b5_572d9efc","line":1252,"in_reply_to":"3a57f1b5_2e169255","updated":"2016-02-11 16:51:02.000000000","message":"I wouldn\u0027t trouble the translators with this one: it\u0027s a programming error. That\u0027s why I decided to raise NotImplementedError instead of a NovaException.","commit_id":"a04e42d027ef81f9332c069903614bf1490cab64"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"9d663f1be613ccf886afebaddaf657d85a6105e4","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"    @contextlib.contextmanager"},{"line_number":1254,"context_line":"    def import_file(self, context, format, size\u003dNone):"},{"line_number":1255,"context_line":"        if format not in (imgmodel.FORMAT_RAW, \u0027ploop\u0027):"},{"line_number":1256,"context_line":"            raise NotImplementedError(\u0027Ploop can only import raw and ploop\u0027)"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        with self.lock():"},{"line_number":1259,"context_line":"            remove_func \u003d functools.partial(fileutils.delete_if_exists,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_29ef6a88","line":1256,"updated":"2016-02-21 13:17:11.000000000","message":"please see comments about translations ...","commit_id":"cf85f8fd49d425f6ca301d763c47bd850dc5de59"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"5d55f89d910ec6cc8c2eaa50e64e9ce372033da2","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"    @contextlib.contextmanager"},{"line_number":1254,"context_line":"    def import_file(self, context, format, size\u003dNone):"},{"line_number":1255,"context_line":"        if format not in (imgmodel.FORMAT_RAW, \u0027ploop\u0027):"},{"line_number":1256,"context_line":"            raise NotImplementedError(\u0027Ploop can only import raw and ploop\u0027)"},{"line_number":1257,"context_line":""},{"line_number":1258,"context_line":"        with self.lock():"},{"line_number":1259,"context_line":"            remove_func \u003d functools.partial(fileutils.delete_if_exists,"}],"source_content_type":"text/x-python","patch_set":6,"id":"bae84128_13b56ced","line":1256,"in_reply_to":"bae84128_29ef6a88","updated":"2016-02-21 19:42:47.000000000","message":"Please see previous response. Programming errors like this should not be translated. Note that I intentionally did not use NovaException.","commit_id":"cf85f8fd49d425f6ca301d763c47bd850dc5de59"},{"author":{"_account_id":20223,"name":"zhaolihui","email":"zhaolh@awcloud.com","username":"zhaolihui"},"change_message_id":"20f76c1592209c5d7fa9a9d17c1100e152ed2446","unresolved":false,"context_lines":[{"line_number":1337,"context_line":"            image_path \u003d os.path.join(target, \"root.hds\")"},{"line_number":1338,"context_line":"            libvirt_utils.copy_image(base, image_path)"},{"line_number":1339,"context_line":"            self._restore_descriptor(target, self.pcs_format, image_path)"},{"line_number":1340,"context_line":"            if size:"},{"line_number":1341,"context_line":"                self.resize_image(size)"},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":"        if not os.path.exists(self.path):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a18252c_eb189520","line":1340,"range":{"start_line":1340,"start_character":15,"end_line":1340,"end_character":19},"updated":"2016-04-14 02:42:15.000000000","message":"How about the \u0027size\u0027 value is -1 ?\nWhat will happen to call uilts.execute(\u0027ploop\u0027, \u0027grow\u0027, \u0027-s\u0027, \u0027%dK\u0027 % (size \u003e\u003e 10), dd_path, run_as_root\u003dTrue) ?","commit_id":"be991a6b33ce4b177a03c798d84dc9b9304f833e"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"907835e3633f65adb6f9b740761982b367a02dbc","unresolved":false,"context_lines":[{"line_number":1337,"context_line":"            image_path \u003d os.path.join(target, \"root.hds\")"},{"line_number":1338,"context_line":"            libvirt_utils.copy_image(base, image_path)"},{"line_number":1339,"context_line":"            self._restore_descriptor(target, self.pcs_format, image_path)"},{"line_number":1340,"context_line":"            if size:"},{"line_number":1341,"context_line":"                self.resize_image(size)"},{"line_number":1342,"context_line":""},{"line_number":1343,"context_line":"        if not os.path.exists(self.path):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a18252c_c2c9335b","line":1340,"range":{"start_line":1340,"start_character":15,"end_line":1340,"end_character":19},"in_reply_to":"5a18252c_eb189520","updated":"2016-04-14 08:40:43.000000000","message":"I suspect nothing good, but hopefully it\u0027s not possible to pass -1 to this function. However, that isn\u0027t related to this change.","commit_id":"be991a6b33ce4b177a03c798d84dc9b9304f833e"}]}