)]}'
{"id":"openstack%2Fnova~27820","triplet_id":"openstack%2Fnova~master~Idf519a88415844451b18959b38cc48ce92c090d1","project":"openstack/nova","branch":"master","topic":"bug/1171636","hashtags":[],"change_id":"Idf519a88415844451b18959b38cc48ce92c090d1","subject":"Fix building quantumapi network model with network list","status":"MERGED","created":"2013-04-30 16:18:15.000000000","updated":"2013-05-02 14:11:13.000000000","submitted":"2013-05-02 14:11:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2c2136392376de56517c1b61c4943e608e01184a","_number":27820,"virtual_id_number":27820,"owner":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":1,"date":"2013-04-30 16:39:45.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2013-05-02 14:11:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":2,"date":"2013-05-01 09:24:19.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":2,"date":"2013-05-02 13:26:44.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":1,"date":"2013-04-30 23:41:24.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-04-30 16:25:43.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"date":"2013-05-01 09:24:19.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":1,"date":"2013-05-02 13:26:44.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2013-04-30 16:18:41.000000000","_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"value":0,"date":"2013-05-01 05:54:08.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-04-30 16:18:41.000000000","updated_by":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"reviewer":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"state":"REVIEWER"},{"updated":"2013-04-30 16:25:43.000000000","updated_by":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"reviewer":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"state":"REVIEWER"},{"updated":"2013-04-30 16:39:45.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-01 05:54:08.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2013-05-01 09:24:19.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-05-02 13:26:44.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-05-02 14:11:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"4dc96207504ba6a3d687816cdb4bf9d187a590dc","author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"date":"2013-04-30 16:25:43.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ff438b3d7eb5c3022a609eb0e516a906c45bdf2f","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-04-30 16:39:45.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 18) Success: http://smokestack.openstack.org/?go\u003d/jobs/85096\n","accounts_in_message":[],"_revision_number":1},{"id":"ab15747ffc14de33d309fd6af2105488495f6e64","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-04-30 17:02:53.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/27820/1/check/gate-nova-pep8/25092 : SUCCESS\n- http://docs-draft.openstack.org/27820/1/check/gate-nova-docs/19310/doc/build/html/ : SUCCESS\n- http://logs.openstack.org/27820/1/check/gate-nova-python26/20718 : SUCCESS\n- http://logs.openstack.org/27820/1/check/gate-nova-python26-rhel6/1173 : SUCCESS (non-voting)\n- http://logs.openstack.org/27820/1/check/gate-nova-python27/20806 : SUCCESS\n- http://logs.openstack.org/27820/1/check/gate-tempest-devstack-vm-full/14027 : SUCCESS\n- http://logs.openstack.org/27820/1/check/gate-tempest-devstack-vm-postgres-full/13742 : FAILURE (non-voting)\n- http://logs.openstack.org/27820/1/check/gate-tempest-devstack-vm-quantum/20072 : SUCCESS\n- http://logs.openstack.org/27820/1/check/gate-grenade-devstack-vm/1857 : FAILURE (non-voting)\n- http://logs.openstack.org/27820/1/check/gate-nova-pylint/10877 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"eedce6d810a8a35102db45d550348591acbb751a","author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"date":"2013-04-30 23:41:24.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nAwesome work Dan! Looks good. Even cooler when testing and seeing it work :). Thanks.","accounts_in_message":[],"_revision_number":1},{"id":"247c200abff2d4d924c1d978626374e0130c1348","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-05-01 09:24:19.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"3adba20bd850e0213000cf0ca402dbd1810dd032","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-05-02 13:26:44.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"0ccb78fb1f3048fd6cb75d51cae222363a4aeba1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-02 13:26:49.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"a947abe590a6a158612a681ae91d68f6fdf0faa1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-02 14:11:10.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/27820/1/gate/gate-nova-docs/19460/doc/build/html/ : SUCCESS in 00:06:29\n- http://logs.openstack.org/27820/1/gate/gate-nova-pep8/25242 : SUCCESS in 00:02:55\n- http://logs.openstack.org/27820/1/gate/gate-nova-python26/20868 : SUCCESS in 00:18:06\n- http://logs.openstack.org/27820/1/gate/gate-nova-python27/20956 : SUCCESS in 00:08:35\n- http://logs.openstack.org/27820/1/gate/gate-tempest-devstack-vm-full/14315 : SUCCESS in 00:44:01\n- http://logs.openstack.org/27820/1/gate/gate-tempest-devstack-vm-postgres-full/14030 : FAILURE in 00:43:13 (non-voting)\n- http://logs.openstack.org/27820/1/gate/gate-tempest-devstack-vm-quantum/20419 : SUCCESS in 00:20:55\n- http://logs.openstack.org/27820/1/gate/gate-grenade-devstack-vm/2135 : FAILURE in 00:10:45 (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"0cb5482c75a2d788c392a195c0da8158c4fca22b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-02 14:11:13.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"08c7cf5c67a75dea9b453bd915a0cd55e67c4adc","revisions":{"08c7cf5c67a75dea9b453bd915a0cd55e67c4adc":{"kind":"REWORK","_number":1,"created":"2013-04-30 16:18:15.000000000","uploader":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"ref":"refs/changes/20/27820/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/20/27820/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/27820/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/27820/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/20/27820/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/20/27820/1"}}},"commit":{"parents":[{"commit":"a9c1480df7cd7bd192afffc8674db193f1a8aed4","subject":"Merge \"Remove local variable only used in logging.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a9c1480df7cd7bd192afffc8674db193f1a8aed4"}]}],"author":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2013-04-29 23:33:49.000000000","tz":-420},"committer":{"name":"Dan Smith","email":"danms@us.ibm.com","date":"2013-04-30 16:17:43.000000000","tz":-420},"subject":"Fix building quantumapi network model with network list","message":"Fix building quantumapi network model with network list\n\nBug 1171636 occurs when _build_network_info_model() receives a list\nof networks that does not fully map all of an instance\u0027s ports.\nIt crashes in _ensure_requested_network_ordering() when the list of\nall ports is sorted by the subset of networks provided.\n\nThis change simplifies the early part of that function to only\nconsider ports within the networks provided, and to always sort those\nports in network order. This allows us to remove some error path\ncode from the loop below that iterates over the ports (which contained\na fatal typo, by the way) which is now dead code.\n\nThe affected code is really untested at the moment, due to the\nstructure of the method, making it hard to add a unit test to cover\nthis fix. In order to make the change clear from the existing code,\nthis fix is provided here first, and the following patch restructures\nthe method and add tests for this change and the rest of the surrounding\ncode.\n\nFixes bug 1171636\n\nChange-Id: Idf519a88415844451b18959b38cc48ce92c090d1\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/08c7cf5c67a75dea9b453bd915a0cd55e67c4adc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/08c7cf5c67a75dea9b453bd915a0cd55e67c4adc"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"a9c1480df7cd7bd192afffc8674db193f1a8aed4","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}