)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"e87a173caeaa83912b69757f06afb0f5f661bd80","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This kind of revert commit 378681490b043a5a51a9f58fba138310c20ea235."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The general idea for this revert is that the current code exposes which"},{"line_number":12,"context_line":"SQL database is backing Nova. If Postgre, a HTTPBadRequest can be"},{"line_number":13,"context_line":"raised, whilst with MySQL only a HTTPNotFound can be raised. We don\u0027t"},{"line_number":14,"context_line":"want the API to depend on which SQL server is used."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"dae33548_d67a86f0","line":12,"range":{"start_line":12,"start_character":33,"end_line":12,"end_character":40},"updated":"2016-02-17 14:55:15.000000000","message":"nit: Postgres","commit_id":"366accdd5dd2ce757914f1ceb42f483eb564fcbf"}],"nova/api/openstack/compute/fixed_ips.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b028bc2fbb3f233c55c7db6694d9531fd3aa16d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        fixed_ip_info[\u0027fixed_ip\u0027][\u0027reserved\u0027] \u003d fixed_ip.reserved"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @extensions.expected_errors(404)"},{"line_number":43,"context_line":"    def show(self, req, id):"},{"line_number":44,"context_line":"        \"\"\"Return data about the given fixed IP.\"\"\""},{"line_number":45,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":46,"context_line":"        authorize(context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_96a759bc","line":43,"updated":"2016-02-17 16:01:39.000000000","message":"Seems you could just validate the input parameter is an ip_address using this:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L271","commit_id":"366accdd5dd2ce757914f1ceb42f483eb564fcbf"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7b028bc2fbb3f233c55c7db6694d9531fd3aa16d","unresolved":false,"context_lines":[{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @wsgi.response(202)"},{"line_number":76,"context_line":"    @extensions.expected_errors(404)"},{"line_number":77,"context_line":"    @validation.schema(fixed_ips.reserve)"},{"line_number":78,"context_line":"    @wsgi.action(\u0027reserve\u0027)"},{"line_number":79,"context_line":"    def reserve(self, req, id, body):"},{"line_number":80,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_b6d41d20","line":77,"range":{"start_line":77,"start_character":23,"end_line":77,"end_character":40},"updated":"2016-02-17 16:01:39.000000000","message":"This is weird, it uses parameter_types.none:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/fixed_ips.py#L22\n\nI\u0027m not sure why that\u0027s not validating a proper ip address.","commit_id":"366accdd5dd2ce757914f1ceb42f483eb564fcbf"}]}