)]}'
{"nova/objects/service.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"47f34bafb9731830c2429ad337bc693f4db57560","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                            for binary in binaries}"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        if min_versions:"},{"line_number":356,"context_line":"            version \u003d min(min_versions.values())"},{"line_number":357,"context_line":"        else:"},{"line_number":358,"context_line":"            version \u003d 0"},{"line_number":359,"context_line":"        # NOTE(danms): Since our return value is not controlled by object"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_1af6b6f8","line":356,"updated":"2016-02-29 22:30:37.000000000","message":"not sure why you\u0027re only reporting the minimum version for more than one service.\nWhy not returning the min_versions dict here and make sure that get_minimum_version will just return the value of the only one item in the dict?","commit_id":"bbf879878fd4eed23cfb75f88205cdd8b3fb1ff0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"94f1fad536a5707d16e874253b8a7629d8dd16a4","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                            for binary in binaries}"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        if min_versions:"},{"line_number":356,"context_line":"            version \u003d min(min_versions.values())"},{"line_number":357,"context_line":"        else:"},{"line_number":358,"context_line":"            version \u003d 0"},{"line_number":359,"context_line":"        # NOTE(danms): Since our return value is not controlled by object"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_3a973a3b","line":356,"in_reply_to":"9aed3d3a_1af6b6f8","updated":"2016-02-29 22:34:20.000000000","message":"Oh, I see the usage in https://review.openstack.org/#/c/279313/4/nova/objects/compute_node.py@320 but I still think it would better to change the caller by using get_minimum_version_multi() and do the min(values()) in the caller directly.","commit_id":"bbf879878fd4eed23cfb75f88205cdd8b3fb1ff0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"13ce7deb708429df420bf15ede914ac668af9f55","unresolved":false,"context_lines":[{"line_number":353,"context_line":"                            for binary in binaries}"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        if min_versions:"},{"line_number":356,"context_line":"            version \u003d min(min_versions.values())"},{"line_number":357,"context_line":"        else:"},{"line_number":358,"context_line":"            version \u003d 0"},{"line_number":359,"context_line":"        # NOTE(danms): Since our return value is not controlled by object"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_de9bb664","line":356,"in_reply_to":"9aed3d3a_3a973a3b","updated":"2016-03-03 13:56:10.000000000","message":"But the service version is a global concept. The caller just says which components they want to check. Seems silly to make all callers do the min() thing.\n\nThat would get get_minimum_versions() I guess.","commit_id":"bbf879878fd4eed23cfb75f88205cdd8b3fb1ff0"}]}