)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"79f3425566f0e8b3cbfed3d7679ff88726f4b49f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix wrong watermark state during live migration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"From the beginning info.data_remaining is equal to 0."},{"line_number":10,"context_line":"Watermark has been set by this value. But in future is get updated"},{"line_number":11,"context_line":"only if it is None or data_remaining is less then watermark."},{"line_number":12,"context_line":"So it remains unchanged."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"dab17558_4c25cea9","line":10,"updated":"2016-05-06 16:57:09.000000000","message":"Nit:\n\ns/.../But in the future it is getting updated only if it is None or data_remaining is less then watermark.","commit_id":"830cdbd1cf1c1432928f76d2914eb93fd4a0d76a"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"2ee0f6f908ee96e2b9e309eb860bb4a6f1a00e6b","unresolved":false,"context_lines":[{"line_number":6266,"context_line":""},{"line_number":6267,"context_line":"                if ((not progress_watermark) or"},{"line_number":6268,"context_line":"                    (progress_watermark \u003e info.data_remaining)):"},{"line_number":6269,"context_line":"                    if progress_watermark is None or \\"},{"line_number":6270,"context_line":"                        progress_watermark \u003e info.data_remaining:"},{"line_number":6271,"context_line":"                        progress_time \u003d now"},{"line_number":6272,"context_line":"                    progress_watermark \u003d info.data_remaining"},{"line_number":6273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_3d3e4a8c","line":6270,"range":{"start_line":6269,"start_character":20,"end_line":6270,"end_character":65},"updated":"2016-02-17 07:26:36.000000000","message":"this check looks is the same as if statement on line 6267, so how this will fix the original bug?","commit_id":"754bbbd688975ac401235b4ffc7aed8953a86964"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"fdf3a352a0eddb4b61d78511c9afc2c05077477e","unresolved":false,"context_lines":[{"line_number":6266,"context_line":""},{"line_number":6267,"context_line":"                if ((not progress_watermark) or"},{"line_number":6268,"context_line":"                    (progress_watermark \u003e info.data_remaining)):"},{"line_number":6269,"context_line":"                    if progress_watermark is None or \\"},{"line_number":6270,"context_line":"                        progress_watermark \u003e info.data_remaining:"},{"line_number":6271,"context_line":"                        progress_time \u003d now"},{"line_number":6272,"context_line":"                    progress_watermark \u003d info.data_remaining"},{"line_number":6273,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dae33548_5f621e3f","line":6270,"range":{"start_line":6269,"start_character":20,"end_line":6270,"end_character":65},"in_reply_to":"dae33548_3d3e4a8c","updated":"2016-02-17 09:32:45.000000000","message":"So the first watermark check will be True not just in case when watermark is None, but when it is 0 or \"\".\n   Originally problem is that info.data_remaining is equal to 0 from the beggining. It is not set to real size of data that should be transfared. So Progress watermark is set to 0, because it is originally None. And then it is not updated due to second condition even when info.data_remaining become real value.\n\n\n   progress_watermark     info.data_remaining\n0 |        None         |          0\n1 |          0          |          0\n..............................................\nN |          0          |          some big value\n\nSo in N-th step progress_watermark is not None already and first condition is False and it is not less then info.data_remaing , so code inside if statement wouldn\u0027t be executed and progress_watermark never updates from 0.","commit_id":"754bbbd688975ac401235b4ffc7aed8953a86964"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"2964d7233501cfb8055d072c9399f0eb0d7b47a2","unresolved":false,"context_lines":[{"line_number":6302,"context_line":"                abort \u003d False"},{"line_number":6303,"context_line":""},{"line_number":6304,"context_line":"                if ((progress_watermark is None) or"},{"line_number":6305,"context_line":"                    (progress_watermark \u003e info.data_remaining)):"},{"line_number":6306,"context_line":"                    progress_time \u003d now"},{"line_number":6307,"context_line":"                    LOG.debug(\"Live migration progress has been \""},{"line_number":6308,"context_line":"                              \"started at %(timestamp)s\","}],"source_content_type":"text/x-python","patch_set":13,"id":"1a122d0e_fc8fd42b","line":6305,"updated":"2016-05-04 13:38:31.000000000","message":"I think a simpler \u0026 clearer fix would be to change this condition to\n\nif ((info.data_transferred !\u003d 0) and\n    ((progress_watermark is None) or\n     (progress_watermark \u003e info.data_remaining))):\n\nBecause if live migration has not yet started, then data_transferred will be zero, and so we\u0027ll avoid setting progress_watermark to 0","commit_id":"c1ad396a6847b1ee74b0ba0eb2c23ce501f12112"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"607afe88fce46cf78c09f089302d3b52ed7dbf6e","unresolved":false,"context_lines":[{"line_number":6302,"context_line":"                abort \u003d False"},{"line_number":6303,"context_line":""},{"line_number":6304,"context_line":"                if ((progress_watermark is None) or"},{"line_number":6305,"context_line":"                    (progress_watermark \u003e info.data_remaining)):"},{"line_number":6306,"context_line":"                    progress_time \u003d now"},{"line_number":6307,"context_line":"                    LOG.debug(\"Live migration progress has been \""},{"line_number":6308,"context_line":"                              \"started at %(timestamp)s\","}],"source_content_type":"text/x-python","patch_set":13,"id":"dab17558_9cab6d89","line":6305,"in_reply_to":"1a122d0e_fc8fd42b","updated":"2016-05-06 15:28:26.000000000","message":"Thanks, will test it","commit_id":"c1ad396a6847b1ee74b0ba0eb2c23ce501f12112"}]}