)]}'
{"nova/compute/rpcapi.py":[{"author":{"_account_id":8768,"name":"Chris Friesen","email":"chris.friesen@windriver.com","username":"cbf123"},"change_message_id":"22d6de1b10880464062c521054861c99933e1402","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":764,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost, version\u003dversion)"},{"line_number":765,"context_line":"        return cctxt.call(ctxt, \u0027remove_volume_connection\u0027,"},{"line_number":766,"context_line":"                          volume_id\u003dvolume_id, instance\u003dinstance)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def rescue_instance(self, ctxt, instance, rescue_password,"},{"line_number":769,"context_line":"                        rescue_image_ref\u003dNone, clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_e7398da5","line":766,"range":{"start_line":766,"start_character":36,"end_line":766,"end_character":45},"updated":"2016-02-18 15:42:57.000000000","message":"This won\u0027t change any behaviour given that it\u0027s using named arguments.","commit_id":"d0fdbd30ca4ac25e07bdd91d74ba481f46142193"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"868327e574f429de5e44cd332e535efee6777da3","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":764,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost, version\u003dversion)"},{"line_number":765,"context_line":"        return cctxt.call(ctxt, \u0027remove_volume_connection\u0027,"},{"line_number":766,"context_line":"                          volume_id\u003dvolume_id, instance\u003dinstance)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def rescue_instance(self, ctxt, instance, rescue_password,"},{"line_number":769,"context_line":"                        rescue_image_ref\u003dNone, clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_19e156ff","line":766,"range":{"start_line":766,"start_character":36,"end_line":766,"end_character":45},"in_reply_to":"dae33548_d3636baf","updated":"2016-02-19 06:50:55.000000000","message":"The definition in compute/manager.py is:\n\n remove_volume_connection(self, context, volume_id, instance)\n\nand the issue is referring to the signature of the rpcapi function order being different.","commit_id":"d0fdbd30ca4ac25e07bdd91d74ba481f46142193"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"933947bc80b5126a8a54aefbb4d69eb07a0ce710","unresolved":false,"context_lines":[{"line_number":763,"context_line":"        version \u003d \u00274.0\u0027"},{"line_number":764,"context_line":"        cctxt \u003d self.client.prepare(server\u003dhost, version\u003dversion)"},{"line_number":765,"context_line":"        return cctxt.call(ctxt, \u0027remove_volume_connection\u0027,"},{"line_number":766,"context_line":"                          volume_id\u003dvolume_id, instance\u003dinstance)"},{"line_number":767,"context_line":""},{"line_number":768,"context_line":"    def rescue_instance(self, ctxt, instance, rescue_password,"},{"line_number":769,"context_line":"                        rescue_image_ref\u003dNone, clean_shutdown\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_d3636baf","line":766,"range":{"start_line":766,"start_character":36,"end_line":766,"end_character":45},"in_reply_to":"dae33548_e7398da5","updated":"2016-02-18 16:41:05.000000000","message":"Yes, with named arguments it won\u0027t change any behavior. The change is made to match definition in compute/manager.py","commit_id":"d0fdbd30ca4ac25e07bdd91d74ba481f46142193"}]}
