)]}'
{"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"b234dc92a9999f98091799721cb33c4af76591c2","unresolved":false,"context_lines":[{"line_number":1352,"context_line":"        self.moxed_client.list_ports("},{"line_number":1353,"context_line":"            device_id\u003dself.instance.uuid).AndReturn("},{"line_number":1354,"context_line":"                {\u0027ports\u0027: ret_data})"},{"line_number":1355,"context_line":"        self.moxed_client.list_extensions().AndReturn({\u0027extensions\u0027: []})"},{"line_number":1356,"context_line":"        if requested_networks:"},{"line_number":1357,"context_line":"            for net, fip, port, request_id in requested_networks:"},{"line_number":1358,"context_line":"                self.moxed_client.update_port(port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_fb232656","side":"PARENT","line":1355,"updated":"2016-02-17 17:49:01.000000000","message":"Not sure why you re-ordered this.","commit_id":"0fd6afdab775b07d1f45ea3847802593988dacca"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"e8aae5e9bfc08786e2333bfb53f3163e552f5fde","unresolved":false,"context_lines":[{"line_number":1352,"context_line":"        self.moxed_client.list_ports("},{"line_number":1353,"context_line":"            device_id\u003dself.instance.uuid).AndReturn("},{"line_number":1354,"context_line":"                {\u0027ports\u0027: ret_data})"},{"line_number":1355,"context_line":"        self.moxed_client.list_extensions().AndReturn({\u0027extensions\u0027: []})"},{"line_number":1356,"context_line":"        if requested_networks:"},{"line_number":1357,"context_line":"            for net, fip, port, request_id in requested_networks:"},{"line_number":1358,"context_line":"                self.moxed_client.update_port(port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_a174cc67","side":"PARENT","line":1355,"in_reply_to":"dae33548_fb232656","updated":"2016-02-17 18:48:14.000000000","message":"In deallocate_for_instance, I inserted a call to _has_port_binding_extension before the call to list_ports.\nLater, _unbind_ports is called, which also calls _has_port_binding_extenstion, but on the 2nd call, the cache doesn\u0027t need to be refreshed.","commit_id":"0fd6afdab775b07d1f45ea3847802593988dacca"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"b234dc92a9999f98091799721cb33c4af76591c2","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"            device_id\u003dself.instance.uuid).AndReturn("},{"line_number":1416,"context_line":"                {\u0027ports\u0027: port_data})"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"        self.moxed_client.list_extensions().AndReturn({\u0027extensions\u0027: []})"},{"line_number":1419,"context_line":"        NeutronNotFound \u003d exceptions.NeutronClientException(status_code\u003d404)"},{"line_number":1420,"context_line":"        for port in reversed(port_data):"},{"line_number":1421,"context_line":"            self.moxed_client.delete_port(port[\u0027id\u0027]).AndRaise("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_5b15f2e2","side":"PARENT","line":1418,"updated":"2016-02-17 17:49:01.000000000","message":"Ditto","commit_id":"0fd6afdab775b07d1f45ea3847802593988dacca"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"e8aae5e9bfc08786e2333bfb53f3163e552f5fde","unresolved":false,"context_lines":[{"line_number":1415,"context_line":"            device_id\u003dself.instance.uuid).AndReturn("},{"line_number":1416,"context_line":"                {\u0027ports\u0027: port_data})"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"        self.moxed_client.list_extensions().AndReturn({\u0027extensions\u0027: []})"},{"line_number":1419,"context_line":"        NeutronNotFound \u003d exceptions.NeutronClientException(status_code\u003d404)"},{"line_number":1420,"context_line":"        for port in reversed(port_data):"},{"line_number":1421,"context_line":"            self.moxed_client.delete_port(port[\u0027id\u0027]).AndRaise("}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_01a8188c","side":"PARENT","line":1418,"in_reply_to":"dae33548_5b15f2e2","updated":"2016-02-17 18:48:14.000000000","message":"Its the same reason as above, except in this case _unbind_ports is not called.\n\nI\u0027ll update the commit message.","commit_id":"0fd6afdab775b07d1f45ea3847802593988dacca"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"b234dc92a9999f98091799721cb33c4af76591c2","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                            macs.discard(\u0027my_mac1\u0027)"},{"line_number":452,"context_line":"                else:"},{"line_number":453,"context_line":"                    fixed_ips[request.network_id] \u003d request.address"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"                req_net_ids.append(request.network_id)"},{"line_number":456,"context_line":"                ordered_networks.append(request)"},{"line_number":457,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_7b01d6ae","line":454,"updated":"2016-02-17 17:49:01.000000000","message":"delete this","commit_id":"221870b28ed8195a74c5b222c3328e8350c02d3d"},{"author":{"_account_id":17139,"name":"Chuck Carmack","email":"carmack@us.ibm.com","username":"ccarmack"},"change_message_id":"e8aae5e9bfc08786e2333bfb53f3163e552f5fde","unresolved":false,"context_lines":[{"line_number":451,"context_line":"                            macs.discard(\u0027my_mac1\u0027)"},{"line_number":452,"context_line":"                else:"},{"line_number":453,"context_line":"                    fixed_ips[request.network_id] \u003d request.address"},{"line_number":454,"context_line":""},{"line_number":455,"context_line":"                req_net_ids.append(request.network_id)"},{"line_number":456,"context_line":"                ordered_networks.append(request)"},{"line_number":457,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_1e7b57f6","line":454,"in_reply_to":"dae33548_7b01d6ae","updated":"2016-02-17 18:48:14.000000000","message":"Done","commit_id":"221870b28ed8195a74c5b222c3328e8350c02d3d"}]}