)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"4d4eaad1e363310339f27ace1bb1443fbd41d1e0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-08 19:51:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactory query user_id code for quota-sets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"do not need to use urlparse and consistent to other API code."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_dd6b1a84","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"updated":"2016-09-09 13:26:59.000000000","message":"Should be \"Refactored\"","commit_id":"a8feb924bae0e91b68611fae3256c4e1ccd60e20"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9f818dd3dd31b2a311bae0d2935fd0a3cf8ba486","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     jichenjc \u003cjichenjc@cn.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-09-08 19:51:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactory query user_id code for quota-sets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"do not need to use urlparse and consistent to other API code."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_b9dd4172","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":9},"in_reply_to":"9a89bdaa_dd6b1a84","updated":"2016-09-12 11:37:57.000000000","message":"Done","commit_id":"a8feb924bae0e91b68611fae3256c4e1ccd60e20"},{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"4d4eaad1e363310339f27ace1bb1443fbd41d1e0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactory query user_id code for quota-sets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"do not need to use urlparse and consistent to other API code."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I40ffa8a2484fe8be3aeb077d2393f91e38b868dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_bd1c9614","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":42},"updated":"2016-09-09 13:26:59.000000000","message":"I think this should be \"Don\u0027t use urlparse to be consistent to other API code\"","commit_id":"a8feb924bae0e91b68611fae3256c4e1ccd60e20"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9f818dd3dd31b2a311bae0d2935fd0a3cf8ba486","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"refactory query user_id code for quota-sets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"do not need to use urlparse and consistent to other API code."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I40ffa8a2484fe8be3aeb077d2393f91e38b868dd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9a89bdaa_79f3b90a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":42},"in_reply_to":"9a89bdaa_bd1c9614","updated":"2016-09-12 11:37:57.000000000","message":"Done","commit_id":"a8feb924bae0e91b68611fae3256c4e1ccd60e20"}],"nova/api/openstack/compute/quota_sets.py":[{"author":{"_account_id":18602,"name":"Gábor Antal","email":"antal@inf.u-szeged.hu","username":"antal"},"change_message_id":"4d4eaad1e363310339f27ace1bb1443fbd41d1e0","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                result[resource] \u003d quota_set[resource]"},{"line_number":57,"context_line":"        return dict(quota_set\u003dresult)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_user_id(self, req):"},{"line_number":60,"context_line":"        if \u0027user_id\u0027 in req.GET.keys():"},{"line_number":61,"context_line":"            user_id \u003d req.GET.getall(\u0027user_id\u0027)[0]"},{"line_number":62,"context_line":"            return user_id"},{"line_number":63,"context_line":"        return None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _validate_quota_limit(self, resource, limit, minimum, maximum):"},{"line_number":66,"context_line":"        def conv_inf(value):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_bd6496e5","line":63,"range":{"start_line":59,"start_character":0,"end_line":63,"end_character":19},"updated":"2016-09-09 13:26:59.000000000","message":"I think if you refactor something, you should also add great code that shouldn\u0027t be refactored, something like this:\n\n    def _get_user_id(self, req):\n        user_id \u003d None\n        if \u0027user_id\u0027 in req.GET.keys():\n            user_id \u003d req.GET.getall(\u0027user_id\u0027)[0]\n        return user_id","commit_id":"a8feb924bae0e91b68611fae3256c4e1ccd60e20"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9f818dd3dd31b2a311bae0d2935fd0a3cf8ba486","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                result[resource] \u003d quota_set[resource]"},{"line_number":57,"context_line":"        return dict(quota_set\u003dresult)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def _get_user_id(self, req):"},{"line_number":60,"context_line":"        if \u0027user_id\u0027 in req.GET.keys():"},{"line_number":61,"context_line":"            user_id \u003d req.GET.getall(\u0027user_id\u0027)[0]"},{"line_number":62,"context_line":"            return user_id"},{"line_number":63,"context_line":"        return None"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _validate_quota_limit(self, resource, limit, minimum, maximum):"},{"line_number":66,"context_line":"        def conv_inf(value):"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a89bdaa_f96269d7","line":63,"range":{"start_line":59,"start_character":0,"end_line":63,"end_character":19},"in_reply_to":"9a89bdaa_bd6496e5","updated":"2016-09-12 11:37:57.000000000","message":"Done","commit_id":"a8feb924bae0e91b68611fae3256c4e1ccd60e20"},{"author":{"_account_id":21813,"name":"Andrey Volkov","email":"m@amadev.ru","username":"avolkov"},"change_message_id":"49895a1e0ed0a14f7b3ebcb86921eb6cce77d353","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def _get_user_id(self, req):"},{"line_number":60,"context_line":"        user_id \u003d None"},{"line_number":61,"context_line":"        if \u0027user_id\u0027 in req.GET.keys():"},{"line_number":62,"context_line":"            user_id \u003d req.GET.getall(\u0027user_id\u0027)[0]"},{"line_number":63,"context_line":"        return user_id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _validate_quota_limit(self, resource, limit, minimum, maximum):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_6a7e43b0","line":62,"updated":"2016-12-21 16:11:43.000000000","message":"req.GET.get seems logical here but it changes behavior as it returns the last element instead of the first one. So getall is right.","commit_id":"22fe2ccf62d2691576e862a3f18a182c0d4fa605"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8f6cf899cdc6ff02d58ab34cb9a4c20fab36480c","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    def _get_user_id(self, req):"},{"line_number":60,"context_line":"        user_id \u003d None"},{"line_number":61,"context_line":"        if \u0027user_id\u0027 in req.GET.keys():"},{"line_number":62,"context_line":"            user_id \u003d req.GET.getall(\u0027user_id\u0027)[0]"},{"line_number":63,"context_line":"        return user_id"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def _validate_quota_limit(self, resource, limit, minimum, maximum):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1a6eadb0_b031aa0d","line":62,"in_reply_to":"1a6eadb0_6a7e43b0","updated":"2016-12-21 16:54:57.000000000","message":"It would be helpful to document this inline to prevent people changing it in the future","commit_id":"22fe2ccf62d2691576e862a3f18a182c0d4fa605"}]}