)]}'
{"nova/compute/api.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"9aad1e9d69a64cb84e494d9bce164da63fa0212d","unresolved":false,"context_lines":[{"line_number":2596,"context_line":"                overs \u003d exc.kwargs[\u0027overs\u0027]"},{"line_number":2597,"context_line":"                usages \u003d exc.kwargs[\u0027usages\u0027]"},{"line_number":2598,"context_line":"                # Resize only target on 1 instance"},{"line_number":2599,"context_line":"                deltas[\u0027instances\u0027] \u003d 1"},{"line_number":2600,"context_line":"                headroom \u003d self._get_headroom(quotas, usages, deltas)"},{"line_number":2601,"context_line":"                (overs, reqs, total_alloweds,"},{"line_number":2602,"context_line":"                 useds) \u003d self._get_over_quota_detail(headroom, overs, quotas,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_af0e65e2","line":2599,"range":{"start_line":2599,"start_character":16,"end_line":2599,"end_character":39},"updated":"2016-02-18 01:28:12.000000000","message":"This should be \"quotas[\u0027instances\u0027] \u003d 1\".\nOr remove this line and change \"headroom[\u0027instances\u0027]\" to \"headroom.get(\u0027instances\u0027, 1)\" in _get_headroom method.","commit_id":"fd7f9dd9f3012589cfe3770c0d6eb8221d614c4c"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d51f58018ecbe16c5643785a9e607dfb67cdc6a1","unresolved":false,"context_lines":[{"line_number":295,"context_line":"                hc \u003d headroom.get(\u0027instances\u0027, 1) * deltas[\u0027cores\u0027]"},{"line_number":296,"context_line":"                headroom[\u0027cores\u0027] \u003d hc / deltas.get(\u0027instances\u0027, 1)"},{"line_number":297,"context_line":"            else:"},{"line_number":298,"context_line":"                headroom[\u0027cores\u0027] \u003d headroom[\u0027instances\u0027]"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        # If quota_ram is unlimited [-1]:"},{"line_number":301,"context_line":"        # - set ram headroom based on instances headroom:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_38b181e2","line":298,"updated":"2016-02-20 17:04:43.000000000","message":"won\u0027t this be the same issue here?","commit_id":"826191ca512797b833c132a53f3c50de35f378e0"},{"author":{"_account_id":13692,"name":"Roman Dobosz","email":"gryf73@gmail.com","username":"gryf"},"change_message_id":"be1cc72ed885ddd0de11db72e8cbfbae16b092a8","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        # - set ram headroom based on instances headroom:"},{"line_number":302,"context_line":"        if quotas.get(\u0027ram\u0027) \u003d\u003d -1:"},{"line_number":303,"context_line":"            if deltas.get(\u0027ram\u0027):"},{"line_number":304,"context_line":"                hr \u003d headroom[\u0027instances\u0027] * deltas[\u0027ram\u0027]"},{"line_number":305,"context_line":"                headroom[\u0027ram\u0027] \u003d hr / deltas.get(\u0027instances\u0027, 1)"},{"line_number":306,"context_line":"            else:"},{"line_number":307,"context_line":"                headroom[\u0027ram\u0027] \u003d headroom.get(\u0027instances\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_2a588a89","line":304,"range":{"start_line":304,"start_character":16,"end_line":304,"end_character":42},"updated":"2016-02-23 20:13:41.000000000","message":"IMHO you missed that one, esp that on line 307 you\u0027ve changed it with get() method.","commit_id":"0994d9e45b19d1be72bdcaef8c7ade1b5901ab3a"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"9e49abcdbbe2ef4bca1047652ba3c3f10339a2c9","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                      \u0027cores\u0027: req_cores, \u0027ram\u0027: req_ram}"},{"line_number":333,"context_line":"            headroom \u003d self._get_headroom(quotas, usages, deltas)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"            allowed \u003d headroom[\u0027instances\u0027]"},{"line_number":336,"context_line":"            # Reduce \u0027allowed\u0027 instances in line with the cores \u0026 ram headroom"},{"line_number":337,"context_line":"            if instance_type[\u0027vcpus\u0027]:"},{"line_number":338,"context_line":"                allowed \u003d min(allowed,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_397a6cbd","line":335,"updated":"2016-04-21 11:08:36.000000000","message":"don\u0027t we also need to fix this usage?\n\nMaybe just insert 1 if its not populated?","commit_id":"e78a75dccd7a69fb08f7f4dcc9bdf4ff83cfc085"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"92a0f6926e752fbfabc9f672bd69ac0c6aa49df3","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                      \u0027cores\u0027: req_cores, \u0027ram\u0027: req_ram}"},{"line_number":333,"context_line":"            headroom \u003d self._get_headroom(quotas, usages, deltas)"},{"line_number":334,"context_line":""},{"line_number":335,"context_line":"            allowed \u003d headroom[\u0027instances\u0027]"},{"line_number":336,"context_line":"            # Reduce \u0027allowed\u0027 instances in line with the cores \u0026 ram headroom"},{"line_number":337,"context_line":"            if instance_type[\u0027vcpus\u0027]:"},{"line_number":338,"context_line":"                allowed \u003d min(allowed,"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a122d0e_5301b769","line":335,"in_reply_to":"1a122d0e_397a6cbd","updated":"2016-04-22 20:13:49.000000000","message":"yeah, will make it","commit_id":"e78a75dccd7a69fb08f7f4dcc9bdf4ff83cfc085"}]}