)]}'
{"nova/tests/unit/objects/object_attributes.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"58d1c18f5157bcd2a516e97e8834fffa64d482b7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"                   \u0027architecture\u0027,"},{"line_number":10,"context_line":"                   \u0027deleted_at\u0027,"},{"line_number":11,"context_line":"                   \u0027os\u0027,"},{"line_number":12,"context_line":"                   \u0027id\u0027]},"},{"line_number":13,"context_line":" \u0027AgentList\u0027: {\u00271.0\u0027: [\u0027objects\u0027]},"},{"line_number":14,"context_line":" \u0027Aggregate\u0027: {\u00271.0\u0027: [\u0027name\u0027,"},{"line_number":15,"context_line":"                       \u0027deleted\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_bea6f40d","line":12,"updated":"2016-02-16 16:31:02.000000000","message":"Actually, we might as well skip \u0027N.0\u0027 for any object and make this a lot shorter.","commit_id":"3090f237b59a1610d36340a259d865b2fc65f048"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1cd6560ad155c5faa5be054e94228a89df64590a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OBJECT_ATTRIBUTE_DATA \u003d \\"},{"line_number":2,"context_line":"{\u0027ComputeNode\u0027: {\u00271.16\u0027: [\u0027disk_allocation_ratio\u0027],"},{"line_number":3,"context_line":"                 \u00271.14\u0027: [\u0027ram_allocation_ratio\u0027, \u0027cpu_allocation_ratio\u0027],"},{"line_number":4,"context_line":"                 \u00271.15\u0027: [\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_87d7c5ec","line":1,"updated":"2016-02-24 19:48:22.000000000","message":"Why not just throw this in test_objects like the object_data dict for versions?","commit_id":"a5a66f092b4d39ea32573f037a53962f689207a2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"320d56c82f8d1aebfdff99a0e38cac24a4ceec22","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OBJECT_ATTRIBUTE_DATA \u003d \\"},{"line_number":2,"context_line":"{\u0027ComputeNode\u0027: {\u00271.16\u0027: [\u0027disk_allocation_ratio\u0027],"},{"line_number":3,"context_line":"                 \u00271.14\u0027: [\u0027ram_allocation_ratio\u0027, \u0027cpu_allocation_ratio\u0027],"},{"line_number":4,"context_line":"                 \u00271.15\u0027: [\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_aaf0d0ca","line":1,"in_reply_to":"bae84128_4722dd02","updated":"2016-02-24 20:02:45.000000000","message":"Correct.","commit_id":"a5a66f092b4d39ea32573f037a53962f689207a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bfc9ff5a210d99fd7ffb3c440a559591f2da5940","unresolved":false,"context_lines":[{"line_number":1,"context_line":"OBJECT_ATTRIBUTE_DATA \u003d \\"},{"line_number":2,"context_line":"{\u0027ComputeNode\u0027: {\u00271.16\u0027: [\u0027disk_allocation_ratio\u0027],"},{"line_number":3,"context_line":"                 \u00271.14\u0027: [\u0027ram_allocation_ratio\u0027, \u0027cpu_allocation_ratio\u0027],"},{"line_number":4,"context_line":"                 \u00271.15\u0027: [\u0027uuid\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_4722dd02","line":1,"in_reply_to":"bae84128_87d7c5ec","updated":"2016-02-24 19:51:57.000000000","message":"How about some comments above the variable explaining what it\u0027s for and when it needs to change?\n\n--\n\nOh I guess you have this in it\u0027s own file so you can generate it.","commit_id":"a5a66f092b4d39ea32573f037a53962f689207a2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d1353b90b5558da8c228b04b9b58d5476b6ab5c5","unresolved":false,"context_lines":[{"line_number":6,"context_line":"                 \u00271.4\u0027: [\u0027host_ip\u0027],"},{"line_number":7,"context_line":"                 \u00271.5\u0027: [\u0027numa_topology\u0027],"},{"line_number":8,"context_line":"                 \u00271.7\u0027: [\u0027host\u0027]},"},{"line_number":9,"context_line":" \u0027FixedIP\u0027: {\u00271.4\u0027: [\u0027default_route\u0027]},"},{"line_number":10,"context_line":" \u0027ImageMetaProps\u0027: {\u00271.11\u0027: [\u0027hw_firmware_type\u0027],"},{"line_number":11,"context_line":"                    \u00271.2\u0027: [\u0027img_hv_requested_version\u0027, \u0027img_hv_type\u0027],"},{"line_number":12,"context_line":"                    \u00271.4\u0027: [\u0027hw_vif_multiqueue_enabled\u0027],"}],"source_content_type":"text/x-python","patch_set":4,"id":"bae84128_dde7dc44","line":9,"updated":"2016-02-24 20:12:46.000000000","message":"Why isn\u0027t floating_ips in this list for 1.5?","commit_id":"a5a66f092b4d39ea32573f037a53962f689207a2"}],"nova/tests/unit/objects/test_objects.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3511527ac1deed1664ba6a98f39f2a1a2d7f19f4","unresolved":false,"context_lines":[{"line_number":1314,"context_line":""},{"line_number":1315,"context_line":""},{"line_number":1316,"context_line":"class TestObjectAttributes(test.NoDBTestCase):"},{"line_number":1317,"context_line":"    @mock.patch(\u0027nova.objects.Service.get_by_compute_host\u0027)"},{"line_number":1318,"context_line":"    def test_obj_make_compatible(self, mock_cn):"},{"line_number":1319,"context_line":"        # Make sure obj_make_compatible removes attributes"},{"line_number":1320,"context_line":"        # according to the schedule set out in object_attributes"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_af451771","line":1317,"updated":"2016-02-23 10:47:56.000000000","message":"nit: I would have preferred to use a contextmanager for mock.patch around the method which was calling it, but that\u0027s fine","commit_id":"45166af4459e5298994603049556e7082726fcbf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3511527ac1deed1664ba6a98f39f2a1a2d7f19f4","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"            # InstanceGroup forcibly creates this field on backport before"},{"line_number":1331,"context_line":"            # version 1.6."},{"line_number":1332,"context_line":"            \u0027InstanceGroup\u0027: [\u0027metadetails\u0027],"},{"line_number":1333,"context_line":"        }"},{"line_number":1334,"context_line":"        for obj_name in obj_classes:"},{"line_number":1335,"context_line":"            obj_class \u003d obj_classes[obj_name][0]"},{"line_number":1336,"context_line":"            version \u003d versionutils.convert_version_to_tuple(obj_class.VERSION)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0e57ba58","line":1333,"updated":"2016-02-23 10:47:56.000000000","message":"I also wonder if that would have been a bit better to be in the object_attributes module, but that\u0027s a nit too.","commit_id":"45166af4459e5298994603049556e7082726fcbf"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"3511527ac1deed1664ba6a98f39f2a1a2d7f19f4","unresolved":false,"context_lines":[{"line_number":1384,"context_line":"            with open(\u0027object_attributes.py\u0027, \u0027w\u0027) as f:"},{"line_number":1385,"context_line":"                f.write(\u0027OBJECT_ATTRIBUTE_DATA \u003d \\\\\\n\u0027)"},{"line_number":1386,"context_line":"                f.write(pprint.pformat(dict(gen_attr_data)))"},{"line_number":1387,"context_line":"                raise test.TestingException(\u0027Generated object_attributes.py\u0027)"},{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":""},{"line_number":1390,"context_line":"class TestObjEqualPrims(_BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0e8cdad8","line":1387,"updated":"2016-02-23 10:47:56.000000000","message":"thanks for keeping that possibility","commit_id":"45166af4459e5298994603049556e7082726fcbf"}]}