)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"02e08ac2950471047ee9d106a71ee7800785ac33","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                try:"},{"line_number":348,"context_line":"                    self._instance_update(context, instance, task_state\u003dNone)"},{"line_number":349,"context_line":"                    msg \u003d _LI(\"Task state reverted on failure for instance.\")"},{"line_number":350,"context_line":"                    LOG.info(msg, instance\u003dinstance)"},{"line_number":351,"context_line":"                except exception.InstanceNotFound:"},{"line_number":352,"context_line":"                    # We might delete an instance that failed to build shortly"},{"line_number":353,"context_line":"                    # after it errored out this is an expected case and we"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_9985dd08","line":350,"updated":"2016-02-17 11:27:38.000000000","message":"I\u0027d rather use msg and have a discoverable, complete string than wrap it over a few lines in this instance. Happy to remove msg if others agree with you but I really don\u0027t think it matters that much.","commit_id":"d91426b188f157710d10ec28d3fda5931bc10c3b"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"0fc1e20a8ddd6078bea6a68e1ee52f5729d32923","unresolved":false,"context_lines":[{"line_number":346,"context_line":"                instance \u003d keyed_args[\u0027instance\u0027]"},{"line_number":347,"context_line":"                try:"},{"line_number":348,"context_line":"                    self._instance_update(context, instance, task_state\u003dNone)"},{"line_number":349,"context_line":"                    msg \u003d _LI(\"Task state reverted on failure for instance.\")"},{"line_number":350,"context_line":"                    LOG.info(msg, instance\u003dinstance)"},{"line_number":351,"context_line":"                except exception.InstanceNotFound:"},{"line_number":352,"context_line":"                    # We might delete an instance that failed to build shortly"},{"line_number":353,"context_line":"                    # after it errored out this is an expected case and we"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_0bbd0102","line":350,"range":{"start_line":349,"start_character":0,"end_line":350,"end_character":52},"updated":"2016-02-17 05:59:19.000000000","message":"The variable \u0027msg\u0027 is used only once.\nSo the following would be better.\n\nLOG.info(_LI(\"Task state reverted on failure \"\n             \"for instance.\"), instance\u003dinstance)","commit_id":"d91426b188f157710d10ec28d3fda5931bc10c3b"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"2a0b3f286f2f2619c85dad69e77fb598ae206509","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                try:"},{"line_number":348,"context_line":"                    self._instance_update(context, instance, task_state\u003dNone)"},{"line_number":349,"context_line":"                    msg \u003d _LI(\"Task state reverted on failure for instance.\")"},{"line_number":350,"context_line":"                    LOG.info(msg, instance\u003dinstance)"},{"line_number":351,"context_line":"                except exception.InstanceNotFound:"},{"line_number":352,"context_line":"                    # We might delete an instance that failed to build shortly"},{"line_number":353,"context_line":"                    # after it errored out this is an expected case and we"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_64e0db29","line":350,"in_reply_to":"dae33548_95b1024a","updated":"2016-02-18 15:28:33.000000000","message":"+1 on giving more information about the actual task states being reverted here. I don\u0027t really care about the separate msg variable, but I agree it\u0027s not how most of the surrounding code is written so am slightly in favor of consistency.","commit_id":"d91426b188f157710d10ec28d3fda5931bc10c3b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"0102053d21d9e44a57a3dc2485dac44bbd3ea59c","unresolved":false,"context_lines":[{"line_number":347,"context_line":"                try:"},{"line_number":348,"context_line":"                    self._instance_update(context, instance, task_state\u003dNone)"},{"line_number":349,"context_line":"                    msg \u003d _LI(\"Task state reverted on failure for instance.\")"},{"line_number":350,"context_line":"                    LOG.info(msg, instance\u003dinstance)"},{"line_number":351,"context_line":"                except exception.InstanceNotFound:"},{"line_number":352,"context_line":"                    # We might delete an instance that failed to build shortly"},{"line_number":353,"context_line":"                    # after it errored out this is an expected case and we"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_95b1024a","line":350,"in_reply_to":"dae33548_9985dd08","updated":"2016-02-17 19:59:24.000000000","message":"guess we can say the state before revert here to provide more info?","commit_id":"d91426b188f157710d10ec28d3fda5931bc10c3b"}]}