)]}'
{"nova/compute/stats.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c4922e22a78d20efadb1f9abc8cfc7cc83210d41","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        (vm_state, task_state, os_type, project_id) \u003d \\"},{"line_number":107,"context_line":"                self._extract_state_from_instance(instance)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        if vm_state in resource_tracker._REMOVED_STATES:"},{"line_number":110,"context_line":"            self._decrement(\"num_instances\")"},{"line_number":111,"context_line":"            self.states.pop(uuid)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_620b068f","line":109,"range":{"start_line":109,"start_character":40,"end_line":109,"end_character":41},"updated":"2016-02-17 10:04:32.000000000","message":"nit: This shouldn\u0027t be private if you\u0027re using it outside the file, right?","commit_id":"a54997c62f1422c592dbabc28ea71d0a34e70b74"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"0297ff3a80e8c7bf56d80f324cc05e9d7b5dbff1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        (vm_state, task_state, os_type, project_id) \u003d \\"},{"line_number":107,"context_line":"                self._extract_state_from_instance(instance)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        if vm_state in resource_tracker._REMOVED_STATES:"},{"line_number":110,"context_line":"            self._decrement(\"num_instances\")"},{"line_number":111,"context_line":"            self.states.pop(uuid)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_9b3c99c9","line":109,"range":{"start_line":109,"start_character":40,"end_line":109,"end_character":41},"in_reply_to":"dae33548_620b068f","updated":"2016-02-17 18:00:52.000000000","message":"was wondering if someone would notice this :)\n\nTBH this is really not properly outside imho so I\u0027d keep it private.","commit_id":"a54997c62f1422c592dbabc28ea71d0a34e70b74"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f3ca86d983a291e644989380fefd10fbfef8ded1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        (vm_state, task_state, os_type, project_id) \u003d \\"},{"line_number":107,"context_line":"                self._extract_state_from_instance(instance)"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        if vm_state in resource_tracker._REMOVED_STATES:"},{"line_number":110,"context_line":"            self._decrement(\"num_instances\")"},{"line_number":111,"context_line":"            self.states.pop(uuid)"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_51f5aeea","line":109,"range":{"start_line":109,"start_character":40,"end_line":109,"end_character":41},"in_reply_to":"dae33548_9b3c99c9","updated":"2016-02-18 10:22:27.000000000","message":"I\u0027m not really worried by the use of a private attribute, but we just need to be super clear that we create a dependency here - /me checks the UTs","commit_id":"a54997c62f1422c592dbabc28ea71d0a34e70b74"}],"nova/tests/unit/compute/test_stats.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"d1060cd836c0187ff7f4326001a0b8ca73792af1","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    def test_update_stats_for_instance_offloaded(self):"},{"line_number":199,"context_line":"        instance \u003d self._create_instance()"},{"line_number":200,"context_line":"        self.stats.update_stats_for_instance(instance)"},{"line_number":201,"context_line":"        self.assertEqual(1, self.stats[\"num_proj_1234\"])"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        instance[\"vm_state\"] \u003d vm_states.SHELVED_OFFLOADED"},{"line_number":204,"context_line":"        self.stats.update_stats_for_instance(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_6f24a6ae","line":201,"updated":"2016-02-16 22:11:08.000000000","message":"I\u0027m guessing this is the same check as self.stats.num_instances_for_project(\"1234\") below? It would be better to check this through the same mechanism if that\u0027s the case so the test shows the value decreasing. I see that this is how the test above does it, but I think it could be improved.","commit_id":"a54997c62f1422c592dbabc28ea71d0a34e70b74"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"f3ca86d983a291e644989380fefd10fbfef8ded1","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    def test_update_stats_for_instance_offloaded(self):"},{"line_number":199,"context_line":"        instance \u003d self._create_instance()"},{"line_number":200,"context_line":"        self.stats.update_stats_for_instance(instance)"},{"line_number":201,"context_line":"        self.assertEqual(1, self.stats[\"num_proj_1234\"])"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"        instance[\"vm_state\"] \u003d vm_states.SHELVED_OFFLOADED"},{"line_number":204,"context_line":"        self.stats.update_stats_for_instance(instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_71aa7286","line":201,"in_reply_to":"dae33548_6f24a6ae","updated":"2016-02-18 10:22:27.000000000","message":"I\u0027m +1 on that, I tho feel the current UT covers the necessary. As you said, it could be done in a follow-up change.","commit_id":"a54997c62f1422c592dbabc28ea71d0a34e70b74"}]}