)]}'
{"nova/api/openstack/wsgi.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"3e90a6dd171bfea4069a16812429b700a8ce1081","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_db_instance(self, instance_uuid):"},{"line_number":147,"context_line":"        if strutils.is_int_like(instance_uuid):"},{"line_number":148,"context_line":"            instances \u003d self.get_db_items(\u0027instances\u0027)"},{"line_number":149,"context_line":"            for idx in instances:"},{"line_number":150,"context_line":"                if instances[idx][\u0027id\u0027] \u003d\u003d int(instance_uuid):"},{"line_number":151,"context_line":"                    return instances[idx]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_e85530fa","line":148,"updated":"2016-02-17 11:54:45.000000000","message":"this is returning the entire instances table and searching it in python?\n\nThis is definitely not ok.","commit_id":"a57781a84bf0057e0c4418f0ae110c3d71e6dd53"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"24a9b4dbadd0fc0ac4871a948e2e4212dba69280","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def get_db_instance(self, instance_uuid):"},{"line_number":147,"context_line":"        if strutils.is_int_like(instance_uuid):"},{"line_number":148,"context_line":"            instances \u003d self.get_db_items(\u0027instances\u0027)"},{"line_number":149,"context_line":"            for idx in instances:"},{"line_number":150,"context_line":"                if instances[idx][\u0027id\u0027] \u003d\u003d int(instance_uuid):"},{"line_number":151,"context_line":"                    return instances[idx]"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_128cffd8","line":148,"in_reply_to":"dae33548_e85530fa","updated":"2016-02-17 13:50:16.000000000","message":"agree\nthis is only for openstack API, not for EC2 API\nmaybe so we can raise HTTPNotFound if we found this is a valid uuid intput?","commit_id":"a57781a84bf0057e0c4418f0ae110c3d71e6dd53"}]}