)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8f61d079040d22a9b21fd647f3f16409bf0a5041","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Remove the int id facility. Remove the test for it. Update the other"},{"line_number":21,"context_line":"tests that were sneaking in and using id\u003d\u003d1 like very naughty folks"},{"line_number":22,"context_line":"(there will be coal in your stocking this year)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1522536"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_f8b79ed5","line":22,"range":{"start_line":22,"start_character":1,"end_line":22,"end_character":46},"updated":"2016-02-17 22:28:07.000000000","message":"This is highly offensive to non-christians! I demand you remove it!","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f24eb038c294192d3f61ed635abb69a4385359d6","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Remove the int id facility. Remove the test for it. Update the other"},{"line_number":21,"context_line":"tests that were sneaking in and using id\u003d\u003d1 like very naughty folks"},{"line_number":22,"context_line":"(there will be coal in your stocking this year)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1522536"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_c9312a5c","line":22,"range":{"start_line":22,"start_character":1,"end_line":22,"end_character":46},"in_reply_to":"dae33548_ce1e506f","updated":"2016-02-17 23:49:48.000000000","message":"I meant non-pagan.","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"00556d7fd7234b9cbfaaa4d940c17e67448dae03","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Remove the int id facility. Remove the test for it. Update the other"},{"line_number":21,"context_line":"tests that were sneaking in and using id\u003d\u003d1 like very naughty folks"},{"line_number":22,"context_line":"(there will be coal in your stocking this year)."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Closes-Bug: #1522536"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_ce1e506f","line":22,"range":{"start_line":22,"start_character":1,"end_line":22,"end_character":46},"in_reply_to":"dae33548_f8b79ed5","updated":"2016-02-17 23:32:13.000000000","message":"Heh.  Has absolutely nothing to do with Christianity, either :)","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"}],"nova/compute/api.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"e95f80c212b3b463279c4e2d9c74a238b7743986","unresolved":false,"context_lines":[{"line_number":1945,"context_line":"                               \u0027security_groups\u0027, \u0027info_cache\u0027])"},{"line_number":1946,"context_line":"        # NOTE(ameade): we still need to support integer ids for ec2"},{"line_number":1947,"context_line":"        try:"},{"line_number":1948,"context_line":"            if uuidutils.is_uuid_like(instance_id):"},{"line_number":1949,"context_line":"                LOG.debug(\"Fetching instance by UUID\","},{"line_number":1950,"context_line":"                           instance_uuid\u003dinstance_id)"},{"line_number":1951,"context_line":"                instance \u003d objects.Instance.get_by_uuid("},{"line_number":1952,"context_line":"                    context, instance_id, expected_attrs\u003dexpected_attrs)"},{"line_number":1953,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_49cd1930","line":1950,"range":{"start_line":1948,"start_character":0,"end_line":1950,"end_character":53},"updated":"2016-02-18 00:32:38.000000000","message":"In else should we make it BadRequest? otherwise if requested by id it will through NotFound.","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"990f60fdcaf7e0290fbafea68df00b5f92b6c9fc","unresolved":false,"context_lines":[{"line_number":1945,"context_line":"                               \u0027security_groups\u0027, \u0027info_cache\u0027])"},{"line_number":1946,"context_line":"        # NOTE(ameade): we still need to support integer ids for ec2"},{"line_number":1947,"context_line":"        try:"},{"line_number":1948,"context_line":"            if uuidutils.is_uuid_like(instance_id):"},{"line_number":1949,"context_line":"                LOG.debug(\"Fetching instance by UUID\","},{"line_number":1950,"context_line":"                           instance_uuid\u003dinstance_id)"},{"line_number":1951,"context_line":"                instance \u003d objects.Instance.get_by_uuid("},{"line_number":1952,"context_line":"                    context, instance_id, expected_attrs\u003dexpected_attrs)"},{"line_number":1953,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_8f28c134","line":1950,"range":{"start_line":1948,"start_character":0,"end_line":1950,"end_character":53},"in_reply_to":"dae33548_49cd1930","updated":"2016-02-18 01:28:57.000000000","message":"possibly would be better, however I was going for minimal change.","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d5bd5a605e8fc3898b75f6289dd3ea069021563","unresolved":false,"context_lines":[{"line_number":1945,"context_line":"                               \u0027security_groups\u0027, \u0027info_cache\u0027])"},{"line_number":1946,"context_line":"        # NOTE(ameade): we still need to support integer ids for ec2"},{"line_number":1947,"context_line":"        try:"},{"line_number":1948,"context_line":"            if uuidutils.is_uuid_like(instance_id):"},{"line_number":1949,"context_line":"                LOG.debug(\"Fetching instance by UUID\","},{"line_number":1950,"context_line":"                           instance_uuid\u003dinstance_id)"},{"line_number":1951,"context_line":"                instance \u003d objects.Instance.get_by_uuid("},{"line_number":1952,"context_line":"                    context, instance_id, expected_attrs\u003dexpected_attrs)"},{"line_number":1953,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_4f7fd9df","line":1950,"range":{"start_line":1948,"start_character":0,"end_line":1950,"end_character":53},"in_reply_to":"dae33548_8f28c134","updated":"2016-02-18 01:36:40.000000000","message":"+1. we can do in follow up too.","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"}],"nova/tests/unit/api/openstack/compute/test_neutron_security_groups.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"39990af8638af2dcc553734085fc6bc3ab9121c7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from nova.tests.unit.api.openstack import fakes"},{"line_number":38,"context_line":"from nova.tests import uuidsentinel as uuids"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"UUID_SERVER \u003d uuids.server.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class TestNeutronSecurityGroupsTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_a98e6676","line":40,"updated":"2016-02-17 23:37:29.000000000","message":"The change itself makes sense, but I don\u0027t understand these parts where \u0027-\u0027 has to be replaced by \u0027\u0027. I thought all the uuids for instances have the dashes in the api calls I\u0027ve observed?","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"87e2e78fffece88db07f2ac35464e4cdbf26a47a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from nova.tests.unit.api.openstack import fakes"},{"line_number":38,"context_line":"from nova.tests import uuidsentinel as uuids"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"UUID_SERVER \u003d uuids.server.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class TestNeutronSecurityGroupsTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_c90aca89","line":40,"in_reply_to":"dae33548_891562e6","updated":"2016-02-17 23:51:44.000000000","message":"Hm, okay. I hoped to avoid having something like this around to be confusing if it\u0027s not needed. But if everyone else thinks it makes sense, I\u0027m fine","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"aa6f5f6f4022cf4dba35a9310f326a2131a3382d","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from nova.tests.unit.api.openstack import fakes"},{"line_number":38,"context_line":"from nova.tests import uuidsentinel as uuids"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"UUID_SERVER \u003d uuids.server.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class TestNeutronSecurityGroupsTestCase(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_891562e6","line":40,"in_reply_to":"dae33548_a98e6676","updated":"2016-02-17 23:42:41.000000000","message":"When I was iterating through test fixes, there are times we use this value as returned from the db. I was tripping over an invalid id issue (though that might have been before I flipped all the stubs to _by_uuid).\n\nI\u0027m happy to remove those bits if it\u0027s working fine without them.","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"}],"nova/tests/unit/api/openstack/compute/test_security_groups.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"77d871e05ff973fac9b7dc5988005e4400e893d7","unresolved":false,"context_lines":[{"line_number":40,"context_line":"CONF \u003d cfg.CONF"},{"line_number":41,"context_line":"FAKE_UUID1 \u003d \u0027a47ae74e-ab08-447f-8eee-ffd43fc46c16\u0027"},{"line_number":42,"context_line":"FAKE_UUID2 \u003d \u0027c6e6430a-6563-4efa-9542-5e93c9e97d18\u0027"},{"line_number":43,"context_line":"UUID_SERVER \u003d uuids.server.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class AttrDict(dict):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_f3efc184","line":43,"updated":"2016-02-17 22:57:03.000000000","message":"Turns out it works whether you replace the - or not (I tried it).\n\nNot relevant for this change, but it would be nice if we could make it consistent throughout?","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"c21689c4258d888786b9892d7b924500c8a647ca","unresolved":false,"context_lines":[{"line_number":40,"context_line":"CONF \u003d cfg.CONF"},{"line_number":41,"context_line":"FAKE_UUID1 \u003d \u0027a47ae74e-ab08-447f-8eee-ffd43fc46c16\u0027"},{"line_number":42,"context_line":"FAKE_UUID2 \u003d \u0027c6e6430a-6563-4efa-9542-5e93c9e97d18\u0027"},{"line_number":43,"context_line":"UUID_SERVER \u003d uuids.server.replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class AttrDict(dict):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_0912f208","line":43,"in_reply_to":"dae33548_f3efc184","updated":"2016-02-17 23:40:58.000000000","message":"Ok, while iterating on this I thought I hit an issue where the return_server did not work because of - in it for the db layer.\n\nI can go either way if we think this is important enough to change.","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"1c57d624aa16dfadde95a678875037278c845d32","unresolved":false,"context_lines":[{"line_number":119,"context_line":""},{"line_number":120,"context_line":"def return_security_group_by_name(context, project_id, group_name):"},{"line_number":121,"context_line":"    return {\u0027id\u0027: 1, \u0027name\u0027: group_name,"},{"line_number":122,"context_line":"            \"instances\": [{\u0027id\u0027: 1, \u0027uuid\u0027: UUID_SERVER}]}"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"def return_security_group_without_instances(context, project_id, group_name):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dae33548_3355a9f9","line":122,"updated":"2016-02-17 22:40:48.000000000","message":"Why does FAKE_UUID1 have dashes and UUID_SERVER does not?","commit_id":"2569e3cf10c15d99d5f676523c81cf2bfc4b0841"}]}