)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"b117a6e95cfca507f2a047d306bac8b39da044e7","unresolved":false,"context_lines":[{"line_number":10,"context_line":"http://openqa.sed.hu/sourcemeter_duplications/load_duplications_page?data_key\u003dOpenStack:nova:nova/compute/manager.py"},{"line_number":11,"context_line":"in 159~CloneClass"},{"line_number":12,"context_line":"Also add unit test to the new method"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I41f12800082243118747417f01dab8063fc47742"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dae33548_a2c69865","line":13,"updated":"2016-02-17 15:48:12.000000000","message":"Please change the title to summarize what you change is, and which part of the code it applies to. \u0027Extract duplicate code from compute manager\u0027 might be a good title. Also please include a brief, more detailed summary of the change in the form of a couple sentences. I don\u0027t think the link you have here is necessary, but perhaps others will disagree with me.","commit_id":"3673a0a6c679f965331645749f3ad1b9f0b9cf5a"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"42382bb6872b6df73b0d8dcc2cfdd108df106e8c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"(nova/compute/manager.py)"},{"line_number":10,"context_line":"In the _do_build_and_run_instance method the exceptions are treated in"},{"line_number":11,"context_line":"the very similar way, when the _build_and_run_instance call fails. So"},{"line_number":12,"context_line":"i extracted these clean up calls into a new method. I did it based on"},{"line_number":13,"context_line":"the following link (159~CloneClass):"},{"line_number":14,"context_line":"http://openqa.sed.hu/sourcemeter_duplications/load_duplications_page?data_key\u003dOpenStack:nova:nova/compute/manager.py"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_ee8a0a1a","line":11,"updated":"2016-02-18 15:43:29.000000000","message":"the -\u003e a","commit_id":"eb9a3d698a042d3e4b9915ad3d172b9e48937c9c"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"42382bb6872b6df73b0d8dcc2cfdd108df106e8c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"(nova/compute/manager.py)"},{"line_number":10,"context_line":"In the _do_build_and_run_instance method the exceptions are treated in"},{"line_number":11,"context_line":"the very similar way, when the _build_and_run_instance call fails. So"},{"line_number":12,"context_line":"i extracted these clean up calls into a new method. I did it based on"},{"line_number":13,"context_line":"the following link (159~CloneClass):"},{"line_number":14,"context_line":"http://openqa.sed.hu/sourcemeter_duplications/load_duplications_page?data_key\u003dOpenStack:nova:nova/compute/manager.py"},{"line_number":15,"context_line":"I also added unit test to the new method"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dae33548_4e7a1625","line":12,"updated":"2016-02-18 15:43:29.000000000","message":"i -\u003e I","commit_id":"eb9a3d698a042d3e4b9915ad3d172b9e48937c9c"}],"nova/compute/manager.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"b117a6e95cfca507f2a047d306bac8b39da044e7","unresolved":false,"context_lines":[{"line_number":1881,"context_line":"            instance,"},{"line_number":1882,"context_line":"            requested_networks,"},{"line_number":1883,"context_line":"            e,"},{"line_number":1884,"context_line":"            block_device_mapping \u003d None):"},{"line_number":1885,"context_line":"        self._cleanup_allocated_networks(context, instance, requested_networks)"},{"line_number":1886,"context_line":"        if not (isinstance(e, exception.InstanceNotFound) or"},{"line_number":1887,"context_line":"                isinstance(e, exception.UnexpectedDeletingTaskStateError)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_27561ace","line":1884,"updated":"2016-02-17 15:48:12.000000000","message":"I suggest changing the indentation of this so that a few args are on each line. Also \u0027e\u0027 should be renamed to something more descriptive.","commit_id":"3673a0a6c679f965331645749f3ad1b9f0b9cf5a"},{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"b117a6e95cfca507f2a047d306bac8b39da044e7","unresolved":false,"context_lines":[{"line_number":1884,"context_line":"            block_device_mapping \u003d None):"},{"line_number":1885,"context_line":"        self._cleanup_allocated_networks(context, instance, requested_networks)"},{"line_number":1886,"context_line":"        if not (isinstance(e, exception.InstanceNotFound) or"},{"line_number":1887,"context_line":"                isinstance(e, exception.UnexpectedDeletingTaskStateError)):"},{"line_number":1888,"context_line":"            if isinstance(e, exception.RescheduledException):"},{"line_number":1889,"context_line":"                compute_utils.add_instance_fault_from_exc(context, instance,"},{"line_number":1890,"context_line":"                        e, sys.exc_info(), fault_message\u003de.kwargs[\u0027reason\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_47afde29","line":1887,"updated":"2016-02-17 15:48:12.000000000","message":"Is this logic redundant? Isn\u0027t an UnexpectedDeletingTaskStateError also not a InstanceNotFound error?","commit_id":"3673a0a6c679f965331645749f3ad1b9f0b9cf5a"}]}