)]}'
{"nova/objects/instance.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f09e88a3e5935345a181cf5116c962fea765a0c7","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               base.NovaObjectDictCompat):"},{"line_number":89,"context_line":"    # Version 2.0: Initial version"},{"line_number":90,"context_line":"    # Version 2.1: Added services"},{"line_number":91,"context_line":"    VERSION \u003d \u00272.1\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    fields \u003d {"},{"line_number":94,"context_line":"        \u0027id\u0027: fields.IntegerField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_653312ac","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":18},"updated":"2016-02-23 03:39:28.000000000","message":"The version should be increased because of \u0027clear_numa_topology\u0027 method is added.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"ddcd779df9eabf4d29514f31b00da876af38f305","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               base.NovaObjectDictCompat):"},{"line_number":89,"context_line":"    # Version 2.0: Initial version"},{"line_number":90,"context_line":"    # Version 2.1: Added services"},{"line_number":91,"context_line":"    VERSION \u003d \u00272.1\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    fields \u003d {"},{"line_number":94,"context_line":"        \u0027id\u0027: fields.IntegerField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_9bbca307","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":18},"in_reply_to":"bae84128_653312ac","updated":"2016-02-23 12:34:36.000000000","message":"But it\u0027s not a remotable method, so no need to change anything - pls remove the -1 as ppl don\u0027t normally look at reviews with -1s.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"98990efa508549efc2f24f9f1eed83291fc8862b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               base.NovaObjectDictCompat):"},{"line_number":89,"context_line":"    # Version 2.0: Initial version"},{"line_number":90,"context_line":"    # Version 2.1: Added services"},{"line_number":91,"context_line":"    VERSION \u003d \u00272.1\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    fields \u003d {"},{"line_number":94,"context_line":"        \u0027id\u0027: fields.IntegerField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_bee06b97","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":18},"in_reply_to":"bae84128_9bbca307","updated":"2016-02-23 15:45:05.000000000","message":"Correct, this is not a thing that needs a bump.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"efc73d619a4949d27c1489735f614d50da59284f","unresolved":false,"context_lines":[{"line_number":88,"context_line":"               base.NovaObjectDictCompat):"},{"line_number":89,"context_line":"    # Version 2.0: Initial version"},{"line_number":90,"context_line":"    # Version 2.1: Added services"},{"line_number":91,"context_line":"    VERSION \u003d \u00272.1\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    fields \u003d {"},{"line_number":94,"context_line":"        \u0027id\u0027: fields.IntegerField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_450335b8","line":91,"range":{"start_line":91,"start_character":3,"end_line":91,"end_character":18},"in_reply_to":"bae84128_bee06b97","updated":"2016-02-24 00:26:58.000000000","message":"I understand it.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"adf6311a9bbc569b04b1753ca5b3bfc6d9f475b7","unresolved":false,"context_lines":[{"line_number":865,"context_line":""},{"line_number":866,"context_line":"    def clear_numa_topology(self):"},{"line_number":867,"context_line":"        numa_topology \u003d self.numa_topology"},{"line_number":868,"context_line":"        if numa_topology is not None:"},{"line_number":869,"context_line":"            self.numa_topology \u003d numa_topology.clear_host_pinning()"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"    def obj_load_attr(self, attrname):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_1065001d","line":868,"updated":"2016-02-17 20:39:32.000000000","message":"Nit: Why not combined those two lines and do \"if self.numa_topology is not None:\" ?","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"98990efa508549efc2f24f9f1eed83291fc8862b","unresolved":false,"context_lines":[{"line_number":865,"context_line":""},{"line_number":866,"context_line":"    def clear_numa_topology(self):"},{"line_number":867,"context_line":"        numa_topology \u003d self.numa_topology"},{"line_number":868,"context_line":"        if numa_topology is not None:"},{"line_number":869,"context_line":"            self.numa_topology \u003d numa_topology.clear_host_pinning()"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":"    def obj_load_attr(self, attrname):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_9e8be7c2","line":868,"in_reply_to":"dae33548_1065001d","updated":"2016-02-23 15:45:05.000000000","message":"Because of line wrapping on 870","commit_id":"16b66221162db67097679bf034406fff996b0d76"}],"nova/objects/instance_numa_topology.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f09e88a3e5935345a181cf5116c962fea765a0c7","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # Version 1.1: Add pagesize field"},{"line_number":31,"context_line":"    # Version 1.2: Add cpu_pinning_raw and topology fields"},{"line_number":32,"context_line":"    # Version 1.3: Add cpu_policy and cpu_thread_policy fields"},{"line_number":33,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":36,"context_line":"        super(InstanceNUMACell, self).obj_make_compatible(primitive,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_65daf24d","line":33,"range":{"start_line":33,"start_character":3,"end_line":33,"end_character":18},"updated":"2016-02-23 03:39:28.000000000","message":"ditto","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"98990efa508549efc2f24f9f1eed83291fc8862b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # Version 1.1: Add pagesize field"},{"line_number":31,"context_line":"    # Version 1.2: Add cpu_pinning_raw and topology fields"},{"line_number":32,"context_line":"    # Version 1.3: Add cpu_policy and cpu_thread_policy fields"},{"line_number":33,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":36,"context_line":"        super(InstanceNUMACell, self).obj_make_compatible(primitive,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_9e0e4739","line":33,"range":{"start_line":33,"start_character":3,"end_line":33,"end_character":18},"in_reply_to":"bae84128_5b4dfb3c","updated":"2016-02-23 15:45:05.000000000","message":"Also not a bumpable thing.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"ddcd779df9eabf4d29514f31b00da876af38f305","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    # Version 1.1: Add pagesize field"},{"line_number":31,"context_line":"    # Version 1.2: Add cpu_pinning_raw and topology fields"},{"line_number":32,"context_line":"    # Version 1.3: Add cpu_policy and cpu_thread_policy fields"},{"line_number":33,"context_line":"    VERSION \u003d \u00271.3\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def obj_make_compatible(self, primitive, target_version):"},{"line_number":36,"context_line":"        super(InstanceNUMACell, self).obj_make_compatible(primitive,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_5b4dfb3c","line":33,"range":{"start_line":33,"start_character":3,"end_line":33,"end_character":18},"in_reply_to":"bae84128_65daf24d","updated":"2016-02-23 12:34:36.000000000","message":"Nope - see other comment","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"98990efa508549efc2f24f9f1eed83291fc8862b","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        self.id \u003d cell_id"},{"line_number":132,"context_line":"        self.cpu_pinning \u003d {}"},{"line_number":133,"context_line":"        return self"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# TODO(berrange): Remove NovaObjectDictCompat"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_c1b91217","line":133,"updated":"2016-02-23 15:45:05.000000000","message":"I\u0027m not sure why this takes a cell_id, especially since we just reset it to N for N in cells.\n\nIs this set to N at boot, then set to some real value as part of the allocation of a cell, and then we need to reset it or something? Like, I\u0027m not sure why these aren\u0027t all zero or something.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"bc04ad2f2ecd84b01733b4962339a43e26630d0a","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        self.id \u003d cell_id"},{"line_number":132,"context_line":"        self.cpu_pinning \u003d {}"},{"line_number":133,"context_line":"        return self"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"# TODO(berrange): Remove NovaObjectDictCompat"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_cb8d7a32","line":133,"in_reply_to":"bae84128_c1b91217","updated":"2016-02-24 12:10:59.000000000","message":"Actually it might be best to set them all to -1 as 0 is actually a valid value.\n\nThat would work but would be inconsistent with how boot initializes it before a claim, and I worry that changing how boot does it potentially requires a data migration (but I don\u0027t think we care about this enough).\n\nLet me try this.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"f09e88a3e5935345a181cf5116c962fea765a0c7","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    # Version 1.0: Initial version"},{"line_number":141,"context_line":"    # Version 1.1: Takes into account pagesize"},{"line_number":142,"context_line":"    # Version 1.2: InstanceNUMACell 1.2"},{"line_number":143,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    fields \u003d {"},{"line_number":146,"context_line":"        # NOTE(danms): The \u0027id\u0027 field is no longer used and should be"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_c5b2de05","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":19},"updated":"2016-02-23 03:39:28.000000000","message":"ditto","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"98990efa508549efc2f24f9f1eed83291fc8862b","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    # Version 1.0: Initial version"},{"line_number":141,"context_line":"    # Version 1.1: Takes into account pagesize"},{"line_number":142,"context_line":"    # Version 1.2: InstanceNUMACell 1.2"},{"line_number":143,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    fields \u003d {"},{"line_number":146,"context_line":"        # NOTE(danms): The \u0027id\u0027 field is no longer used and should be"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_de044f19","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":19},"in_reply_to":"bae84128_bb6407b9","updated":"2016-02-23 15:45:05.000000000","message":"this too.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"ddcd779df9eabf4d29514f31b00da876af38f305","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    # Version 1.0: Initial version"},{"line_number":141,"context_line":"    # Version 1.1: Takes into account pagesize"},{"line_number":142,"context_line":"    # Version 1.2: InstanceNUMACell 1.2"},{"line_number":143,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    fields \u003d {"},{"line_number":146,"context_line":"        # NOTE(danms): The \u0027id\u0027 field is no longer used and should be"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_bb6407b9","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":19},"in_reply_to":"bae84128_c5b2de05","updated":"2016-02-23 12:34:36.000000000","message":"again - no need to bump anything.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"efc73d619a4949d27c1489735f614d50da59284f","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    # Version 1.0: Initial version"},{"line_number":141,"context_line":"    # Version 1.1: Takes into account pagesize"},{"line_number":142,"context_line":"    # Version 1.2: InstanceNUMACell 1.2"},{"line_number":143,"context_line":"    VERSION \u003d \u00271.2\u0027"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    fields \u003d {"},{"line_number":146,"context_line":"        # NOTE(danms): The \u0027id\u0027 field is no longer used and should be"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_a5116106","line":143,"range":{"start_line":143,"start_character":4,"end_line":143,"end_character":19},"in_reply_to":"bae84128_de044f19","updated":"2016-02-24 00:26:58.000000000","message":"I understand it.","commit_id":"16b66221162db67097679bf034406fff996b0d76"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0527c2a2cbde88942810500d6e2e4935d1d816a9","unresolved":false,"context_lines":[{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        Needed for aborting claims as we do not want to keep stale data around."},{"line_number":130,"context_line":"        \"\"\""},{"line_number":131,"context_line":"        self.id \u003d -1"},{"line_number":132,"context_line":"        self.cpu_pinning \u003d {}"},{"line_number":133,"context_line":"        return self"},{"line_number":134,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_f2eba476","line":131,"updated":"2016-02-26 19:32:25.000000000","message":"I like this better, thanks. I dunno why, but.. I do.","commit_id":"521decbe9f79e337fb14571367c6008969a7133a"}]}