)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":5174,"name":"Mauro Sergio Martins Rodrigues","email":"maurosr@linux.vnet.ibm.com","username":"maurosr"},"change_message_id":"0af3f588e13cae60b1cef0bbd416e531f51e6b4c","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                                      max_length\u003dmax_length)"},{"line_number":583,"context_line":"        except exception.InvalidInput as e:"},{"line_number":584,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dstr(e))"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    def _validate_server_name(self, value):"},{"line_number":587,"context_line":"        self._check_string_length(value, \u0027Server name\u0027, max_length\u003d255)"},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fj6Y%3D","line":585,"updated":"2013-05-03 20:01:07.000000000","message":"can move the strip of trailing white space of name to here instead of keep it inside servers create and update?","commit_id":"be8d5450fa4f86de17c44beb898d9ff7d7529830"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"84d7ca2f096335e288a64573c1f8bbd6301d7ba1","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                                      max_length\u003dmax_length)"},{"line_number":583,"context_line":"        except exception.InvalidInput as e:"},{"line_number":584,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dstr(e))"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"    def _validate_server_name(self, value):"},{"line_number":587,"context_line":"        self._check_string_length(value, \u0027Server name\u0027, max_length\u003d255)"},{"line_number":588,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fjvc%3D","line":585,"in_reply_to":"AAAAOn%2F%2Fj6Y%3D","updated":"2013-05-03 21:59:02.000000000","message":"Good call, agree.","commit_id":"be8d5450fa4f86de17c44beb898d9ff7d7529830"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"f2b799091610f2a59cb618cf73cc6b17fc775610","unresolved":false,"context_lines":[{"line_number":758,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        name \u003d server_dict[\u0027name\u0027]"},{"line_number":761,"context_line":"        if isinstance(name, basestring):"},{"line_number":762,"context_line":"            name \u003d name.strip()"},{"line_number":763,"context_line":"        self._validate_server_name(name)"},{"line_number":764,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fj10%3D","line":761,"updated":"2013-05-03 20:59:29.000000000","message":"Is there any valid situation where name would not be a string?  This seems like an error case that should be handled, or you could just duck type name to a string.","commit_id":"be8d5450fa4f86de17c44beb898d9ff7d7529830"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"84d7ca2f096335e288a64573c1f8bbd6301d7ba1","unresolved":false,"context_lines":[{"line_number":758,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        name \u003d server_dict[\u0027name\u0027]"},{"line_number":761,"context_line":"        if isinstance(name, basestring):"},{"line_number":762,"context_line":"            name \u003d name.strip()"},{"line_number":763,"context_line":"        self._validate_server_name(name)"},{"line_number":764,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fjvg%3D","line":761,"in_reply_to":"AAAAOn%2F%2Fj10%3D","updated":"2013-05-03 21:59:02.000000000","message":"This is the Right Thing to do. In python 2, basestring includes str and unicode.","commit_id":"be8d5450fa4f86de17c44beb898d9ff7d7529830"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"874bcbaa439e8af754f58af8e3dc0f8ba1964abe","unresolved":false,"context_lines":[{"line_number":758,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":"        name \u003d server_dict[\u0027name\u0027]"},{"line_number":761,"context_line":"        if isinstance(name, basestring):"},{"line_number":762,"context_line":"            name \u003d name.strip()"},{"line_number":763,"context_line":"        self._validate_server_name(name)"},{"line_number":764,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FjuM%3D","line":761,"in_reply_to":"AAAAOn%2F%2Fjvg%3D","updated":"2013-05-03 22:20:01.000000000","message":"Right, my concern was that we weren\u0027t handling the negative case.  But I see now that _validate_server_name will throw the exception for us if someone passes in a non-basestring, so I retract my -1. :-)","commit_id":"be8d5450fa4f86de17c44beb898d9ff7d7529830"}],"nova/tests/api/openstack/compute/test_servers.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0fbfd0a7783d4c79653c996bd18947e13437914f","unresolved":false,"context_lines":[{"line_number":1102,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/servers/%s\u0027 % FAKE_UUID)"},{"line_number":1103,"context_line":"        req.method \u003d \u0027PUT\u0027"},{"line_number":1104,"context_line":"        req.content_type \u003d \u0027application/json\u0027"},{"line_number":1105,"context_line":"        body \u003d {\u0027server\u0027: {\u0027name\u0027: \u0027 \u0027 * 64}}"},{"line_number":1106,"context_line":"        req.body \u003d jsonutils.dumps(body)"},{"line_number":1107,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest, self.controller.update,"},{"line_number":1108,"context_line":"                          req, FAKE_UUID, body)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FkJk%3D","line":1105,"updated":"2013-05-03 17:30:06.000000000","message":"Is there any reason for making this 64 spaces instead of just one?","commit_id":"6b4d2e2748b8eb821a4ee39120747aa6d7822092"}]}