)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"067a096d0230135bbe8f396e2c89c10315c9e69d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"options, the improved help text will be split into several patches; this"},{"line_number":13,"context_line":"is patch 3 of 4."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Blueprint centralize-config-options"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Iec4edc688d74b0ecdfd7ee8a0a1ad9b5ea153ed0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_cf32e10f","line":15,"updated":"2016-03-23 15:50:02.000000000","message":"Please be aware that the effort in Newton is tracked with a\nnew (follow up) blueprint \n\n    centralize-config-options-newton\n\nIf questions arise, ping me. Thanks for your help here!","commit_id":"9bea4f7d5cbb7c3661c0886fbd8d7fbf1cc3d9a2"}],"nova/conf/network.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2b43c4aa6a9d5a30b50a523321e4a9dfccd92e4b","unresolved":false,"context_lines":[{"line_number":303,"context_line":"            default\u003d0,"},{"line_number":304,"context_line":"            help\u003d\"\"\""},{"line_number":305,"context_line":"This option represents the number of IP addresses to reserve at the top of the"},{"line_number":306,"context_line":"address range for VPN clients."},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"Possible values:"},{"line_number":309,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_c600ca04","line":306,"updated":"2016-04-01 10:39:44.000000000","message":"Is this when calling nova-manage network create and you have VLAN manager enabled?","commit_id":"cb24081de46513d53664077cd5ec814cd79f42e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2b43c4aa6a9d5a30b50a523321e4a9dfccd92e4b","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            help\u003d\"\"\""},{"line_number":341,"context_line":"This option determines how many times nova-network will attempt to create a"},{"line_number":342,"context_line":"unique MAC address before giving up and raising a"},{"line_number":343,"context_line":"`VirtualInterfaceMacAddressException` error."},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"Possible values:"},{"line_number":346,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_6611fe5c","line":343,"updated":"2016-04-01 10:39:44.000000000","message":"I guess this is during the boot process?","commit_id":"cb24081de46513d53664077cd5ec814cd79f42e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2b43c4aa6a9d5a30b50a523321e4a9dfccd92e4b","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    cfg.BoolOpt(\"fake_call\","},{"line_number":358,"context_line":"            default\u003dFalse,"},{"line_number":359,"context_line":"            help\u003d\"\"\""},{"line_number":360,"context_line":"When this option is True, calls are made locally instead of being placed in the"},{"line_number":361,"context_line":"queue. However, all usage of this config option have been removed, so it"},{"line_number":362,"context_line":"currently has no effect at all."},{"line_number":363,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_e11cd86b","line":360,"updated":"2016-04-01 10:39:44.000000000","message":"Maybe lets just say \"config option unused\" and mark it as deprecated?","commit_id":"cb24081de46513d53664077cd5ec814cd79f42e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2b43c4aa6a9d5a30b50a523321e4a9dfccd92e4b","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"* Related options:"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    vpn_ip, fake_network"},{"line_number":393,"context_line":"\"\"\"),"},{"line_number":394,"context_line":"    cfg.BoolOpt(\"force_dhcp_release\","},{"line_number":395,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_0188ec6f","line":392,"range":{"start_line":392,"start_character":4,"end_line":392,"end_character":10},"updated":"2016-04-01 10:39:44.000000000","message":"can we say how its related to this options in the description, like \"this is ignored when fake_network\u003dTrue\" or something like that.","commit_id":"cb24081de46513d53664077cd5ec814cd79f42e0"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"2b43c4aa6a9d5a30b50a523321e4a9dfccd92e4b","unresolved":false,"context_lines":[{"line_number":389,"context_line":""},{"line_number":390,"context_line":"* Related options:"},{"line_number":391,"context_line":""},{"line_number":392,"context_line":"    vpn_ip, fake_network"},{"line_number":393,"context_line":"\"\"\"),"},{"line_number":394,"context_line":"    cfg.BoolOpt(\"force_dhcp_release\","},{"line_number":395,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba0121b8_e13338f4","line":392,"updated":"2016-04-01 10:39:44.000000000","message":"isn\u0027t this also related to using VLAN manager, is_neutron\u003dfalse and maybe multi_host\u003dTrue?","commit_id":"cb24081de46513d53664077cd5ec814cd79f42e0"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"604cfcf9105a0050c504b8396d056d85fb0e161f","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Possible values:"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Any integer, 0 or greater. The default is 0."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Related options:"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_6dd14a57","line":259,"updated":"2016-06-29 15:35:10.000000000","message":"Since the min value is zero, there should be a \"min\u003d0\" flag added to IntOpt","commit_id":"f39ed87e31cf40594b790695b3c39c58457abe23"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d1bf8a51e410f2d80b26403cf1e2f16f5ba9a93b","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Possible values:"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Any integer, 0 or greater. The default is 0."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Related options:"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_b746d878","line":259,"in_reply_to":"3aaa91ec_48e39cd9","updated":"2016-06-29 17:10:09.000000000","message":"OK, I added a follow-up patch with that addition: https://review.openstack.org/335585","commit_id":"f39ed87e31cf40594b790695b3c39c58457abe23"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d10d8b13468caf7c5646c6b1f1f00e26c7c84f2f","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"Possible values:"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    Any integer, 0 or greater. The default is 0."},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"* Related options:"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_48e39cd9","line":259,"in_reply_to":"3aaa91ec_6dd14a57","updated":"2016-06-29 16:08:36.000000000","message":"That is really not in scope for this patch, which is focused on improving the help text for the options. Perhaps it could be added as a follow-up patch.","commit_id":"f39ed87e31cf40594b790695b3c39c58457abe23"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"604cfcf9105a0050c504b8396d056d85fb0e161f","unresolved":false,"context_lines":[{"line_number":270,"context_line":""},{"line_number":271,"context_line":"Possible values:"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    Any integer, zero or greater. The default is 600 (10 minutes)."},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"* Related options:"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_8dcc76bc","line":273,"updated":"2016-06-29 15:35:10.000000000","message":"same","commit_id":"f39ed87e31cf40594b790695b3c39c58457abe23"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"604cfcf9105a0050c504b8396d056d85fb0e161f","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"Possible values:"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    Any positive integer. The default is 5."},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"* Related options:"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_edc53a8e","line":288,"updated":"2016-06-29 15:35:10.000000000","message":"same","commit_id":"f39ed87e31cf40594b790695b3c39c58457abe23"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"604cfcf9105a0050c504b8396d056d85fb0e161f","unresolved":false,"context_lines":[{"line_number":298,"context_line":"queue. However, all usage of this config option have been removed, so it"},{"line_number":299,"context_line":"currently has no effect at all."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"Possible values:"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    True, False (default)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"* Related options:"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_6d5f8ae5","line":303,"range":{"start_line":301,"start_character":0,"end_line":303,"end_character":25},"updated":"2016-06-29 15:35:10.000000000","message":"This is redundant, and should be removed.\n\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency explains that boolean settings should not have this section, unless True and False need describing.","commit_id":"f39ed87e31cf40594b790695b3c39c58457abe23"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"d10d8b13468caf7c5646c6b1f1f00e26c7c84f2f","unresolved":false,"context_lines":[{"line_number":298,"context_line":"queue. However, all usage of this config option have been removed, so it"},{"line_number":299,"context_line":"currently has no effect at all."},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"Possible values:"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    True, False (default)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"* Related options:"},{"line_number":306,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_c8f66c8e","line":303,"range":{"start_line":301,"start_character":0,"end_line":303,"end_character":25},"in_reply_to":"3aaa91ec_6d5f8ae5","updated":"2016-06-29 16:08:36.000000000","message":"True, this was the standard style 5 months ago at the time that this work was done, but it has since changed. I will update.","commit_id":"f39ed87e31cf40594b790695b3c39c58457abe23"},{"author":{"_account_id":7012,"name":"Brianna Poulos","email":"Brianna.Poulos@jhuapl.edu","username":"brianna-poulos"},"change_message_id":"604cfcf9105a0050c504b8396d056d85fb0e161f","unresolved":false,"context_lines":[{"line_number":314,"context_line":""},{"line_number":315,"context_line":"Possible values:"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"    True, False (default)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"* Related options:"},{"line_number":320,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3aaa91ec_ed737a7e","line":317,"updated":"2016-06-29 15:35:10.000000000","message":"same","commit_id":"f39ed87e31cf40594b790695b3c39c58457abe23"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"194d644387c8a413b63680136c5231853fb2b455","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            default\u003d0,"},{"line_number":256,"context_line":"            help\u003d\"\"\""},{"line_number":257,"context_line":"This option represents the number of IP addresses to reserve at the top of the"},{"line_number":258,"context_line":"address range for VPN clients."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Possible values:"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_ad5cfded","line":258,"updated":"2016-07-05 12:59:40.000000000","message":"I think its worth noting this is only used when creating networks for nova-networks VLAN manager.","commit_id":"b47e7880860ab8983256dc852d4b8d9b135e899f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b3d033f8c3601e6f48b6093d80f88958dd1bedfa","unresolved":false,"context_lines":[{"line_number":255,"context_line":"            default\u003d0,"},{"line_number":256,"context_line":"            help\u003d\"\"\""},{"line_number":257,"context_line":"This option represents the number of IP addresses to reserve at the top of the"},{"line_number":258,"context_line":"address range for VPN clients."},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"Possible values:"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_baff0466","line":258,"in_reply_to":"1aa78d24_ad5cfded","updated":"2016-07-05 16:05:57.000000000","message":"Done","commit_id":"b47e7880860ab8983256dc852d4b8d9b135e899f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"194d644387c8a413b63680136c5231853fb2b455","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            default\u003d600,"},{"line_number":270,"context_line":"            help\u003d\"\"\""},{"line_number":271,"context_line":"This is the number of seconds to wait before disassociating a deallocated fixed"},{"line_number":272,"context_line":"IP address."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Possible values:"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_cd106904","line":272,"updated":"2016-07-05 12:59:40.000000000","message":"Can we add a note saying this is only used with nova-network? I know you have the related option, but you haven\u0027t described the relationiship","commit_id":"b47e7880860ab8983256dc852d4b8d9b135e899f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b3d033f8c3601e6f48b6093d80f88958dd1bedfa","unresolved":false,"context_lines":[{"line_number":269,"context_line":"            default\u003d600,"},{"line_number":270,"context_line":"            help\u003d\"\"\""},{"line_number":271,"context_line":"This is the number of seconds to wait before disassociating a deallocated fixed"},{"line_number":272,"context_line":"IP address."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"Possible values:"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_9a02086e","line":272,"in_reply_to":"1aa78d24_cd106904","updated":"2016-07-05 16:05:57.000000000","message":"Done","commit_id":"b47e7880860ab8983256dc852d4b8d9b135e899f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"194d644387c8a413b63680136c5231853fb2b455","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            help\u003d\"\"\""},{"line_number":300,"context_line":"When this option is True, calls are made locally instead of being placed in the"},{"line_number":301,"context_line":"queue. However, all usage of this config option have been removed, so it"},{"line_number":302,"context_line":"currently has no effect at all."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"* Related options:"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_0d227152","line":302,"updated":"2016-07-05 12:59:40.000000000","message":"I guess we deprecate this in a later patcheset.","commit_id":"b47e7880860ab8983256dc852d4b8d9b135e899f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b3d033f8c3601e6f48b6093d80f88958dd1bedfa","unresolved":false,"context_lines":[{"line_number":299,"context_line":"            help\u003d\"\"\""},{"line_number":300,"context_line":"When this option is True, calls are made locally instead of being placed in the"},{"line_number":301,"context_line":"queue. However, all usage of this config option have been removed, so it"},{"line_number":302,"context_line":"currently has no effect at all."},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"* Related options:"},{"line_number":305,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_3a22f400","line":302,"in_reply_to":"1aa78d24_0d227152","updated":"2016-07-05 16:05:57.000000000","message":"Yes, as it was felt that it\u0027s easier to review these \"re-shuffling\" patches if we aren\u0027t also making other changes.","commit_id":"b47e7880860ab8983256dc852d4b8d9b135e899f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"194d644387c8a413b63680136c5231853fb2b455","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            default\u003dFalse,"},{"line_number":310,"context_line":"            help\u003d\"\"\""},{"line_number":311,"context_line":"Determines whether unused gateway devices, both VLAN and bridge, are deleted if"},{"line_number":312,"context_line":"the network is in VLAN mode and is multi-hosted."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"* Related options:"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_8dbb01e5","line":312,"range":{"start_line":312,"start_character":18,"end_line":312,"end_character":22},"updated":"2016-07-05 12:59:40.000000000","message":"maybe nova-network VLAN mode?","commit_id":"b47e7880860ab8983256dc852d4b8d9b135e899f"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b3d033f8c3601e6f48b6093d80f88958dd1bedfa","unresolved":false,"context_lines":[{"line_number":309,"context_line":"            default\u003dFalse,"},{"line_number":310,"context_line":"            help\u003d\"\"\""},{"line_number":311,"context_line":"Determines whether unused gateway devices, both VLAN and bridge, are deleted if"},{"line_number":312,"context_line":"the network is in VLAN mode and is multi-hosted."},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"* Related options:"},{"line_number":315,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1aa78d24_da693027","line":312,"range":{"start_line":312,"start_character":18,"end_line":312,"end_character":22},"in_reply_to":"1aa78d24_8dbb01e5","updated":"2016-07-05 16:05:57.000000000","message":"Done","commit_id":"b47e7880860ab8983256dc852d4b8d9b135e899f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a9931a01d3e7774e844cd1c9764271a469fe3ce7","unresolved":false,"context_lines":[{"line_number":260,"context_line":"This option represents the number of IP addresses to reserve at the top of the"},{"line_number":261,"context_line":"address range for VPN clients. It also will be ignored if the configuration"},{"line_number":262,"context_line":"option for `network_manager` is not set to the default of"},{"line_number":263,"context_line":"\u0027nova.network.manager.VlanManager\u0027."},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"Possible values:"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_62a82e8e","line":263,"updated":"2016-07-06 10:08:27.000000000","message":"Nit: I would rather we said its only used when calling nova-manage create-network","commit_id":"faf54e6a13b60808c2c7c44aef82c912124c46fe"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a9931a01d3e7774e844cd1c9764271a469fe3ce7","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    Any integer, 0 or greater. The default is 0."},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"* Related options:"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":"    ``use_neutron``, ``network_manager``"},{"line_number":272,"context_line":"\"\"\"),"}],"source_content_type":"text/x-python","patch_set":9,"id":"1aa78d24_42753230","line":269,"updated":"2016-07-06 10:08:27.000000000","message":"So we should be consistent here, no * should be added here:\nhttps://wiki.openstack.org/wiki/ConfigOptionsConsistency","commit_id":"faf54e6a13b60808c2c7c44aef82c912124c46fe"}]}