)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"e80458b6a4a07c74094c03356d0cd559c6015911","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The single option in nova.rpc is moved to the central place."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: bp centralize-config-options"},{"line_number":12,"context_line":"Change-Id: Ib6030c67b315a3b8d0d4854b4b6f1b969be6c00c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fa0719c6_0f97b93a","line":11,"updated":"2016-03-23 15:46:22.000000000","message":"Please be aware that the effort in Newton is tracked with a\nnew (follow up) blueprint \n\n    centralize-config-options-newton\n\nIf questions arise, ping me. Thanks for your help here!","commit_id":"9fa54a516dc89b7caf9dc20dc52cc041029a7ddb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b8fb0af68d4d8a3d0b701c73908ce05ee7a5b6b0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The single option in nova.rpc is moved to the central place."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: bp centralize-config-options"},{"line_number":12,"context_line":"Change-Id: Ib6030c67b315a3b8d0d4854b4b6f1b969be6c00c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_349a5415","line":11,"in_reply_to":"fa0719c6_0f97b93a","updated":"2016-03-29 08:28:51.000000000","message":"Done","commit_id":"9fa54a516dc89b7caf9dc20dc52cc041029a7ddb"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"0ad56a8100e43064ded0f1889481de60a467d979","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"config options: Centralize \u0027nova.rpc\u0027 options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The single option in nova.rpc is moved to the central place."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: bp centralize-config-options-newton"},{"line_number":12,"context_line":"Change-Id: Ib6030c67b315a3b8d0d4854b4b6f1b969be6c00c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a061dce_c0dc141b","line":9,"updated":"2016-04-04 09:11:14.000000000","message":"1) It seems that this options was never part of the sample config file generation. Otherwise it should be listed at [1]. This patch solves then an (unreported) bug. Please add this info here in the commit message. \n\n2) It also looks like you did the move and help text enhancement in one change. For this one single option it\u0027s fine IMO, but please mention it in the commit message, otherwise people could assume that there is a follow up patch which enhances the help text, because that\u0027s the pattern we use in the other changes (patch 1: move; patch 2: enhance help text).\n\n[1] http://docs.openstack.org/developer/nova/sample_config.html","commit_id":"a6d8192fc3eb789f238856fb9c38ffb8b3486056"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"90a0d480cac0f10e257ef8dbe68b1d082b0c9f8b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"config options: Centralize \u0027nova.rpc\u0027 options"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The single option in nova.rpc is moved to the central place."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Implements: bp centralize-config-options-newton"},{"line_number":12,"context_line":"Change-Id: Ib6030c67b315a3b8d0d4854b4b6f1b969be6c00c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a061dce_f4a0f1a7","line":9,"in_reply_to":"9a061dce_c0dc141b","updated":"2016-04-04 11:46:51.000000000","message":"1) Done. Reported a bug :)\n2) Done.","commit_id":"a6d8192fc3eb789f238856fb9c38ffb8b3486056"}],"nova/conf/rpc.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"0ad56a8100e43064ded0f1889481de60a467d979","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    help\u003d\"\"\"Specifies which notification format shall be used by nova."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Possible values:"},{"line_number":24,"context_line":"* unversioned: Only the legacy unversioned notifications are emitted."},{"line_number":25,"context_line":"* versioned: Only the new versioned notifications are emitted."},{"line_number":26,"context_line":"* both: Both the legacy unversioned and the new versioned notifications are"},{"line_number":27,"context_line":"  emitted. (Default)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Services which consume this:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_8b1d1d69","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":20},"updated":"2016-04-04 09:11:14.000000000","message":"1) Could you please add some words which explain how to determine which choice to use? For example, when should I used \"unversioned\" notifications? When I run an OpenStack cloud from Kilo|Liberty|Mitaka release? \n\n2) I also would assume that we finally want to have versioned notification only. Is this an option we possibly deprecate in one of the future releases?\n\n3) Is this maybe also an \"advanced option\"? Which means a configuration deployers and ops rarely have to change? Some feedback from the ops was that they like to know which category a config options falls into (\"required\", \"normal\", \"advanced\").","commit_id":"a6d8192fc3eb789f238856fb9c38ffb8b3486056"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"9320721d687f28ca332dc2b18fb76ca8004a8d60","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    help\u003d\"\"\"Specifies which notification format shall be used by nova."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Possible values:"},{"line_number":24,"context_line":"* unversioned: Only the legacy unversioned notifications are emitted."},{"line_number":25,"context_line":"* versioned: Only the new versioned notifications are emitted."},{"line_number":26,"context_line":"* both: Both the legacy unversioned and the new versioned notifications are"},{"line_number":27,"context_line":"  emitted. (Default)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Services which consume this:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_bbd34ad4","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":20},"in_reply_to":"9a061dce_4fff8834","updated":"2016-04-07 11:22:01.000000000","message":"Done in a follow up patch https://review.openstack.org/#/c/302678/","commit_id":"a6d8192fc3eb789f238856fb9c38ffb8b3486056"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"111f89590932ce3e28c48bff2f813347ec1d2dbf","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    help\u003d\"\"\"Specifies which notification format shall be used by nova."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Possible values:"},{"line_number":24,"context_line":"* unversioned: Only the legacy unversioned notifications are emitted."},{"line_number":25,"context_line":"* versioned: Only the new versioned notifications are emitted."},{"line_number":26,"context_line":"* both: Both the legacy unversioned and the new versioned notifications are"},{"line_number":27,"context_line":"  emitted. (Default)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Services which consume this:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_4fff8834","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":20},"in_reply_to":"9a061dce_79905aed","updated":"2016-04-04 12:12:49.000000000","message":"3) That information is valuable as it gives the ops a hint what the direction here is. Just add it after the first line. Maybe:\n\n    Specifies which notification format shall be used by nova.\n\n    The default value is good for most deployments. The \n    default value is rarely need to be changed. As soon \n    as we will be closer to feature parity more and more\n    deployers can set it to \u0027versioned\u0027 as the whole\n    infrastructure moves towards consuming the new\n    notifications. After that, the choice \"unversioned\"\n    doesn\u0027t make sense anymore and this option will be\n    removed (possibly in the \"P\" release).\n\n    Possible values:\n    * unversioned: DEPRECATED: Only the legacy ...\n    [...]\n\nSomething like that. I only rephrased your answer to me a little.","commit_id":"a6d8192fc3eb789f238856fb9c38ffb8b3486056"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"90a0d480cac0f10e257ef8dbe68b1d082b0c9f8b","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    help\u003d\"\"\"Specifies which notification format shall be used by nova."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Possible values:"},{"line_number":24,"context_line":"* unversioned: Only the legacy unversioned notifications are emitted."},{"line_number":25,"context_line":"* versioned: Only the new versioned notifications are emitted."},{"line_number":26,"context_line":"* both: Both the legacy unversioned and the new versioned notifications are"},{"line_number":27,"context_line":"  emitted. (Default)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Services which consume this:"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a061dce_79905aed","line":27,"range":{"start_line":24,"start_character":0,"end_line":27,"end_character":20},"in_reply_to":"9a061dce_8b1d1d69","updated":"2016-04-04 11:46:51.000000000","message":"1) Done\n2) Done\n3) The default value is good for most deployments so it is definitely not a \u0027required\u0027 option. It is advanced in a sense that today default value is rarely need to be changed. As soon as we will be closer to feature parity more and more deployers can set it to \u0027versioned\u0027 as the whole infrastructure moves towards consuming the new notifications. \nShall I write this in the doc or is it too much information?","commit_id":"a6d8192fc3eb789f238856fb9c38ffb8b3486056"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ec567e6bddf55ac63f8dc9580235cd447ccb8390","unresolved":false,"context_lines":[{"line_number":24,"context_line":"* unversioned: Only the legacy unversioned notifications are emitted."},{"line_number":25,"context_line":"* versioned: Only the new versioned notifications are emitted."},{"line_number":26,"context_line":"* both: Both the legacy unversioned and the new versioned notifications are"},{"line_number":27,"context_line":"  emitted. (Default)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently there is no feature parity between unversioned and versioned"},{"line_number":30,"context_line":"notifications. If the deployment needs the full range of legacy notifications"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_22a958e0","line":27,"updated":"2016-04-05 09:45:56.000000000","message":"I think one of the above is actually deprecated.","commit_id":"f8506618356816c3a01dff5dd99ba7c8a48f483c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a7effb8859097fb39413d2f8dfde8728eb040937","unresolved":false,"context_lines":[{"line_number":24,"context_line":"* unversioned: Only the legacy unversioned notifications are emitted."},{"line_number":25,"context_line":"* versioned: Only the new versioned notifications are emitted."},{"line_number":26,"context_line":"* both: Both the legacy unversioned and the new versioned notifications are"},{"line_number":27,"context_line":"  emitted. (Default)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"Currently there is no feature parity between unversioned and versioned"},{"line_number":30,"context_line":"notifications. If the deployment needs the full range of legacy notifications"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_7b8ed22e","line":27,"in_reply_to":"9a061dce_22a958e0","updated":"2016-04-07 11:21:38.000000000","message":"Actually we agreed on IRC not do deprecate a single value https://review.openstack.org/#/c/247564/17/nova/rpc.py\nhttp://eavesdrop.openstack.org/irclogs/%23openstack-nova/%23openstack-nova.2016-01-08.log.html","commit_id":"f8506618356816c3a01dff5dd99ba7c8a48f483c"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ec567e6bddf55ac63f8dc9580235cd447ccb8390","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Nova is planning to deprecate this parameter as soon as feature parity is"},{"line_number":38,"context_line":"achieved."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"This is an advanced option, deployers rarely needs to change the default value."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Services which consume this:"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_2272f8ad","line":40,"updated":"2016-04-05 09:45:56.000000000","message":"I like markus_z\u0027s suggestion to move this to the top, but we have plans to include this info in the oslo.opt definition.","commit_id":"f8506618356816c3a01dff5dd99ba7c8a48f483c"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"a7effb8859097fb39413d2f8dfde8728eb040937","unresolved":false,"context_lines":[{"line_number":37,"context_line":"Nova is planning to deprecate this parameter as soon as feature parity is"},{"line_number":38,"context_line":"achieved."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"This is an advanced option, deployers rarely needs to change the default value."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"Services which consume this:"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9a061dce_9bd3e65f","line":40,"in_reply_to":"9a061dce_2272f8ad","updated":"2016-04-07 11:21:38.000000000","message":"Done. (in a follow up patch https://review.openstack.org/#/c/302678/)","commit_id":"f8506618356816c3a01dff5dd99ba7c8a48f483c"}],"nova/rpc.py":[{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7dc44eab34717ec1bc2d7863905c7af0736db05e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    \u0027TRANSPORT_ALIASES\u0027,"},{"line_number":27,"context_line":"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo_config import cfg"},{"line_number":30,"context_line":"import oslo_messaging as messaging"},{"line_number":31,"context_line":"from oslo_serialization import jsonutils"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_e2b172e1","line":29,"updated":"2016-02-18 18:39:08.000000000","message":"We don\u0027t need to import oslo_config now as we have centralized config options under nova/conf. We can use,\nimport nova.conf","commit_id":"9fa54a516dc89b7caf9dc20dc52cc041029a7ddb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b8fb0af68d4d8a3d0b701c73908ce05ee7a5b6b0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    \u0027TRANSPORT_ALIASES\u0027,"},{"line_number":27,"context_line":"]"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo_config import cfg"},{"line_number":30,"context_line":"import oslo_messaging as messaging"},{"line_number":31,"context_line":"from oslo_serialization import jsonutils"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_74032c74","line":29,"in_reply_to":"dae33548_e2b172e1","updated":"2016-03-29 08:28:51.000000000","message":"Done","commit_id":"9fa54a516dc89b7caf9dc20dc52cc041029a7ddb"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"7dc44eab34717ec1bc2d7863905c7af0736db05e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"import nova.exception"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"TRANSPORT \u003d None"},{"line_number":40,"context_line":"LEGACY_NOTIFIER \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"dae33548_62d562e3","line":37,"updated":"2016-02-18 18:39:08.000000000","message":"on importing nova.conf we can do,\n\nCONF\u003dnova.conf.CONF","commit_id":"9fa54a516dc89b7caf9dc20dc52cc041029a7ddb"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b8fb0af68d4d8a3d0b701c73908ce05ee7a5b6b0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"import nova.exception"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"CONF \u003d cfg.CONF"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"TRANSPORT \u003d None"},{"line_number":40,"context_line":"LEGACY_NOTIFIER \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba0121b8_d4f8387f","line":37,"in_reply_to":"dae33548_62d562e3","updated":"2016-03-29 08:28:51.000000000","message":"Done","commit_id":"9fa54a516dc89b7caf9dc20dc52cc041029a7ddb"}]}