)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cd998c3de2f8775764f26ee805018746f63156fc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Satyanarayana Patibandla \u003csatya.patibandla@tcs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-04-27 15:27:19 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"These code changes will fix two issues. 1)Allows all tenants to use attribute  \u0027ip\u0027 in server search options (nova list --ip). For this added attribute \u0027ip\u0027 to server search options. 2)Fixes the error  \"Parent instance \u003cFixedIp at 0x54a5610\u003e is not bound to a Session; lazy load operation of attribute \u0027floating_ips\u0027 cannot proceed\". This error we are getting very often while using the command nova list --ip."},{"line_number":8,"context_line":"Fixes Bug #1170718"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ic24ee67d729f77d56c4fe3e1d4110865550c2154"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAOn%2F%2FiVM%3D","line":7,"updated":"2013-05-06 14:25:10.000000000","message":"Fix the commit message to be 50 chars or less and then clean up the body by adding new lines.","commit_id":"92bf8864c975a81264ce046473801dae1a501201"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"67f6abeb724a645881f9c0ed4067074ebc5a63a5","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2013-04-27 16:29:41 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fixed ip and lazy load issue."},{"line_number":8,"context_line":"Fixes: bug #1170718"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: Ic24ee67d729f77d56c4fe3e1d4110865550c2154"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAOn%2F%2FiBo%3D","line":8,"updated":"2013-05-06 17:27:09.000000000","message":"There should be a newline between these two lines otherwise it all becomes part of the commit message title rather than part of the body.\n\nI also think this should probably be broken into separate commits given the original commit message description of what this fixes.  It says you\u0027re fixing bug 1170718 which is the first part of the fix but then you\u0027re also making the lazy load change, which is not related to bug 1170718 and should be fixed on a separate commit (is there a separate bug for that?  If not, you should probably create one and then assign to yourself if you already have the fix.\n\nI also think you should have kept this information in your commit message to help explain what you\u0027re fixing:\n\n1) Allows all tenants to use attribute \u0027ip\u0027 in server search\noptions (nova list --ip). For this fix, added attribute \u0027ip\u0027 to server search options. \n\n2)Fixes the error\n\"Parent instance \u003cFixedIp at 0x54a5610\u003e is not bound to a Session; lazy load operation of attribute \u0027floating_ips\u0027 cannot proceed\". This error we are getting very often while using the command nova\nlist --ip.","commit_id":"d4659076f32eddfab06d768ac5a1bc5ccc63d6d5"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"28b86fab04f2d5e615d0115c9a9a675ec4f542c4","unresolved":false,"context_lines":[{"line_number":1240,"context_line":"@require_context"},{"line_number":1241,"context_line":"def fixed_ips_by_virtual_interface(context, vif_id):"},{"line_number":1242,"context_line":"    result \u003d model_query(context, models.FixedIp, read_deleted\u003d\"no\").\\"},{"line_number":1243,"context_line":"                 options(joinedload(\u0027floating_ips\u0027)).\\"},{"line_number":1244,"context_line":"                 filter_by(virtual_interface_id\u003dvif_id).\\"},{"line_number":1245,"context_line":"                 all()"},{"line_number":1246,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FgYs%3D","line":1243,"updated":"2013-05-07 14:50:58.000000000","message":"https://bugs.launchpad.net/nova/+bug/1170718\nThis bug (that is in commit message) is about filtering instances, and this method works with fixed_ips_by_virutual_inverfaces. \n\nI don\u0027t understand 2 things: \n1) Why this helps with filtering instances\n2) Why do you need here joinload","commit_id":"d4659076f32eddfab06d768ac5a1bc5ccc63d6d5"}]}