)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"51ed9da7d2ce64742f44de4edcae6ba18d03aec1","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Virtuozzo 6 may work with python 2.6 only and"},{"line_number":13,"context_line":"it\u0027s not possible to run upstream nova on virtuozzo 6."},{"line_number":14,"context_line":"We always use this patch in our internal infrastructure"},{"line_number":15,"context_line":"to run openstack on virtuozzo 7."},{"line_number":16,"context_line":"It would be nice to see this patch in upstream."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If3d5e39bd745c0df74316a90159fffb3221864cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa6399be_8a5877fc","line":15,"updated":"2016-10-11 13:33:39.000000000","message":"If virtuozzo 6 is not supported with Nova, can you update the init_host() method in driver.py so that it checks for the minimum required virtuozzo version. Currently it is only checking the min reqiured libvirt driver version - not the virtuozzo hypervisor version.","commit_id":"29a01c7c431e4919f1d6b58115c425ceb94e33ae"},{"author":{"_account_id":15847,"name":"Mikhail Feoktistov","email":"mfeoktistov@virtuozzo.com","username":"mfeoktistov"},"change_message_id":"2adefb62e1899e04a3e093dc496f49c8d8f2b601","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Virtuozzo 6 may work with python 2.6 only and"},{"line_number":13,"context_line":"it\u0027s not possible to run upstream nova on virtuozzo 6."},{"line_number":14,"context_line":"We always use this patch in our internal infrastructure"},{"line_number":15,"context_line":"to run openstack on virtuozzo 7."},{"line_number":16,"context_line":"It would be nice to see this patch in upstream."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If3d5e39bd745c0df74316a90159fffb3221864cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa6399be_62b403d1","line":15,"in_reply_to":"fa6399be_8a5877fc","updated":"2016-10-12 09:46:37.000000000","message":"Thank you! I\u0027ll update init_host()","commit_id":"29a01c7c431e4919f1d6b58115c425ceb94e33ae"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"51ed9da7d2ce64742f44de4edcae6ba18d03aec1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"it\u0027s not possible to run upstream nova on virtuozzo 6."},{"line_number":14,"context_line":"We always use this patch in our internal infrastructure"},{"line_number":15,"context_line":"to run openstack on virtuozzo 7."},{"line_number":16,"context_line":"It would be nice to see this patch in upstream."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If3d5e39bd745c0df74316a90159fffb3221864cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa6399be_0a6d4798","line":16,"updated":"2016-10-11 13:33:39.000000000","message":"This sentence can be dropped from the commit message - it is true of every commit submitted.","commit_id":"29a01c7c431e4919f1d6b58115c425ceb94e33ae"},{"author":{"_account_id":15847,"name":"Mikhail Feoktistov","email":"mfeoktistov@virtuozzo.com","username":"mfeoktistov"},"change_message_id":"2adefb62e1899e04a3e093dc496f49c8d8f2b601","unresolved":false,"context_lines":[{"line_number":13,"context_line":"it\u0027s not possible to run upstream nova on virtuozzo 6."},{"line_number":14,"context_line":"We always use this patch in our internal infrastructure"},{"line_number":15,"context_line":"to run openstack on virtuozzo 7."},{"line_number":16,"context_line":"It would be nice to see this patch in upstream."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: If3d5e39bd745c0df74316a90159fffb3221864cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"fa6399be_5d6fe4c4","line":16,"in_reply_to":"fa6399be_0a6d4798","updated":"2016-10-12 09:46:37.000000000","message":"Yes, of course. I mean that we have used this patch in our test environment for a long time. That\u0027s why I think it\u0027s time to merge this patch to upstream. But I agree that the last sentence is incorrect formulated and can be dropped.","commit_id":"29a01c7c431e4919f1d6b58115c425ceb94e33ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2da86b582607eb9accec7d178d353530a0dfc5a0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"We don\u0027t need to check libvirt version in case of Virtuozzo hypervisor."},{"line_number":18,"context_line":"Because Virtuozzo 7 always has libvirt with"},{"line_number":19,"context_line":"support of \u0027parallels\u0027 virt type."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: If3d5e39bd745c0df74316a90159fffb3221864cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7a77a97e_8f5ea243","line":20,"updated":"2016-11-22 14:47:11.000000000","message":"We should probably add a DocImpact tag here and note to update this docs page for the minimum versions required now:\n\nhttp://docs.openstack.org/newton/config-reference/compute/hypervisor-virtuozzo.html","commit_id":"7259e5ed3291220fdd428863c02f2027b6a8a064"},{"author":{"_account_id":15847,"name":"Mikhail Feoktistov","email":"mfeoktistov@virtuozzo.com","username":"mfeoktistov"},"change_message_id":"457a7b337f696f30c0a97121d24276f4702da532","unresolved":false,"context_lines":[{"line_number":17,"context_line":"We don\u0027t need to check libvirt version in case of Virtuozzo hypervisor."},{"line_number":18,"context_line":"Because Virtuozzo 7 always has libvirt with"},{"line_number":19,"context_line":"support of \u0027parallels\u0027 virt type."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: If3d5e39bd745c0df74316a90159fffb3221864cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7a77a97e_b262e214","line":20,"in_reply_to":"7a77a97e_8f5ea243","updated":"2016-11-22 15:54:35.000000000","message":"Done.\nhttps://review.openstack.org/#/c/400826/","commit_id":"7259e5ed3291220fdd428863c02f2027b6a8a064"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"220105f27a338b93eaa20fbd36406d77f3a0100d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"Because Virtuozzo 7 always has libvirt with"},{"line_number":19,"context_line":"support of \u0027parallels\u0027 virt type."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"DocImpact"},{"line_number":22,"context_line":"Change-Id: If3d5e39bd745c0df74316a90159fffb3221864cc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5a74a57a_01144042","line":21,"updated":"2016-11-23 22:37:44.000000000","message":"We don\u0027t need this now that https://review.openstack.org/#/c/400826/ is already merged, it will just create a nova bug that we\u0027ll have to triage. So I\u0027m going to just remove it.","commit_id":"2b262dfa7eb0bbefbedda1c557cba558b488fc7f"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"92aec410b0b850d7f9247a7cfaaf6975ef8d1cf7","unresolved":false,"context_lines":[{"line_number":14564,"context_line":"        self.flags(virt_type\u003d\u0027parallels\u0027, group\u003d\u0027libvirt\u0027)"},{"line_number":14565,"context_line":"        driver \u003d libvirt_driver.LibvirtDriver(fake.FakeVirtAPI(), False)"},{"line_number":14566,"context_line":"        with test.nested("},{"line_number":14567,"context_line":"                    mock.patch.object("},{"line_number":14568,"context_line":"                        driver._conn, \u0027getVersion\u0027),"},{"line_number":14569,"context_line":"                    mock.patch.object("},{"line_number":14570,"context_line":"                        driver._conn, \u0027getLibVersion\u0027))\\"}],"source_content_type":"text/x-python","patch_set":15,"id":"da6895a0_86f87d7e","line":14567,"updated":"2016-10-21 10:52:06.000000000","message":"Nit: I much prefer using the decorator form, and using patch_object on the class, rather than using the object.\n\nBut I will not block on that.","commit_id":"907cc5ef2cbf4b6906e6e1960e47ee0bfb4109bd"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"81780a4f55a277fe2c9953c3a020a4f014729a8d","unresolved":false,"context_lines":[{"line_number":254,"context_line":"MIN_QEMU_HYPERV_TIMER_VERSION \u003d (2, 0, 0)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"# parallels driver support"},{"line_number":257,"context_line":"MIN_LIBVIRT_PARALLELS_VERSION \u003d (1, 2, 12)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Ability to set the user guest password with Qemu"},{"line_number":260,"context_line":"MIN_LIBVIRT_SET_ADMIN_PASSWD \u003d (1, 2, 16)"}],"source_content_type":"text/x-python","patch_set":14,"id":"fa6399be_65cb541f","side":"PARENT","line":257,"updated":"2016-10-18 09:44:06.000000000","message":"The current min libvirt is 1.2.1, so you can\u0027t remove this check for libvirt \u003e 1.2.12 yet. You must check libvirt version *and* virtuozzo HV version.","commit_id":"bc1b11fdc2c140be916ee3b3b31993cbd6d13ac6"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1214f335a9790942e335c582efc8db4c1a0e2cc6","unresolved":false,"context_lines":[{"line_number":252,"context_line":"MIN_LIBVIRT_HYPERV_TIMER_VERSION \u003d (1, 2, 2)"},{"line_number":253,"context_line":"MIN_QEMU_HYPERV_TIMER_VERSION \u003d (2, 0, 0)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Virtuozzo driver support"},{"line_number":256,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"},{"line_number":257,"context_line":"MIN_LIBVIRT_VIRTUOZZO_VERSION \u003d (1, 2, 12)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Ability to set the user guest password with Qemu"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_b169cfc0","line":256,"range":{"start_line":255,"start_character":0,"end_line":256,"end_character":33},"updated":"2016-10-20 10:06:13.000000000","message":"This is a separate change and should go in as such","commit_id":"907cc5ef2cbf4b6906e6e1960e47ee0bfb4109bd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"1214f335a9790942e335c582efc8db4c1a0e2cc6","unresolved":false,"context_lines":[{"line_number":253,"context_line":"MIN_QEMU_HYPERV_TIMER_VERSION \u003d (2, 0, 0)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Virtuozzo driver support"},{"line_number":256,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"},{"line_number":257,"context_line":"MIN_LIBVIRT_VIRTUOZZO_VERSION \u003d (1, 2, 12)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Ability to set the user guest password with Qemu"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_f148a75e","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":21},"updated":"2016-10-20 10:06:13.000000000","message":"You seems to be switching between virtuozzo and parallels below. Can we keep this to \u0027parallels\u0027?","commit_id":"907cc5ef2cbf4b6906e6e1960e47ee0bfb4109bd"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"92aec410b0b850d7f9247a7cfaaf6975ef8d1cf7","unresolved":false,"context_lines":[{"line_number":253,"context_line":"MIN_QEMU_HYPERV_TIMER_VERSION \u003d (2, 0, 0)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Virtuozzo driver support"},{"line_number":256,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"},{"line_number":257,"context_line":"MIN_LIBVIRT_VIRTUOZZO_VERSION \u003d (1, 2, 12)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Ability to set the user guest password with Qemu"}],"source_content_type":"text/x-python","patch_set":15,"id":"da6895a0_26bfb1d1","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":21},"in_reply_to":"fa6399be_365f6de6","updated":"2016-10-21 10:52:06.000000000","message":"We should really finish of the rename. I would also prefer the raising of the min version was a separate patch.\n\nI don\u0027t want to block on either of those things though.","commit_id":"907cc5ef2cbf4b6906e6e1960e47ee0bfb4109bd"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d4f4047e72ac50b69e8e7a1792f9371f14008c58","unresolved":false,"context_lines":[{"line_number":253,"context_line":"MIN_QEMU_HYPERV_TIMER_VERSION \u003d (2, 0, 0)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Virtuozzo driver support"},{"line_number":256,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"},{"line_number":257,"context_line":"MIN_LIBVIRT_VIRTUOZZO_VERSION \u003d (1, 2, 12)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Ability to set the user guest password with Qemu"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_365f6de6","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":21},"in_reply_to":"fa6399be_6723f558","updated":"2016-10-20 13:04:46.000000000","message":"Tes, but would it not be better to use the same \"old name\" everywhere, rather than trying to guess what we\u0027re talking about? This would mean defining MIN_PARALLELS_VERSION, even though it\u0027s now called virtuozo.","commit_id":"907cc5ef2cbf4b6906e6e1960e47ee0bfb4109bd"},{"author":{"_account_id":12408,"name":"Maxim Nestratov","email":"mnestratov@virtuozzo.com","username":"mnestratov"},"change_message_id":"01248f88d3c5baf6d8bc75d6a7d00fb43985286d","unresolved":false,"context_lines":[{"line_number":252,"context_line":"MIN_LIBVIRT_HYPERV_TIMER_VERSION \u003d (1, 2, 2)"},{"line_number":253,"context_line":"MIN_QEMU_HYPERV_TIMER_VERSION \u003d (2, 0, 0)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Virtuozzo driver support"},{"line_number":256,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"},{"line_number":257,"context_line":"MIN_LIBVIRT_VIRTUOZZO_VERSION \u003d (1, 2, 12)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Ability to set the user guest password with Qemu"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_f1aa6770","line":256,"range":{"start_line":255,"start_character":0,"end_line":256,"end_character":33},"in_reply_to":"fa6399be_b169cfc0","updated":"2016-10-20 10:22:45.000000000","message":"Let me disagree. I can\u0027t see any profit in splitting this into a separate patch as we are are not going to backport any part of the change separately and changes themselves are trivial.","commit_id":"907cc5ef2cbf4b6906e6e1960e47ee0bfb4109bd"},{"author":{"_account_id":15847,"name":"Mikhail Feoktistov","email":"mfeoktistov@virtuozzo.com","username":"mfeoktistov"},"change_message_id":"c1eaa89085014da9db907866df8a85e211a9b9d6","unresolved":false,"context_lines":[{"line_number":253,"context_line":"MIN_QEMU_HYPERV_TIMER_VERSION \u003d (2, 0, 0)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"# Virtuozzo driver support"},{"line_number":256,"context_line":"MIN_VIRTUOZZO_VERSION \u003d (7, 0, 0)"},{"line_number":257,"context_line":"MIN_LIBVIRT_VIRTUOZZO_VERSION \u003d (1, 2, 12)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Ability to set the user guest password with Qemu"}],"source_content_type":"text/x-python","patch_set":15,"id":"fa6399be_6723f558","line":256,"range":{"start_line":256,"start_character":0,"end_line":256,"end_character":21},"in_reply_to":"fa6399be_f148a75e","updated":"2016-10-20 11:10:40.000000000","message":"It\u0027s better to rename from parallels to virtuozzo, because\nhypervisor has name \"Virtuozzo\". Old name was \"Parallels\", but\nnow it\u0027s virtuozzo. It makes sense to avoid confusion between MIN_VIRTUOZZO_VERSION and MIN_LIBVIRT_PARALLELS_VERSION. We can\u0027t change virt_type for backward compatibility.","commit_id":"907cc5ef2cbf4b6906e6e1960e47ee0bfb4109bd"}],"releasenotes/notes/supported-virtuozzo-version-569db9259a7ee579.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2da86b582607eb9accec7d178d353530a0dfc5a0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - As of Ocata, the minimum version of Virtuozzo that nova compute will"},{"line_number":4,"context_line":"    interoperate with will be 7.0.0. Deployments using older versions of"},{"line_number":5,"context_line":"    Virtuozzo should upgrade."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a77a97e_4a09d82b","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":29},"updated":"2016-11-22 14:47:11.000000000","message":"I feel like this should qualify \u0027with libvirt\u0027 in here, because if you\u0027re not using libvirt you don\u0027t care about this.","commit_id":"7259e5ed3291220fdd428863c02f2027b6a8a064"},{"author":{"_account_id":15847,"name":"Mikhail Feoktistov","email":"mfeoktistov@virtuozzo.com","username":"mfeoktistov"},"change_message_id":"457a7b337f696f30c0a97121d24276f4702da532","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - As of Ocata, the minimum version of Virtuozzo that nova compute will"},{"line_number":4,"context_line":"    interoperate with will be 7.0.0. Deployments using older versions of"},{"line_number":5,"context_line":"    Virtuozzo should upgrade."}],"source_content_type":"text/x-yaml","patch_set":16,"id":"7a77a97e_55c97878","line":5,"range":{"start_line":3,"start_character":4,"end_line":5,"end_character":29},"in_reply_to":"7a77a97e_4a09d82b","updated":"2016-11-22 15:54:35.000000000","message":"Virtuozzo uses only libvirt to communicate with openstack.\nThere is no Virtuozzo without libvirt.\nAnd you don\u0027t need to upgrade libvirt separately.\nIf you upgrade virtuozzo it also upgrades libvirt to necessary version.","commit_id":"7259e5ed3291220fdd428863c02f2027b6a8a064"}]}