)]}'
{"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"568f15fa97ea163adb6cc003b152e5f43f58ec1e","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        \"\"\""},{"line_number":391,"context_line":"        raise NotImplementedError()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def check_backing_from_func(self, func, cache_name,"},{"line_number":394,"context_line":"                                fallback_from_host\u003dNone):"},{"line_number":395,"context_line":"        pass"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_7e9bca72","line":393,"updated":"2016-04-13 13:25:54.000000000","message":"It seems that names of both functions you have added are the same, what is the reason to add check_backing_from_func that has only pass in its body?","commit_id":"b9f21fe50a7d9ce90181362a94ec352d8a654a34"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"7e91da973ab40cbac46acbd7e2dca4f0d816a9f8","unresolved":false,"context_lines":[{"line_number":390,"context_line":"        \"\"\""},{"line_number":391,"context_line":"        raise NotImplementedError()"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def check_backing_from_func(self, func, cache_name,"},{"line_number":394,"context_line":"                                fallback_from_host\u003dNone):"},{"line_number":395,"context_line":"        pass"},{"line_number":396,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a18252c_b6d46220","line":393,"in_reply_to":"5a18252c_7e9bca72","updated":"2016-04-13 15:15:57.000000000","message":"This is the superclass. It is the default implementation (i.e. do nothing) for all classes which don\u0027t override it. The reason for this is explained in the commit message.","commit_id":"b9f21fe50a7d9ce90181362a94ec352d8a654a34"},{"author":{"_account_id":5280,"name":"Nicolas Simonds","email":"nic@metacloud.com","username":"nicolas.simonds"},"change_message_id":"694e30a19c91de64ec75453cbf1d7e17cc932c8a","unresolved":false,"context_lines":[{"line_number":825,"context_line":""},{"line_number":826,"context_line":"    def check_backing_from_func(self, func, cache_name,"},{"line_number":827,"context_line":"                                fallback_from_host\u003dNone):"},{"line_number":828,"context_line":"        backing_path \u003d libvirt_utils.get_disk_backing_file("},{"line_number":829,"context_line":"            self.path, imgmodel.FORMAT_QCOW2)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        if backing_path is None:"},{"line_number":832,"context_line":"            return"},{"line_number":833,"context_line":""},{"line_number":834,"context_line":"        cache_pool \u003d ImageCacheLocalPool.get()"},{"line_number":835,"context_line":"        if not cache_pool.is_path_in_image_cache(backing_path):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a122d0e_95ef0ee8","line":832,"range":{"start_line":828,"start_character":8,"end_line":832,"end_character":18},"updated":"2016-04-29 15:32:55.000000000","message":"Unless I\u0027m really reading things wrong, get_disk_backing_file() throws exceptions rather than returning a NoneType when things go wrong, so this might not work as expected.","commit_id":"704cb0d0ddbea3e5960341ce6341d05864ca0282"}]}