)]}'
{"nova/db/sqlalchemy/migrate_repo/versions/315_add_aggregate_uuid.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3a957d3786fc3232c11459a69d6a5a5d2c0a24aa","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    meta \u003d MetaData()"},{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for table_name in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":26,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_name, meta)"},{"line_number":27,"context_line":"        aggregates.create_column(uuid_column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_7105fec0","line":24,"updated":"2016-02-19 20:11:17.000000000","message":"table_prefix","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5f74943cd429507fd1f083c780d57cc9e8fff4ef","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    meta \u003d MetaData()"},{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for table_name in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":26,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_name, meta)"},{"line_number":27,"context_line":"        aggregates.create_column(uuid_column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_71885e23","line":24,"in_reply_to":"bae84128_7105fec0","updated":"2016-02-19 20:12:51.000000000","message":"This means it\u0027s wrong in the previous migration too :D","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f8c10a86afd52569a59740316ef115a7cbe990f4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    meta \u003d MetaData()"},{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for table_name in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":26,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_name, meta)"},{"line_number":27,"context_line":"        aggregates.create_column(uuid_column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_71c7be12","line":24,"in_reply_to":"bae84128_71885e23","updated":"2016-02-19 20:21:55.000000000","message":"That\u0027s my bad because it had been \"stupid\" and I changed it.","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0bec9870b3f9a0e96e1f746b7dd01b5fbdb3c181","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    meta \u003d MetaData()"},{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for table_name in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":26,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_name, meta)"},{"line_number":27,"context_line":"        aggregates.create_column(uuid_column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_033549d9","line":24,"in_reply_to":"bae84128_71c7be12","updated":"2016-02-19 20:26:37.000000000","message":"Glad it was your fault and... it was stupid :)","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3a957d3786fc3232c11459a69d6a5a5d2c0a24aa","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for table_name in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":26,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_name, meta)"},{"line_number":27,"context_line":"        aggregates.create_column(uuid_column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_31f256d3","line":25,"updated":"2016-02-19 20:11:17.000000000","message":"There should be a unique constraint added as well.","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"74b73a0a94b4393384872330b89805c93a61b8cc","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for table_name in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":26,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_name, meta)"},{"line_number":27,"context_line":"        aggregates.create_column(uuid_column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_71ee9e8c","line":25,"in_reply_to":"bae84128_11747233","updated":"2016-02-19 20:21:22.000000000","message":"Ahh, yep.","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"f8c10a86afd52569a59740316ef115a7cbe990f4","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for table_name in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":26,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_name, meta)"},{"line_number":27,"context_line":"        aggregates.create_column(uuid_column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_51f39a73","line":25,"in_reply_to":"bae84128_11747233","updated":"2016-02-19 20:21:55.000000000","message":"If we can\u0027t have uniqueconstraint we can (and should) have Index, yeah?","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"5f74943cd429507fd1f083c780d57cc9e8fff4ef","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for table_name in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":26,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_name, meta)"},{"line_number":27,"context_line":"        aggregates.create_column(uuid_column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_11747233","line":25,"in_reply_to":"bae84128_31f256d3","updated":"2016-02-19 20:12:51.000000000","message":"We can\u0027t until we have made it non-null and filled it out, right? Like, I think we can do that in newton, but not before, right?","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"0bec9870b3f9a0e96e1f746b7dd01b5fbdb3c181","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    meta.bind \u003d migrate_engine"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    for table_name in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":25,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":26,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_name, meta)"},{"line_number":27,"context_line":"        aggregates.create_column(uuid_column)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_23520d14","line":25,"in_reply_to":"bae84128_51f39a73","updated":"2016-02-19 20:26:37.000000000","message":"Probably so yeah.","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"abcc8c18eb704b91c751dea5f641c4f7aedd3cc1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    for table_prefix in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":26,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":27,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_prefix, meta)"},{"line_number":28,"context_line":"        aggregates.create_column(uuid_column)"},{"line_number":29,"context_line":"        if migrate_engine.name !\u003d \u0027ibm_db_sa\u0027 and not table_prefix:"},{"line_number":30,"context_line":"            index \u003d Index(\u0027aggregate_uuid_idx\u0027, aggregates.c.uuid)"},{"line_number":31,"context_line":"            index.create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_1c876662","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":45},"updated":"2016-02-19 21:48:34.000000000","message":"I thought you were supposed to check if the column already exists before creating it so this is idempotent.","commit_id":"c93a35fad02d7c7af81131eef41e926839e90f65"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e4579513ef3f51717c27294f1dab05ced4e8df11","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    for table_prefix in (\u0027\u0027, \u0027shadow_\u0027):"},{"line_number":26,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":27,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_prefix, meta)"},{"line_number":28,"context_line":"        aggregates.create_column(uuid_column)"},{"line_number":29,"context_line":"        if migrate_engine.name !\u003d \u0027ibm_db_sa\u0027 and not table_prefix:"},{"line_number":30,"context_line":"            index \u003d Index(\u0027aggregate_uuid_idx\u0027, aggregates.c.uuid)"},{"line_number":31,"context_line":"            index.create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_3ce98a1b","line":28,"range":{"start_line":28,"start_character":8,"end_line":28,"end_character":45},"in_reply_to":"bae84128_1c876662","updated":"2016-02-19 21:49:34.000000000","message":"Yes","commit_id":"c93a35fad02d7c7af81131eef41e926839e90f65"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"11bba81081b7ff4826888a75854185f532db4cc3","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":27,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_prefix, meta)"},{"line_number":28,"context_line":"        aggregates.create_column(uuid_column)"},{"line_number":29,"context_line":"        if migrate_engine.name !\u003d \u0027ibm_db_sa\u0027 and not table_prefix:"},{"line_number":30,"context_line":"            index \u003d Index(\u0027aggregate_uuid_idx\u0027, aggregates.c.uuid)"},{"line_number":31,"context_line":"            index.create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_263cdb92","line":29,"updated":"2016-02-19 20:57:30.000000000","message":"No credit to mriedem? :)","commit_id":"c93a35fad02d7c7af81131eef41e926839e90f65"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"35125dd3bc4c9b3dd9e86f9e3bdd1fe083ba344b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":27,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_prefix, meta)"},{"line_number":28,"context_line":"        aggregates.create_column(uuid_column)"},{"line_number":29,"context_line":"        if migrate_engine.name !\u003d \u0027ibm_db_sa\u0027 and not table_prefix:"},{"line_number":30,"context_line":"            index \u003d Index(\u0027aggregate_uuid_idx\u0027, aggregates.c.uuid)"},{"line_number":31,"context_line":"            index.create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_9cac16ef","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":46},"updated":"2016-02-19 21:47:58.000000000","message":"Why is this in here anyway?  If it\u0027s not in a unique constraint, it\u0027s not a problem.","commit_id":"c93a35fad02d7c7af81131eef41e926839e90f65"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"e4579513ef3f51717c27294f1dab05ced4e8df11","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        uuid_column \u003d Column(\u0027uuid\u0027, String(36))"},{"line_number":27,"context_line":"        aggregates \u003d Table(\u0027%saggregates\u0027 % table_prefix, meta)"},{"line_number":28,"context_line":"        aggregates.create_column(uuid_column)"},{"line_number":29,"context_line":"        if migrate_engine.name !\u003d \u0027ibm_db_sa\u0027 and not table_prefix:"},{"line_number":30,"context_line":"            index \u003d Index(\u0027aggregate_uuid_idx\u0027, aggregates.c.uuid)"},{"line_number":31,"context_line":"            index.create()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_1cee4622","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":46},"in_reply_to":"bae84128_9cac16ef","updated":"2016-02-19 21:49:34.000000000","message":"Yeah.","commit_id":"c93a35fad02d7c7af81131eef41e926839e90f65"}],"nova/db/sqlalchemy/models.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3a957d3786fc3232c11459a69d6a5a5d2c0a24aa","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"class Aggregate(BASE, NovaBase, models.SoftDeleteMixin):"},{"line_number":1097,"context_line":"    \"\"\"Represents a cluster of hosts that exists in this zone.\"\"\""},{"line_number":1098,"context_line":"    __tablename__ \u003d \u0027aggregates\u0027"},{"line_number":1099,"context_line":"    __table_args__ \u003d ()"},{"line_number":1100,"context_line":"    id \u003d Column(Integer, primary_key\u003dTrue, autoincrement\u003dTrue)"},{"line_number":1101,"context_line":"    uuid \u003d Column(String(36))"},{"line_number":1102,"context_line":"    name \u003d Column(String(255))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_d1cb2a71","line":1099,"updated":"2016-02-19 20:11:17.000000000","message":"uuid should have a schema.UniqueConstraint set.","commit_id":"3f48f65289dd003f79d553174d43c5d289a0336c"}],"nova/tests/unit/db/test_migrations.py":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"df608ce5e544292daf3abf78c055d6f8d8bedbef","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    def _check_315(self, engine, data):"},{"line_number":837,"context_line":"        self.assertColumnExists(engine, \u0027aggregates\u0027, \u0027uuid\u0027)"},{"line_number":838,"context_line":"        self.assertColumnExists(engine, \u0027shadow_aggregates\u0027, \u0027uuid\u0027)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"},{"line_number":842,"context_line":"                               test_base.DbTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_7c8312cd","line":839,"updated":"2016-02-19 22:04:10.000000000","message":"shouldn\u0027t we verify that we add an index ?","commit_id":"10aea642f7713ab7861bdbb1fc9cc49261a949a0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"14227e16bd69fefa790407b6257ccd426eeff7a8","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    def _check_315(self, engine, data):"},{"line_number":837,"context_line":"        self.assertColumnExists(engine, \u0027aggregates\u0027, \u0027uuid\u0027)"},{"line_number":838,"context_line":"        self.assertColumnExists(engine, \u0027shadow_aggregates\u0027, \u0027uuid\u0027)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"},{"line_number":842,"context_line":"                               test_base.DbTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_be534b38","line":839,"in_reply_to":"bae84128_0ca34301","updated":"2016-02-23 15:40:01.000000000","message":"OK, I thought those were gone, sorry for piling on here then.","commit_id":"10aea642f7713ab7861bdbb1fc9cc49261a949a0"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"2162e0f27598c944f12cc3f10dc38acdbbab9380","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    def _check_315(self, engine, data):"},{"line_number":837,"context_line":"        self.assertColumnExists(engine, \u0027aggregates\u0027, \u0027uuid\u0027)"},{"line_number":838,"context_line":"        self.assertColumnExists(engine, \u0027shadow_aggregates\u0027, \u0027uuid\u0027)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"},{"line_number":842,"context_line":"                               test_base.DbTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_bad713be","line":839,"in_reply_to":"bae84128_27715ce1","updated":"2016-02-22 15:39:25.000000000","message":"We still have tests that check the models against the schemas, at least on the api db and I think they\u0027re still around in this db.","commit_id":"10aea642f7713ab7861bdbb1fc9cc49261a949a0"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"fdd777cb10b67817ffaec59cb6751f0b1f8d04e0","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    def _check_315(self, engine, data):"},{"line_number":837,"context_line":"        self.assertColumnExists(engine, \u0027aggregates\u0027, \u0027uuid\u0027)"},{"line_number":838,"context_line":"        self.assertColumnExists(engine, \u0027shadow_aggregates\u0027, \u0027uuid\u0027)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"},{"line_number":842,"context_line":"                               test_base.DbTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_8d20629d","line":839,"in_reply_to":"bae84128_7c8312cd","updated":"2016-02-19 23:12:54.000000000","message":"That would be nice. I think the intent of this test framework was mostly to populate the table, run the migration, then check the data, but it doesn\u0027t get used that way. So may as well just check the schema changes happened.","commit_id":"10aea642f7713ab7861bdbb1fc9cc49261a949a0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0150cdb17e2c59a8da46e9c56df924734c473d23","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    def _check_315(self, engine, data):"},{"line_number":837,"context_line":"        self.assertColumnExists(engine, \u0027aggregates\u0027, \u0027uuid\u0027)"},{"line_number":838,"context_line":"        self.assertColumnExists(engine, \u0027shadow_aggregates\u0027, \u0027uuid\u0027)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"},{"line_number":842,"context_line":"                               test_base.DbTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_27715ce1","line":839,"in_reply_to":"bae84128_880fb0e0","updated":"2016-02-20 23:10:51.000000000","message":"I could see why testing that the column was created is maybe unnecessary since the object code that builds on this will fail if it didn\u0027t. But the object code and the DB API has no insight into the index creation, so if anything that\u0027s the thing that\u0027s valid to test here, right?\n\nPlus without the tests that validate the schema against the models, we have to do more of this explicit testing (at least I\u0027m pretty sure those were removed when jerdfelt\u0027s patch was reverted).","commit_id":"10aea642f7713ab7861bdbb1fc9cc49261a949a0"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b19102587e63c02340aca1de401ea1aac855a959","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    def _check_315(self, engine, data):"},{"line_number":837,"context_line":"        self.assertColumnExists(engine, \u0027aggregates\u0027, \u0027uuid\u0027)"},{"line_number":838,"context_line":"        self.assertColumnExists(engine, \u0027shadow_aggregates\u0027, \u0027uuid\u0027)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"},{"line_number":842,"context_line":"                               test_base.DbTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_ed8dae7c","line":839,"in_reply_to":"bae84128_8d20629d","updated":"2016-02-19 23:15:41.000000000","message":"Well, this was also written when we changed data in migrations, which was often wrong. Sean has smacked people for testing obvious stuff here like \"did we add a column\" since that stuff will cause a billion fails if you don\u0027t anyway.\n\nSo, I added it because I have to, not because I think even what is here is useful.","commit_id":"10aea642f7713ab7861bdbb1fc9cc49261a949a0"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"54254000efb46dd32699ddb4b852a320c6373b28","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    def _check_315(self, engine, data):"},{"line_number":837,"context_line":"        self.assertColumnExists(engine, \u0027aggregates\u0027, \u0027uuid\u0027)"},{"line_number":838,"context_line":"        self.assertColumnExists(engine, \u0027shadow_aggregates\u0027, \u0027uuid\u0027)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"},{"line_number":842,"context_line":"                               test_base.DbTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_da8ad7be","line":839,"in_reply_to":"bae84128_bad713be","updated":"2016-02-22 15:41:08.000000000","message":"Yeah, they are there, have caught me a few times during resource-provider stuff.","commit_id":"10aea642f7713ab7861bdbb1fc9cc49261a949a0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5cbd53dfdf61235d4bd49a5e17f21d7016b9bfa6","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    def _check_315(self, engine, data):"},{"line_number":837,"context_line":"        self.assertColumnExists(engine, \u0027aggregates\u0027, \u0027uuid\u0027)"},{"line_number":838,"context_line":"        self.assertColumnExists(engine, \u0027shadow_aggregates\u0027, \u0027uuid\u0027)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"},{"line_number":842,"context_line":"                               test_base.DbTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0ca34301","line":839,"in_reply_to":"bae84128_da8ad7be","updated":"2016-02-23 10:51:47.000000000","message":"Okay, fair point","commit_id":"10aea642f7713ab7861bdbb1fc9cc49261a949a0"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"0834934cf81835231596a025c01c01c19965fb1c","unresolved":false,"context_lines":[{"line_number":836,"context_line":"    def _check_315(self, engine, data):"},{"line_number":837,"context_line":"        self.assertColumnExists(engine, \u0027aggregates\u0027, \u0027uuid\u0027)"},{"line_number":838,"context_line":"        self.assertColumnExists(engine, \u0027shadow_aggregates\u0027, \u0027uuid\u0027)"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":""},{"line_number":841,"context_line":"class TestNovaMigrationsSQLite(NovaMigrationsCheckers,"},{"line_number":842,"context_line":"                               test_base.DbTestCase,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_880fb0e0","line":839,"in_reply_to":"bae84128_ed8dae7c","updated":"2016-02-19 23:53:05.000000000","message":"Well, my point is related to the already existing migration UTs which check the created indexes. That said, I don\u0027t wanna block this, just commenting out.","commit_id":"10aea642f7713ab7861bdbb1fc9cc49261a949a0"}]}