)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb861a7c42f758f90046cbd7afefa9ddc46cb53d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Note that this filters uuid from the aggregate view in the API because we would"},{"line_number":10,"context_line":"need a microversion. That may be a thing in the future (for the 2.x api) but"},{"line_number":11,"context_line":"not something we can do here."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related to blueprint generic-resource-pools"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I45006e546867d348563831986b91a317029a1173"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"bae84128_acc217e7","line":12,"updated":"2016-02-23 11:02:20.000000000","message":"just thinking out loud, we don\u0027t need to provide a nova-manage stuff for making sure that all aggregates now have an UUID, because https://github.com/openstack/nova/blob/master/nova/scheduler/host_manager.py#L354\n\nNice, it will tho be a bit expensive for the first nova-scheduler boot but that\u0027s fine IMHO.\n\nJust holding the +W for discussing about that.","commit_id":"bd6038748719d37b7efad5cb20596a50638f9822"}],"nova/api/openstack/compute/aggregates.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8367b36fae6bb1273b6bb034e558393c8771c427","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        for key in keys:"},{"line_number":212,"context_line":"            if ((aggregate.obj_attr_is_set(key)"},{"line_number":213,"context_line":"                    or key in aggregate.obj_extra_fields) and"},{"line_number":214,"context_line":"                  key !\u003d \u0027uuid\u0027):"},{"line_number":215,"context_line":"                yield key, getattr(aggregate, key)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_c6cecf82","line":214,"updated":"2016-02-19 21:01:08.000000000","message":"Worth having a note that uuid will be made visible somewhere down the line?","commit_id":"dc363fd66d87690719faeeaaa9559ba4cde6fdb9"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"eb861a7c42f758f90046cbd7afefa9ddc46cb53d","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        for key in keys:"},{"line_number":212,"context_line":"            if ((aggregate.obj_attr_is_set(key)"},{"line_number":213,"context_line":"                    or key in aggregate.obj_extra_fields) and"},{"line_number":214,"context_line":"                  key !\u003d \u0027uuid\u0027):"},{"line_number":215,"context_line":"                yield key, getattr(aggregate, key)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_ec5a5ff1","line":214,"updated":"2016-02-23 11:02:20.000000000","message":"Kewl...","commit_id":"bd6038748719d37b7efad5cb20596a50638f9822"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"730a999a7d1f476d41b066d50caf6636fed9843a","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        for key in keys:"},{"line_number":212,"context_line":"            if ((aggregate.obj_attr_is_set(key)"},{"line_number":213,"context_line":"                    or key in aggregate.obj_extra_fields) and"},{"line_number":214,"context_line":"                  key !\u003d \u0027uuid\u0027):"},{"line_number":215,"context_line":"                yield key, getattr(aggregate, key)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_01065a1c","line":214,"range":{"start_line":214,"start_character":18,"end_line":214,"end_character":33},"updated":"2016-02-23 15:42:08.000000000","message":"Would be nice to have a comment in the code why this is excluded (b/c it would break the API w/o a microversion). Might be weird to see a year from now.","commit_id":"bd6038748719d37b7efad5cb20596a50638f9822"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"a68b0a2f171e3bb9ba5fb12bb95f48a2c19d0d5e","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        for key in keys:"},{"line_number":212,"context_line":"            if ((aggregate.obj_attr_is_set(key)"},{"line_number":213,"context_line":"                    or key in aggregate.obj_extra_fields) and"},{"line_number":214,"context_line":"                  key !\u003d \u0027uuid\u0027):"},{"line_number":215,"context_line":"                yield key, getattr(aggregate, key)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_4f0ea78c","line":214,"range":{"start_line":214,"start_character":18,"end_line":214,"end_character":33},"in_reply_to":"bae84128_01065a1c","updated":"2016-02-24 07:49:34.000000000","message":"We shouldn\u0027t generate API response with this way. The most safe way is writing response explicitly. Something like: \n\n{\n    \"name\": aggregate.name\n     \"id\": aggregate.id\n     ......\n}","commit_id":"bd6038748719d37b7efad5cb20596a50638f9822"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c73ad38bf2cfebf0611646aedf8914c0cc7ccbd","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        for key in keys:"},{"line_number":212,"context_line":"            if ((aggregate.obj_attr_is_set(key)"},{"line_number":213,"context_line":"                    or key in aggregate.obj_extra_fields) and"},{"line_number":214,"context_line":"                  key !\u003d \u0027uuid\u0027):"},{"line_number":215,"context_line":"                yield key, getattr(aggregate, key)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_9f760104","line":214,"range":{"start_line":214,"start_character":18,"end_line":214,"end_character":33},"in_reply_to":"bae84128_4f0ea78c","updated":"2016-02-24 15:04:11.000000000","message":"Well, we have stuff like this everywhere, so I don\u0027t think it\u0027s too confusing that it\u0027s here. Agree with Alex that we should be defining what our results look like instead of looping like this anyway.\n\nFlattening that would be a good follow-on I think (and general work across the API that would be helpful).\n\nIf I have to rebase this I\u0027ll comment it, but also think it\u0027d be good to see this flattened out instead which will eliminate the need anyway.","commit_id":"bd6038748719d37b7efad5cb20596a50638f9822"}],"nova/api/openstack/compute/legacy_v2/contrib/aggregates.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"730a999a7d1f476d41b066d50caf6636fed9843a","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        for key in keys:"},{"line_number":281,"context_line":"            if ((aggregate.obj_attr_is_set(key)"},{"line_number":282,"context_line":"                    or key in aggregate.obj_extra_fields) and"},{"line_number":283,"context_line":"                  key !\u003d \u0027uuid\u0027):"},{"line_number":284,"context_line":"                yield key, getattr(aggregate, key)"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bae84128_81126a55","line":283,"range":{"start_line":283,"start_character":18,"end_line":283,"end_character":33},"updated":"2016-02-23 15:42:08.000000000","message":"Ditto on having a comment in the code.","commit_id":"bd6038748719d37b7efad5cb20596a50638f9822"}]}