)]}'
{"nova/utils.py":[{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"9c006b7e02d733961cb1763da26dae756f1ce25a","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"    \"\"\""},{"line_number":1181,"context_line":"    mtime \u003d os.path.getmtime(filename)"},{"line_number":1182,"context_line":"    if not cache_info or mtime !\u003d cache_info.get(\u0027mtime\u0027):"},{"line_number":1183,"context_line":"        with open(filename) as fd:"},{"line_number":1184,"context_line":"            cache_info[\u0027data\u0027] \u003d fd.read()"},{"line_number":1185,"context_line":"        cache_info[\u0027mtime\u0027] \u003d mtime"},{"line_number":1186,"context_line":"        if reload_func:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAADX%2F%2F%2F6U%3D","line":1183,"updated":"2012-01-05 19:58:37.000000000","message":"Minor, but `fd` seems like a misnamed variable.\n\nIn this case, we\u0027re getting back a file-object, not a file-descriptor handle (e.g. an integer).\n\n`f` or `fileobj` would be more typical.\n\nJust as an example, if you wanted the actual fd, you could do something like:\n\nwith open(path) as f:\n    fd \u003d f.fileno()\n    print fd","commit_id":"6a572639cc35153336e934c09364f648c30f5245"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"ab323d374464d868ee2febc26898b7200369c9d7","unresolved":false,"context_lines":[{"line_number":1180,"context_line":"    \"\"\""},{"line_number":1181,"context_line":"    mtime \u003d os.path.getmtime(filename)"},{"line_number":1182,"context_line":"    if not cache_info or mtime !\u003d cache_info.get(\u0027mtime\u0027):"},{"line_number":1183,"context_line":"        with open(filename) as fd:"},{"line_number":1184,"context_line":"            cache_info[\u0027data\u0027] \u003d fd.read()"},{"line_number":1185,"context_line":"        cache_info[\u0027mtime\u0027] \u003d mtime"},{"line_number":1186,"context_line":"        if reload_func:"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAADX%2F%2F%2F1c%3D","line":1183,"updated":"2012-01-05 22:42:09.000000000","message":"Not sure if you saw this from patch 3, so repasting here. If you did see it, then just ignore :-)\n\nMinor, but `fd` seems like a misnamed variable.\nIn this case, we\u0027re getting back a file-object, not a file-descriptor handle (e.g. an integer).\n`f` or `fileobj` would be more typical.\nJust as an example, if you wanted the actual fd, you could do something like:\nwith open(path) as f:\n    fd \u003d f.fileno()\n    print fd","commit_id":"ffad4ba8b381721ca92a013ac3d9cb1528ed9140"}]}