)]}'
{"nova/tests/unit/virt/xenapi/plugins/plugin_test.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"800dba7922628938a9000f0b32e3b243f6dbb757","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # py34\u0027s syntax. In order to prevent unit test scanning the source file"},{"line_number":47,"context_line":"        # under py34 environment, the plugins will be imported with this"},{"line_number":48,"context_line":"        # function"},{"line_number":49,"context_line":"        # at run time."},{"line_number":50,"context_line":"        current_path \u003d os.path.realpath(__file__)"},{"line_number":51,"context_line":"        rel_path \u003d os.path.join(current_path,"},{"line_number":52,"context_line":"            \"../../../../../../../plugins/xenserver/xenapi/etc/xapi.d/plugins\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_f3a96625","line":49,"updated":"2016-03-01 10:28:09.000000000","message":"I don\u0027t really know what this has to do with py34, this is more about keeping the plugin files out of the regular tree of python code that gets installed. And I think thats the correct thing to keep doing.","commit_id":"e929b4ef7df3a7c4f472ff570093c44b88d78b4e"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"c296f29063749563c229a56e331d1fa31ee508ac","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        # py34\u0027s syntax. In order to prevent unit test scanning the source file"},{"line_number":47,"context_line":"        # under py34 environment, the plugins will be imported with this"},{"line_number":48,"context_line":"        # function"},{"line_number":49,"context_line":"        # at run time."},{"line_number":50,"context_line":"        current_path \u003d os.path.realpath(__file__)"},{"line_number":51,"context_line":"        rel_path \u003d os.path.join(current_path,"},{"line_number":52,"context_line":"            \"../../../../../../../plugins/xenserver/xenapi/etc/xapi.d/plugins\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_0158ccf9","line":49,"in_reply_to":"9aed3d3a_f3a96625","updated":"2016-03-01 11:04:54.000000000","message":"Sorry, it\u0027s my fault. This note was intended to be added on load_plugin. I ever tried to add the plugin path into the python searching path, so that the plugins could be imported via a regular import statement. But py34 testing job will try to scan and parse the imported source file and results into py34 failure, even though it won\u0027t run plugin tests due to the tests-py3.txt. The note at here is trying to explain that.","commit_id":"e929b4ef7df3a7c4f472ff570093c44b88d78b4e"}],"nova/tests/unit/virt/xenapi/plugins/test_glance.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"cd4ce531f60256dedb1212fe71ec70e2ec194056","unresolved":false,"context_lines":[{"line_number":22,"context_line":"glance \u003d plugins.load_plugin(\"glance\")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class glanceTestCase(test.NoDBTestCase):"},{"line_number":26,"context_line":"    @mock.patch.object(glance, \u0027_download_tarball_by_url\u0027)"},{"line_number":27,"context_line":"    def test_download_tarball(self, mock_download_tarball_by_url):"},{"line_number":28,"context_line":"        sr_path \u003d \u0027sr_path\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bae84128_b3069983","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":20},"updated":"2016-02-24 16:24:21.000000000","message":"Should be \"GlanceTestCase\".","commit_id":"2ffa2dd05790154577f5d4ff346ec5f88fada994"}],"nova/tests/unit/virt/xenapi/plugins/test_nova_plugin_version.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"bcf8acebf9d41b37a7a0b9e9775c33cd27108d85","unresolved":false,"context_lines":[{"line_number":20,"context_line":"class NovaPluginVersion(test.NoDBTestCase):"},{"line_number":21,"context_line":"    def setUp(self):"},{"line_number":22,"context_line":"        super(NovaPluginVersion, self).setUp()"},{"line_number":23,"context_line":"        self.plugin \u003d plugins.load_plugin(\"nova_plugin_version\")"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_nova_plugin_version(self):"},{"line_number":26,"context_line":"        session \u003d \u0027fake_session\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_d6f30f09","line":23,"updated":"2016-02-26 12:38:02.000000000","message":"Add a comment above this line:\n# XAPI plugins run in a py24 environment and may not parse in a py34 environment, so prevent unit test scanning if imported using standard mechanisms\n\nShould not use \"self.plugin\" - it\u0027s too generic - instead use \"self.nova_plugin_version\" or \"self.ver_plugin\" similar.","commit_id":"8413c18bfdd0cd9ff3f71c5bd6fa6f8072ad2b59"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"800dba7922628938a9000f0b32e3b243f6dbb757","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class NovaPluginVersion(plugin_test.PluginTestBase):"},{"line_number":20,"context_line":"    def setUp(self):"},{"line_number":21,"context_line":"        super(NovaPluginVersion, self).setUp()"},{"line_number":22,"context_line":"        self.nova_plugin_version \u003d self.load_plugin(\"nova_plugin_version\")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_nova_plugin_version(self):"},{"line_number":25,"context_line":"        session \u003d \u0027fake_session\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_6e1f2d5b","line":22,"updated":"2016-03-01 10:28:09.000000000","message":"calling it here is py34 related, maybe a quick one line note saying why its in the setUp method?","commit_id":"e929b4ef7df3a7c4f472ff570093c44b88d78b4e"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"c296f29063749563c229a56e331d1fa31ee508ac","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class NovaPluginVersion(plugin_test.PluginTestBase):"},{"line_number":20,"context_line":"    def setUp(self):"},{"line_number":21,"context_line":"        super(NovaPluginVersion, self).setUp()"},{"line_number":22,"context_line":"        self.nova_plugin_version \u003d self.load_plugin(\"nova_plugin_version\")"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def test_nova_plugin_version(self):"},{"line_number":25,"context_line":"        session \u003d \u0027fake_session\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"7af24918_417c9420","line":22,"in_reply_to":"9aed3d3a_6e1f2d5b","updated":"2016-03-01 11:04:54.000000000","message":"See the response on the other comment. I will move the note to the place where load_plugin is defined so that we needn\u0027t add note on each plugin\u0027s test code.","commit_id":"e929b4ef7df3a7c4f472ff570093c44b88d78b4e"}],"tests-py3.txt":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"bcf8acebf9d41b37a7a0b9e9775c33cd27108d85","unresolved":false,"context_lines":[{"line_number":204,"context_line":"nova.tests.unit.virt.xenapi.test_vmops.BootableTestCase"},{"line_number":205,"context_line":"nova.tests.unit.virt.xenapi.test_vmops.SpawnTestCase"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"# These plugins to be verified run only with python2.4 on XenServer\u0027s Dom0,"},{"line_number":208,"context_line":"# so skip these unit tests."},{"line_number":209,"context_line":"nova.tests.unit.virt.xenapi.plugins"}],"source_content_type":"text/plain","patch_set":3,"id":"9aed3d3a_f63e13b7","line":207,"updated":"2016-02-26 12:38:02.000000000","message":"This could be confusing.  I would say:\n\"The XenAPI plugins run in a Python 2.4 environment, so avoid attempting to run their unit tests in a Python 3 environment.\"","commit_id":"8413c18bfdd0cd9ff3f71c5bd6fa6f8072ad2b59"}]}