)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9bcb309c1f74f3b195b6575576bad9699e1f3db6","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: make the opaque network attachment more robust"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure that the correct network ID is used when attaching the"},{"line_number":10,"context_line":"instance to the opaque network."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6bd615370075d44232d28f5ecebc34c08075daec"},{"line_number":13,"context_line":"Closes-bug: #1549288"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_75009566","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":31},"updated":"2016-03-10 14:27:49.000000000","message":"Could you provide more details about what\u0027s wrong with the code that was exposed in the bug and how this fixes it? I need some context.","commit_id":"e0c7f948e42d67c196ed45d3b2c2119a6bb76f2e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"9329d87c42657a8202f3b4017a8bc3aa8f02a11a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: make the opaque network attachment more robust"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure that the correct network ID is used when attaching the"},{"line_number":10,"context_line":"instance to the opaque network."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6bd615370075d44232d28f5ecebc34c08075daec"},{"line_number":13,"context_line":"Closes-bug: #1549288"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afc51ec_b2b92fec","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":31},"in_reply_to":"3afc51ec_0f03a043","updated":"2016-03-13 16:49:52.000000000","message":"If there are changes in a neutron plugin, then there is an upgrade impact to the change, right? Or are you going to be able to write the fix here for multiple versions of the neutron plugin so it can be compatible?","commit_id":"e0c7f948e42d67c196ed45d3b2c2119a6bb76f2e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ce3f4f72daa4d71f8fd5158b5b4ce0059e2d666c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: make the opaque network attachment more robust"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure that the correct network ID is used when attaching the"},{"line_number":10,"context_line":"instance to the opaque network."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6bd615370075d44232d28f5ecebc34c08075daec"},{"line_number":13,"context_line":"Closes-bug: #1549288"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5aef4532_9ce1f82c","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":31},"in_reply_to":"5aef4532_75009566","updated":"2016-03-10 19:16:54.000000000","message":"I was just chatting with Gary about this patch to understand this. \n\nI\u0027d update this commit message to say: \n\n\nThis patch changes the code to fetch the network_ref from VC rather than assuming the network.id is the same as the neutron network id.  In addition, this patch adds error checking to ensure that the network bridge is found on the hypervisor in the case that vif.type is OVS and not config.vmware.integration_bridge which was missing before. \n\n(^ all related to the changes in vif.py.)","commit_id":"e0c7f948e42d67c196ed45d3b2c2119a6bb76f2e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"4f7eb45f52ae67878b13ee55ae4f0704d50b6f29","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VMware: make the opaque network attachment more robust"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensure that the correct network ID is used when attaching the"},{"line_number":10,"context_line":"instance to the opaque network."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6bd615370075d44232d28f5ecebc34c08075daec"},{"line_number":13,"context_line":"Closes-bug: #1549288"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3afc51ec_0f03a043","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":31},"in_reply_to":"5aef4532_9ce1f82c","updated":"2016-03-13 16:10:20.000000000","message":"Thanks for the comments. I am thinking about taking a different approach here - that is, we can pass the NSX ID via the vif details. \nThis will require a change in the plugin which I am working on.","commit_id":"e0c7f948e42d67c196ed45d3b2c2119a6bb76f2e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d36a6978b533bdb1b4abc6c0e76ac0eca2cf630a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6bd615370075d44232d28f5ecebc34c08075daec"},{"line_number":13,"context_line":"Closes-bug: #1549288"},{"line_number":14,"context_line":"Depends-on: a10f7dca44f870c16ca71a9b84aade515a442b0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1af94dfe_1ff3e79f","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":52},"updated":"2016-03-15 19:46:59.000000000","message":"This is a commit hash, should be a Change-Id if you\u0027re using depends-on.\n\nAlso, does this change handle versions of the vmware-nsx plugin before that change?","commit_id":"7696e826ae31b27f228afb23c1211f4057213c9e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a9d4e77f0bcf499514269f60ce9d6cf22436a46a","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6bd615370075d44232d28f5ecebc34c08075daec"},{"line_number":13,"context_line":"Closes-bug: #1549288"},{"line_number":14,"context_line":"Depends-on: a10f7dca44f870c16ca71a9b84aade515a442b0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1af94dfe_1355894f","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":52},"in_reply_to":"1af94dfe_0291d0f0","updated":"2016-03-16 09:55:43.000000000","message":"Done","commit_id":"7696e826ae31b27f228afb23c1211f4057213c9e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"241a83e70bdbaa8b98c2fe855b5383eea90c5dd7","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6bd615370075d44232d28f5ecebc34c08075daec"},{"line_number":13,"context_line":"Closes-bug: #1549288"},{"line_number":14,"context_line":"Depends-on: a10f7dca44f870c16ca71a9b84aade515a442b0b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1af94dfe_0291d0f0","line":14,"range":{"start_line":14,"start_character":12,"end_line":14,"end_character":52},"in_reply_to":"1af94dfe_1ff3e79f","updated":"2016-03-15 20:05:42.000000000","message":"Should fix the Depends-On here, but I see that it\u0027s handling the backward compat case. But we should probably log if we\u0027re getting older vif details.","commit_id":"7696e826ae31b27f228afb23c1211f4057213c9e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ff3e489093864f4648ac94fd6b4cd45ac0e5921","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I6bd615370075d44232d28f5ecebc34c08075daec"},{"line_number":13,"context_line":"Closes-bug: #1549288"},{"line_number":14,"context_line":"Depends-on: Iea09105912f2a8d8766f02e71b45163e233a0eac"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"1af94dfe_5b533a39","line":14,"range":{"start_line":14,"start_character":8,"end_line":14,"end_character":10},"updated":"2016-03-18 00:34:08.000000000","message":"On\n\nThis needs to be Depends-On, that\u0027s what the CI checks for.","commit_id":"26db954a5d8b78753ec4059a3e727b742bf66c8c"}],"nova/tests/unit/virt/vmwareapi/test_vif.py":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"c8d42bdf06fe610cc9e4a43da48b1f6de8659ff7","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                network_model.VIF(type\u003dnetwork_model.VIF_TYPE_DVS,"},{"line_number":270,"context_line":"                                  address\u003d\u0027DE:AD:BE:EF:00:00\u0027,"},{"line_number":271,"context_line":"                                  network\u003dself._network)]"},{"line_number":272,"context_line":"        )[0]"},{"line_number":273,"context_line":"        self.assertRaises(exception.NetworkNotFoundForBridge,"},{"line_number":274,"context_line":"                          vif._get_neutron_network,"},{"line_number":275,"context_line":"                          \u0027fake-session\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_6462bbd9","line":272,"updated":"2016-03-01 06:30:10.000000000","message":"nit: can be moved to end of line 271","commit_id":"ad8793220fc02dbc6c49ea6a68dfbb663af53ef4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bfa0aeff1455beef97275350a1f4c70ed34d839f","unresolved":false,"context_lines":[{"line_number":269,"context_line":"                network_model.VIF(type\u003dnetwork_model.VIF_TYPE_DVS,"},{"line_number":270,"context_line":"                                  address\u003d\u0027DE:AD:BE:EF:00:00\u0027,"},{"line_number":271,"context_line":"                                  network\u003dself._network)]"},{"line_number":272,"context_line":"        )[0]"},{"line_number":273,"context_line":"        self.assertRaises(exception.NetworkNotFoundForBridge,"},{"line_number":274,"context_line":"                          vif._get_neutron_network,"},{"line_number":275,"context_line":"                          \u0027fake-session\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_9c3085ea","line":272,"in_reply_to":"9aed3d3a_6462bbd9","updated":"2016-03-02 06:08:07.000000000","message":"Done","commit_id":"ad8793220fc02dbc6c49ea6a68dfbb663af53ef4"}],"nova/virt/vmwareapi/network_util.py":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"2885c83987d31ecef66ff09dd0555ca70331017d","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _get_network_obj(session, network_objects, network_name):"},{"line_number":33,"context_line":"    \"\"\"Gets the network object for the requested network."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    The network object will be used when creating the VM configuration"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_44d25c5d","line":32,"updated":"2016-02-29 06:31:03.000000000","message":"this method can also take the network id and do the look up by netid if it is opaque network.","commit_id":"ad8793220fc02dbc6c49ea6a68dfbb663af53ef4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8686715937abd5e2d37dbc6ca628b958ddb520f6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def _get_network_obj(session, network_objects, network_name):"},{"line_number":33,"context_line":"    \"\"\"Gets the network object for the requested network."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    The network object will be used when creating the VM configuration"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_4c339eab","line":32,"in_reply_to":"9aed3d3a_44d25c5d","updated":"2016-02-29 11:53:16.000000000","message":"the network_name is actually the neutron network ID when using neutron.\nIn the case of nova network this is actually a name.\nSo that is a little confusing here. We should address that, but it is unrelated to this patch","commit_id":"ad8793220fc02dbc6c49ea6a68dfbb663af53ef4"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"c8d42bdf06fe610cc9e4a43da48b1f6de8659ff7","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                        return network_obj"},{"line_number":79,"context_line":"                elif network._type \u003d\u003d \u0027OpaqueNetwork\u0027:"},{"line_number":80,"context_line":"                    props \u003d session._call_method(vutil,"},{"line_number":81,"context_line":"                                                 \"get_object_property\","},{"line_number":82,"context_line":"                                                 network,"},{"line_number":83,"context_line":"                                                 \u0027summary\u0027)"},{"line_number":84,"context_line":"                    if network_name in props.name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_c4590737","line":81,"updated":"2016-03-01 06:30:10.000000000","message":"nit: using single quote similar quote to L83 for consistency","commit_id":"ad8793220fc02dbc6c49ea6a68dfbb663af53ef4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bfa0aeff1455beef97275350a1f4c70ed34d839f","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                        return network_obj"},{"line_number":79,"context_line":"                elif network._type \u003d\u003d \u0027OpaqueNetwork\u0027:"},{"line_number":80,"context_line":"                    props \u003d session._call_method(vutil,"},{"line_number":81,"context_line":"                                                 \"get_object_property\","},{"line_number":82,"context_line":"                                                 network,"},{"line_number":83,"context_line":"                                                 \u0027summary\u0027)"},{"line_number":84,"context_line":"                    if network_name in props.name:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_bc4c6171","line":81,"in_reply_to":"9aed3d3a_c4590737","updated":"2016-03-02 06:08:07.000000000","message":"Done","commit_id":"ad8793220fc02dbc6c49ea6a68dfbb663af53ef4"}],"nova/virt/vmwareapi/vif.py":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"2885c83987d31ecef66ff09dd0555ca70331017d","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":133,"context_line":"            name \u003d _get_opaque_network_name(vif[\u0027network\u0027][\u0027label\u0027],"},{"line_number":134,"context_line":"                                            net_id)"},{"line_number":135,"context_line":"            network_ref \u003d network_util.get_network_with_the_name("},{"line_number":136,"context_line":"                    session, name, cluster)"},{"line_number":137,"context_line":"            if not network_ref:"},{"line_number":138,"context_line":"                raise exception.NetworkNotFoundForBridge(bridge\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_64f680fa","line":135,"updated":"2016-02-29 06:31:03.000000000","message":"Instead of lookup by name it would be better to use \u0027opaqueNetworkId\u0027 attribute of dataobject OpaqueNetworkSummary i.e OpaqueNetworkSummary.summary.opaqueNetworkId","commit_id":"ad8793220fc02dbc6c49ea6a68dfbb663af53ef4"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"c8d42bdf06fe610cc9e4a43da48b1f6de8659ff7","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":133,"context_line":"            name \u003d _get_opaque_network_name(vif[\u0027network\u0027][\u0027label\u0027],"},{"line_number":134,"context_line":"                                            net_id)"},{"line_number":135,"context_line":"            network_ref \u003d network_util.get_network_with_the_name("},{"line_number":136,"context_line":"                    session, name, cluster)"},{"line_number":137,"context_line":"            if not network_ref:"},{"line_number":138,"context_line":"                raise exception.NetworkNotFoundForBridge(bridge\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_243ef3c0","line":135,"in_reply_to":"9aed3d3a_356bf686","updated":"2016-03-01 06:30:10.000000000","message":"Gary,\nare you saying OpaqueNetworkSummary.summary.opaqueNetworkId may refer to NSX ID and not neutron id?\nI thought the network id always is managed by neutron (in case of openstack).","commit_id":"ad8793220fc02dbc6c49ea6a68dfbb663af53ef4"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"8686715937abd5e2d37dbc6ca628b958ddb520f6","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":133,"context_line":"            name \u003d _get_opaque_network_name(vif[\u0027network\u0027][\u0027label\u0027],"},{"line_number":134,"context_line":"                                            net_id)"},{"line_number":135,"context_line":"            network_ref \u003d network_util.get_network_with_the_name("},{"line_number":136,"context_line":"                    session, name, cluster)"},{"line_number":137,"context_line":"            if not network_ref:"},{"line_number":138,"context_line":"                raise exception.NetworkNotFoundForBridge(bridge\u003dnet_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_356bf686","line":135,"in_reply_to":"9aed3d3a_64f680fa","updated":"2016-02-29 11:53:16.000000000","message":"Sadly we are unable to do this. The reason is that we do not know the actual NSX ID. We know the neutron one. When they are the same then it works. When they differ then we hit the bug that we have.","commit_id":"ad8793220fc02dbc6c49ea6a68dfbb663af53ef4"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ce3f4f72daa4d71f8fd5158b5b4ce0059e2d666c","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                           \u0027network-type\u0027: \u0027opaque\u0027,"},{"line_number":126,"context_line":"                           \u0027use-external-id\u0027: False}"},{"line_number":127,"context_line":"        else:"},{"line_number":128,"context_line":"            net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":129,"context_line":"            label \u003d vif[\u0027network\u0027][\u0027label\u0027]"},{"line_number":130,"context_line":"            name \u003d label + \u0027_\u0027 + net_id[:5] + \u0027...\u0027 + net_id[-5:]"},{"line_number":131,"context_line":"            network_ref \u003d network_util.get_network_with_the_name("}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_5cc2d085","line":128,"updated":"2016-03-10 19:16:54.000000000","message":"nit: I think it would be helpful to add: \n\n# if nsx-v3","commit_id":"e0c7f948e42d67c196ed45d3b2c2119a6bb76f2e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ce3f4f72daa4d71f8fd5158b5b4ce0059e2d666c","unresolved":false,"context_lines":[{"line_number":126,"context_line":"                           \u0027use-external-id\u0027: False}"},{"line_number":127,"context_line":"        else:"},{"line_number":128,"context_line":"            net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":129,"context_line":"            label \u003d vif[\u0027network\u0027][\u0027label\u0027]"},{"line_number":130,"context_line":"            name \u003d label + \u0027_\u0027 + net_id[:5] + \u0027...\u0027 + net_id[-5:]"},{"line_number":131,"context_line":"            network_ref \u003d network_util.get_network_with_the_name("},{"line_number":132,"context_line":"                    session, name, cluster)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5aef4532_5c701072","line":129,"updated":"2016-03-10 19:16:54.000000000","message":"i\u0027d also put a comment here that says: \n\nquery vc to find the network_ref for the giving network using the network name + network_id which is unique in the backend.  (or something like that).","commit_id":"e0c7f948e42d67c196ed45d3b2c2119a6bb76f2e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d36a6978b533bdb1b4abc6c0e76ac0eca2cf630a","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            # The NSX|V3 plugin will pass the logical-switch-id as part"},{"line_number":128,"context_line":"            # of the port details. This will enable the VC to connect to"},{"line_number":129,"context_line":"            # that specific opaque network"},{"line_number":130,"context_line":"            net_id \u003d (vif.get(\u0027details\u0027) and"},{"line_number":131,"context_line":"                      vif[\u0027details\u0027].get(\u0027logical-switch-id\u0027))"},{"line_number":132,"context_line":"            if not net_id:"},{"line_number":133,"context_line":"                # Make use of the original one, in the event that the"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_bfd8f3f0","line":130,"range":{"start_line":130,"start_character":31,"end_line":130,"end_character":38},"updated":"2016-03-15 19:46:59.000000000","message":"https://review.openstack.org/#/c/292408/1/vmware_nsx/plugins/nsx_v3/plugin.py@166 uses https://github.com/openstack/neutron/blob/master/neutron/extensions/portbindings.py#L26 which is \u0027binding:vif_details\u0027, not \u0027details\u0027 so this is wrong, right?","commit_id":"7696e826ae31b27f228afb23c1211f4057213c9e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"241a83e70bdbaa8b98c2fe855b5383eea90c5dd7","unresolved":false,"context_lines":[{"line_number":127,"context_line":"            # The NSX|V3 plugin will pass the logical-switch-id as part"},{"line_number":128,"context_line":"            # of the port details. This will enable the VC to connect to"},{"line_number":129,"context_line":"            # that specific opaque network"},{"line_number":130,"context_line":"            net_id \u003d (vif.get(\u0027details\u0027) and"},{"line_number":131,"context_line":"                      vif[\u0027details\u0027].get(\u0027logical-switch-id\u0027))"},{"line_number":132,"context_line":"            if not net_id:"},{"line_number":133,"context_line":"                # Make use of the original one, in the event that the"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_c2ffe832","line":130,"range":{"start_line":130,"start_character":31,"end_line":130,"end_character":38},"in_reply_to":"1af94dfe_bfd8f3f0","updated":"2016-03-15 20:05:42.000000000","message":"Oh nvm, I guess we translate here:\n\nhttps://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1739","commit_id":"7696e826ae31b27f228afb23c1211f4057213c9e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ef4ee72858795c32938e7246fad320411f560851","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            net_id \u003d (vif.get(\u0027details\u0027) and"},{"line_number":131,"context_line":"                      vif[\u0027details\u0027].get(\u0027logical-switch-id\u0027))"},{"line_number":132,"context_line":"            if not net_id:"},{"line_number":133,"context_line":"                # Make use of the original one, in the event that the"},{"line_number":134,"context_line":"                # plugin does not pass the aforementioned id"},{"line_number":135,"context_line":"                net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":136,"context_line":"            use_external_id \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_4a5c9425","line":133,"updated":"2016-03-15 18:17:52.000000000","message":"Nice, this makes it backward compatible","commit_id":"7696e826ae31b27f228afb23c1211f4057213c9e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d36a6978b533bdb1b4abc6c0e76ac0eca2cf630a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                      vif[\u0027details\u0027].get(\u0027logical-switch-id\u0027))"},{"line_number":132,"context_line":"            if not net_id:"},{"line_number":133,"context_line":"                # Make use of the original one, in the event that the"},{"line_number":134,"context_line":"                # plugin does not pass the aforementioned id"},{"line_number":135,"context_line":"                net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":136,"context_line":"            use_external_id \u003d True"},{"line_number":137,"context_line":"            network_type \u003d \u0027nsx.LogicalSwitch\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_3f6863f5","line":134,"range":{"start_line":134,"start_character":16,"end_line":134,"end_character":60},"updated":"2016-03-15 19:46:59.000000000","message":"If this is not robust, or is a problem, should you be logging something in this case? Like, hey, update your NSX plugin.","commit_id":"7696e826ae31b27f228afb23c1211f4057213c9e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a9d4e77f0bcf499514269f60ce9d6cf22436a46a","unresolved":false,"context_lines":[{"line_number":131,"context_line":"                      vif[\u0027details\u0027].get(\u0027logical-switch-id\u0027))"},{"line_number":132,"context_line":"            if not net_id:"},{"line_number":133,"context_line":"                # Make use of the original one, in the event that the"},{"line_number":134,"context_line":"                # plugin does not pass the aforementioned id"},{"line_number":135,"context_line":"                net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"},{"line_number":136,"context_line":"            use_external_id \u003d True"},{"line_number":137,"context_line":"            network_type \u003d \u0027nsx.LogicalSwitch\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"1af94dfe_b38815e9","line":134,"range":{"start_line":134,"start_character":16,"end_line":134,"end_character":60},"in_reply_to":"1af94dfe_3f6863f5","updated":"2016-03-16 09:55:43.000000000","message":"Done","commit_id":"7696e826ae31b27f228afb23c1211f4057213c9e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"aa3891979345f8b06ddc20091016be8d087faf64","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            if not net_id:"},{"line_number":133,"context_line":"                # Make use of the original one, in the event that the"},{"line_number":134,"context_line":"                # plugin does not pass the aforementioned id"},{"line_number":135,"context_line":"                LOG.warning(_LW(\u0027NSX Logical switch ID is not present. \u0027"},{"line_number":136,"context_line":"                                \u0027Using network ID to attach to the \u0027"},{"line_number":137,"context_line":"                                \u0027opaque network.\u0027))"},{"line_number":138,"context_line":"                net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_4a228201","line":135,"updated":"2016-03-17 02:18:45.000000000","message":"I\u0027m wondering if we even need to log this as warning because this is expected. Maybe we should drop this to info.","commit_id":"26db954a5d8b78753ec4059a3e727b742bf66c8c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1ff3e489093864f4648ac94fd6b4cd45ac0e5921","unresolved":false,"context_lines":[{"line_number":132,"context_line":"            if not net_id:"},{"line_number":133,"context_line":"                # Make use of the original one, in the event that the"},{"line_number":134,"context_line":"                # plugin does not pass the aforementioned id"},{"line_number":135,"context_line":"                LOG.warning(_LW(\u0027NSX Logical switch ID is not present. \u0027"},{"line_number":136,"context_line":"                                \u0027Using network ID to attach to the \u0027"},{"line_number":137,"context_line":"                                \u0027opaque network.\u0027))"},{"line_number":138,"context_line":"                net_id \u003d vif[\u0027network\u0027][\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"1af94dfe_1b0b722b","line":135,"in_reply_to":"1af94dfe_4a228201","updated":"2016-03-18 00:34:08.000000000","message":"Agree, this should probably be INFO, unless there is really a problem when you hit this and if there is, you should probably add something to the warning (if you keep it a warning) that you need to update the neutron vmware nsx plugin.","commit_id":"26db954a5d8b78753ec4059a3e727b742bf66c8c"}]}