)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1782,"name":"Kravchenko Pavel","email":"kpavel@il.ibm.com","username":"kravchenko-pavel"},"change_message_id":"9031c43ba8119d38e5316b142a3858d533d694f5","unresolved":false,"context_lines":[{"line_number":3499,"context_line":"                if os.path.exists(tmp_path):"},{"line_number":3500,"context_line":"                    same_host \u003d True"},{"line_number":3501,"context_line":"                    os.unlink(tmp_path)"},{"line_number":3502,"context_line":"                else:"},{"line_number":3503,"context_line":"                    utils.execute(\u0027ssh\u0027, dest, \u0027rm\u0027, tmp_path)"},{"line_number":3504,"context_line":"            except Exception:"},{"line_number":3505,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2FcwQ%3D","line":3502,"updated":"2013-05-09 08:27:18.000000000","message":"Correct me if I\u0027m wrong, but I\u0027m not sure it\u0027s guaranteed that on each compute host the CONF.instances_path points to same location. I think it depends on nova.conf property. If it\u0027s correct, its not guaranteed that you really check the correct dest host instance location.","commit_id":"5c285a4fb36fea38385d2d9f921bee51fd631fe6"},{"author":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"change_message_id":"cb123cc1bdef5833a74a52ae56923b5c4ad27379","unresolved":false,"context_lines":[{"line_number":3499,"context_line":"                if os.path.exists(tmp_path):"},{"line_number":3500,"context_line":"                    same_host \u003d True"},{"line_number":3501,"context_line":"                    os.unlink(tmp_path)"},{"line_number":3502,"context_line":"                else:"},{"line_number":3503,"context_line":"                    utils.execute(\u0027ssh\u0027, dest, \u0027rm\u0027, tmp_path)"},{"line_number":3504,"context_line":"            except Exception:"},{"line_number":3505,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Fb3s%3D","line":3502,"in_reply_to":"AAAAOn%2F%2FcwQ%3D","updated":"2013-05-09 18:39:31.000000000","message":"Completely valid point which has implications beyond this check.  It actually means that migrations won\u0027t work at all if the instance_path is different across source/dest.\n\nIn essence, you\u0027ve pointed out another bigger problem with this entire implementation. My patch isn\u0027t making it worse, it\u0027s resolving a bug with the current bad implementation. To resolve all the issues the entire migrate function needs to be redone.","commit_id":"5c285a4fb36fea38385d2d9f921bee51fd631fe6"}]}