)]}'
{"nova/tests/functional/api_sample_tests/test_server_migrations.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"510311f67582bcf50cd3a55118abdf8ddad20e90","unresolved":false,"context_lines":[{"line_number":163,"context_line":"class ServerMigrationsSampleJsonTestV2_24(test_servers.ServersSampleBase):"},{"line_number":164,"context_line":"    ADMIN_API \u003d True"},{"line_number":165,"context_line":"    extension_name \u003d \"server-migrations\""},{"line_number":166,"context_line":"    scenarios \u003d [(\u0027v2_24\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":167,"context_line":"    extra_extensions_to_load \u003d [\"os-migrate-server\", \"os-access-ips\"]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_34680f87","line":166,"range":{"start_line":166,"start_character":4,"end_line":166,"end_character":58},"updated":"2016-02-29 14:31:18.000000000","message":"Seems we should add \u0027microversion\u0027: \u00272.24\u0027 to the tuple here so we get the self.microversion attribute which we could re-use in setUp like in the other tests, but it\u0027s not a must-have.","commit_id":"771b92b2c6090e0134ec30f5961be86f7dab093e"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"b190a19c2eecc09dae23588b926e9d40d090f6c5","unresolved":false,"context_lines":[{"line_number":163,"context_line":"class ServerMigrationsSampleJsonTestV2_24(test_servers.ServersSampleBase):"},{"line_number":164,"context_line":"    ADMIN_API \u003d True"},{"line_number":165,"context_line":"    extension_name \u003d \"server-migrations\""},{"line_number":166,"context_line":"    scenarios \u003d [(\u0027v2_24\u0027, {\u0027api_major_version\u0027: \u0027v2.1\u0027})]"},{"line_number":167,"context_line":"    extra_extensions_to_load \u003d [\"os-migrate-server\", \"os-access-ips\"]"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_37e927e7","line":166,"range":{"start_line":166,"start_character":4,"end_line":166,"end_character":58},"in_reply_to":"9aed3d3a_34680f87","updated":"2016-02-29 16:57:43.000000000","message":"Yeah, 2.22 does it the same way, but 2.23 does it correctly. Any test that uses \u0027self.microversion\u0027 will not work correctly, although \u0027self.api.microversion\u0027 will.","commit_id":"771b92b2c6090e0134ec30f5961be86f7dab093e"}],"nova/tests/functional/test_server_group.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5957f94cb32ac73984dfe25b63a21593d0ffab2b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from nova.tests import fixtures as nova_fixtures"},{"line_number":23,"context_line":"from nova.tests.functional.api import client"},{"line_number":24,"context_line":"from nova.tests.functional import api_paste_fixture"},{"line_number":25,"context_line":"from nova.tests.unit import cast_as_call"},{"line_number":26,"context_line":"from nova.tests.unit import fake_network"},{"line_number":27,"context_line":"from nova.tests.unit import policy_fixture"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bae84128_fa38e93f","line":25,"updated":"2016-02-24 19:12:13.000000000","message":"This isn\u0027t used.","commit_id":"ce47c18d7d8eead7ecbdabf0bc70e371c7ed2124"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1d87b2cb8db474733ac41072b6080878166916f4","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        # nova considers the host down"},{"line_number":687,"context_line":"        time.sleep(self._service_down_time)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        post \u003d {\u0027evacuate\u0027: {\u0027onSharedStorage\u0027: False}}"},{"line_number":690,"context_line":"        self.admin_api.post_server_action(servers[1][\u0027id\u0027], post)"},{"line_number":691,"context_line":"        evacuated_server \u003d self._wait_for_state_change(servers[1], \u0027ACTIVE\u0027)"},{"line_number":692,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bae84128_0cebd4b1","side":"PARENT","line":689,"updated":"2016-02-24 21:57:01.000000000","message":"Why the change here?","commit_id":"dbe8c9354dcbf9711ca449603554659c678541c5"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ce5e3d27b2c3e43f1605116820814a21748ed7b1","unresolved":false,"context_lines":[{"line_number":686,"context_line":"        # nova considers the host down"},{"line_number":687,"context_line":"        time.sleep(self._service_down_time)"},{"line_number":688,"context_line":""},{"line_number":689,"context_line":"        post \u003d {\u0027evacuate\u0027: {\u0027onSharedStorage\u0027: False}}"},{"line_number":690,"context_line":"        self.admin_api.post_server_action(servers[1][\u0027id\u0027], post)"},{"line_number":691,"context_line":"        evacuated_server \u003d self._wait_for_state_change(servers[1], \u0027ACTIVE\u0027)"},{"line_number":692,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_8b5fd00d","side":"PARENT","line":689,"in_reply_to":"bae84128_0cebd4b1","updated":"2016-02-25 19:09:38.000000000","message":"Because 2.14 removed that as a parameter, so sending it on 2.15 causes a 400.","commit_id":"dbe8c9354dcbf9711ca449603554659c678541c5"}]}