)]}'
{"nova/tests/test_powervm.py":[{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"7184d8c6e97d980d73489b576cf4fbdaa2befb4f","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                       fake_migrate_disk)"},{"line_number":524,"context_line":"        self.stubs.Set(fake_op, \u0027set_lpar_mac_base_value\u0027,"},{"line_number":525,"context_line":"                       fake_set_lpar_mac_base_value)"},{"line_number":526,"context_line":"        self.powervm_connection.migrate_disk_and_power_off("},{"line_number":527,"context_line":"                        context, instance,"},{"line_number":528,"context_line":"                        dest, instance_type, network_info, block_device_info)"},{"line_number":529,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Ffz4%3D","line":526,"updated":"2013-05-07 20:17:13.000000000","message":"nit: don\u0027t think these were really necessary changes...","commit_id":"f1f897f39971a519204ccb89ee71fba140019a16"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"7184d8c6e97d980d73489b576cf4fbdaa2befb4f","unresolved":false,"context_lines":[{"line_number":557,"context_line":"                       fake_run_vios_command)"},{"line_number":558,"context_line":""},{"line_number":559,"context_line":"        blockdev_op \u003d self.powervm_connection._powervm._disk_adapter"},{"line_number":560,"context_line":"        blockdev_op.migrate_volume(lv_name, src_host, dest,"},{"line_number":561,"context_line":"                                   image_path)"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":"    def test_get_resize_name(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2Ffz0%3D","line":560,"updated":"2013-05-07 20:17:13.000000000","message":"nit: don\u0027t think these were really necessary changes...","commit_id":"f1f897f39971a519204ccb89ee71fba140019a16"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"bb3ed1e5d12afe537f0f0e43fab30cc0937860ba","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012, 2013 IBM Corp."},{"line_number":4,"context_line":"# All Rights Reserved."},{"line_number":5,"context_line":"#"},{"line_number":6,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":7,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2Fb4Q%3D","line":4,"updated":"2013-05-09 18:36:08.000000000","message":"\"All Rights Reserved\" is probably not necessary ... we should at least be consistent, and it\u0027s not used in most places.  Can you just remove this?","commit_id":"2a51fb14cfc84b8bda78a932fbc0efab326c8e95"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"f3a65880c42146058c64b244bf6473d9a3574ddc","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                       fake_migrate_disk)"},{"line_number":523,"context_line":"        self.stubs.Set(fake_op, \u0027set_lpar_mac_base_value\u0027,"},{"line_number":524,"context_line":"                       fake_set_lpar_mac_base_value)"},{"line_number":525,"context_line":"        self.powervm_connection.migrate_disk_and_power_off("},{"line_number":526,"context_line":"                        context, instance,"},{"line_number":527,"context_line":"                        dest, instance_type, network_info, block_device_info)"},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FdZE%3D","line":525,"updated":"2013-05-08 22:58:12.000000000","message":"Still not sure why you are changing these other test cases...","commit_id":"2a51fb14cfc84b8bda78a932fbc0efab326c8e95"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"82c683384b53c0c9afef55ba4d71d7692da67379","unresolved":false,"context_lines":[{"line_number":522,"context_line":"                       fake_migrate_disk)"},{"line_number":523,"context_line":"        self.stubs.Set(fake_op, \u0027set_lpar_mac_base_value\u0027,"},{"line_number":524,"context_line":"                       fake_set_lpar_mac_base_value)"},{"line_number":525,"context_line":"        self.powervm_connection.migrate_disk_and_power_off("},{"line_number":526,"context_line":"                        context, instance,"},{"line_number":527,"context_line":"                        dest, instance_type, network_info, block_device_info)"},{"line_number":528,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FdMs%3D","line":525,"in_reply_to":"AAAAOn%2F%2FdZE%3D","updated":"2013-05-09 01:12:00.000000000","message":"I was getting a warning about an unused variable in the code, so I just removed it.  Guess it didn\u0027t need to be changed, I just cleaned it up while I was in here.  Could have done the same for the unused test class that\u0027s in this module also.","commit_id":"2a51fb14cfc84b8bda78a932fbc0efab326c8e95"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"f3a65880c42146058c64b244bf6473d9a3574ddc","unresolved":false,"context_lines":[{"line_number":658,"context_line":"    def test_check_connection_raise_ssh_exception(self):"},{"line_number":659,"context_line":"        \"\"\""},{"line_number":660,"context_line":"        Passes an ssh object to the check_connection method which"},{"line_number":661,"context_line":"        has a dead transport."},{"line_number":662,"context_line":"        The method should raise an SSHException."},{"line_number":663,"context_line":"        \"\"\""},{"line_number":664,"context_line":"        self.stubs.Set(common, \u0027ssh_connect\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FdZA%3D","line":661,"updated":"2013-05-08 22:58:12.000000000","message":"I don\u0027t think this test description is entirely accurate, but it\u0027s still pretty obvious what the test is doing when you look at it.","commit_id":"2a51fb14cfc84b8bda78a932fbc0efab326c8e95"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"82c683384b53c0c9afef55ba4d71d7692da67379","unresolved":false,"context_lines":[{"line_number":658,"context_line":"    def test_check_connection_raise_ssh_exception(self):"},{"line_number":659,"context_line":"        \"\"\""},{"line_number":660,"context_line":"        Passes an ssh object to the check_connection method which"},{"line_number":661,"context_line":"        has a dead transport."},{"line_number":662,"context_line":"        The method should raise an SSHException."},{"line_number":663,"context_line":"        \"\"\""},{"line_number":664,"context_line":"        self.stubs.Set(common, \u0027ssh_connect\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2FdMY%3D","line":661,"in_reply_to":"AAAAOn%2F%2FdZA%3D","updated":"2013-05-09 01:12:00.000000000","message":"Yeah, should be null transport rather than dead in the wording I guess (or would I get flak for using the term \u0027null\u0027 in python? Still new to me).  Still, I don\u0027t plan on pushing up another change set to change that wording unless there are objections.","commit_id":"2a51fb14cfc84b8bda78a932fbc0efab326c8e95"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"b3bce24b91377907f431422a383c20fa13990abc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"from nova.virt.powervm import exception"},{"line_number":40,"context_line":"from nova.virt.powervm import lpar"},{"line_number":41,"context_line":"from nova.virt.powervm import operator as powervm_operator"},{"line_number":42,"context_line":"from nova.virt.powervm import common as powervm_common"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"def fake_lpar(instance_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOn%2F%2Fb0Q%3D","line":42,"updated":"2013-05-09 19:01:11.000000000","message":"so now you\u0027re importing this twice?  as common and powervm_common?\n\npep8 is probably going to complain about this, too","commit_id":"56efc4b1ee1080e7f28245284fc1b2a643d3028f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"a0d60d751b6f1c871c220d5ae97de57bc08aac5f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012, 2013 IBM Corp."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FbOk%3D","line":3,"updated":"2013-05-09 23:19:38.000000000","message":"One date please. See all. the. other. code. As I said in IRC, it should be:\n\n Copyright 2013 IBM Corp.\n\nand nothing else.","commit_id":"196639e7eeafbdd877d04aaf8343f2e231338eec"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e31710d4cfacb5185ff8d3c6da9ba4dc944560eb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2012, 2013 IBM Corp."},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAOn%2F%2FaV4%3D","line":3,"in_reply_to":"AAAAOn%2F%2FbOk%3D","updated":"2013-05-10 14:07:56.000000000","message":"Done","commit_id":"196639e7eeafbdd877d04aaf8343f2e231338eec"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"330c1dd34a0662d5011f574aa8fe76d7d7f2f479","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        # actually connect to anything for these tests"},{"line_number":630,"context_line":"        self.connection \u003d common.Connection(\u0027fake_host\u0027,"},{"line_number":631,"context_line":"                                                    \u0027user\u0027,"},{"line_number":632,"context_line":"                                                    \u0027password\u0027)"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"    def test_check_connection_ssh_is_none(self):"},{"line_number":635,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FaHc%3D","line":632,"updated":"2013-05-10 15:46:30.000000000","message":"Alignment here is incorrect.","commit_id":"1b47171f45686f6834008f834cd1a37e0f73cd34"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"80d8be4526ceb6e20cd21d583054657de6fb211b","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        # actually connect to anything for these tests"},{"line_number":630,"context_line":"        self.connection \u003d common.Connection(\u0027fake_host\u0027,"},{"line_number":631,"context_line":"                                                    \u0027user\u0027,"},{"line_number":632,"context_line":"                                                    \u0027password\u0027)"},{"line_number":633,"context_line":""},{"line_number":634,"context_line":"    def test_check_connection_ssh_is_none(self):"},{"line_number":635,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAOn%2F%2FZ70%3D","line":632,"in_reply_to":"AAAAOn%2F%2FaHc%3D","updated":"2013-05-10 17:41:59.000000000","message":"Done","commit_id":"1b47171f45686f6834008f834cd1a37e0f73cd34"}],"nova/virt/powervm/common.py":[{"author":{"_account_id":4601,"name":"Tiago Mello","email":"tmello@linux.vnet.ibm.com","username":"tmello"},"change_message_id":"2658a3c0c4b3964967a005413feacce80353d5e1","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            transport \u003d ssh.get_transport()"},{"line_number":89,"context_line":"            # if we have a dead connection"},{"line_number":90,"context_line":"            # build a new one and return"},{"line_number":91,"context_line":"            if (not transport) or (not transport.is_active()):"},{"line_number":92,"context_line":"                ssh \u003d ssh_connect(connection)"},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            # try to make a connection still"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff6Q%3D","line":91,"updated":"2013-05-07 19:14:47.000000000","message":"Nit: the parentheses seem optional here, isn\u0027t it?","commit_id":"acc775ac3af7496f07d02267e56c536a693f93ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"52b20eaba861e4f73576ae59d528c066160cc9dc","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            transport \u003d ssh.get_transport()"},{"line_number":89,"context_line":"            # if we have a dead connection"},{"line_number":90,"context_line":"            # build a new one and return"},{"line_number":91,"context_line":"            if (not transport) or (not transport.is_active()):"},{"line_number":92,"context_line":"                ssh \u003d ssh_connect(connection)"},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            # try to make a connection still"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff5Q%3D","line":91,"in_reply_to":"AAAAOn%2F%2Ff6Q%3D","updated":"2013-05-07 19:33:00.000000000","message":"Yeah, could be cleaned up if needed.","commit_id":"acc775ac3af7496f07d02267e56c536a693f93ae"},{"author":{"_account_id":4601,"name":"Tiago Mello","email":"tmello@linux.vnet.ibm.com","username":"tmello"},"change_message_id":"2658a3c0c4b3964967a005413feacce80353d5e1","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                ssh \u003d ssh_connect(connection)"},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            # try to make a connection still"},{"line_number":95,"context_line":"            ssh \u003d ssh_connect(connection)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    return ssh"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff58%3D","line":95,"updated":"2013-05-07 19:14:47.000000000","message":"What happen if the ssh_connect fails?","commit_id":"acc775ac3af7496f07d02267e56c536a693f93ae"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"52b20eaba861e4f73576ae59d528c066160cc9dc","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                ssh \u003d ssh_connect(connection)"},{"line_number":93,"context_line":"        except Exception:"},{"line_number":94,"context_line":"            # try to make a connection still"},{"line_number":95,"context_line":"            ssh \u003d ssh_connect(connection)"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    return ssh"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Ff4o%3D","line":95,"in_reply_to":"AAAAOn%2F%2Ff58%3D","updated":"2013-05-07 19:33:00.000000000","message":"The SSHException from Paramiko is raised up to the caller and they need to handle it, which would be the same as if nova.utils.ssh_execute threw the SSHException.","commit_id":"acc775ac3af7496f07d02267e56c536a693f93ae"},{"author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"change_message_id":"ad7ca14d7df1c45e9f91f03d11c023db1c46ea72","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    :raises: PowerVMConnectionFailed -- if the ssh connection fails."},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":"    # if the ssh client is not set or the transport is dead, re-connect"},{"line_number":84,"context_line":"    if (not ssh or"},{"line_number":85,"context_line":"        not ssh.get_transport() or"},{"line_number":86,"context_line":"        not ssh.get_transport().is_active()):"},{"line_number":87,"context_line":"        LOG.debug(\"Connection to host %s will be established.\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Ff2I%3D","line":84,"updated":"2013-05-07 19:56:14.000000000","message":"you should probably check \u0027ssh is None\u0027 instead of relying on boolean type casting","commit_id":"83331a8cee075a096dc10ec5869d852043e990a1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2e0edf9191f8f4a92da817003202a53bcc859ae0","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    :raises: PowerVMConnectionFailed -- if the ssh connection fails."},{"line_number":82,"context_line":"    \"\"\""},{"line_number":83,"context_line":"    # if the ssh client is not set or the transport is dead, re-connect"},{"line_number":84,"context_line":"    if (not ssh or"},{"line_number":85,"context_line":"        not ssh.get_transport() or"},{"line_number":86,"context_line":"        not ssh.get_transport().is_active()):"},{"line_number":87,"context_line":"        LOG.debug(\"Connection to host %s will be established.\" %"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOn%2F%2Ff0Y%3D","line":84,"in_reply_to":"AAAAOn%2F%2Ff2I%3D","updated":"2013-05-07 20:08:31.000000000","message":"Done","commit_id":"83331a8cee075a096dc10ec5869d852043e990a1"}]}