)]}'
{"nova/cells/rpcapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8da8e7bfd36d09dc1f3c7ae1c09c2ec93506ff01","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        ... Liberty supports message version 1.37.  So, any changes to"},{"line_number":118,"context_line":"        existing methods in 1.x after that point should be done such that they"},{"line_number":119,"context_line":"        can handle the version_cap being set to 1.37."},{"line_number":120,"context_line":"    \u0027\u0027\u0027"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_3a0ec334","line":119,"updated":"2016-02-25 22:26:39.000000000","message":"Should probably update the version here and in the manager:\n\nhttps://github.com/openstack/nova/blob/master/nova/cells/manager.py#L64","commit_id":"e6d060c33a1b2d8b27b6071eb3792e56e5a12ce3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4c6ffbb7580a9b833194bbbfad9458e7abfd32ba","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        ... Liberty supports message version 1.37.  So, any changes to"},{"line_number":118,"context_line":"        existing methods in 1.x after that point should be done such that they"},{"line_number":119,"context_line":"        can handle the version_cap being set to 1.37."},{"line_number":120,"context_line":"    \u0027\u0027\u0027"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_c5bedcfe","line":119,"in_reply_to":"9aed3d3a_3a0ec334","updated":"2016-02-25 22:52:40.000000000","message":"So, as explained in the commit msg, I don\u0027t want to touch the RPC API, just the interface for making sure we wouldn\u0027t have an AttributeError when using live-migrate with Cells V1 (that our CI misses)\n\nPassing down the object is not really needed, that just means that cells v1 operators wouldn\u0027t have the possibility to get the original Spec - so it would still use the previous behaviour when it hydrates the spec in the conductor.","commit_id":"e6d060c33a1b2d8b27b6071eb3792e56e5a12ce3"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"58579f588c2b9a02b82e4bf01b95cf0105fab78d","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        ... Liberty supports message version 1.37.  So, any changes to"},{"line_number":118,"context_line":"        existing methods in 1.x after that point should be done such that they"},{"line_number":119,"context_line":"        can handle the version_cap being set to 1.37."},{"line_number":120,"context_line":"    \u0027\u0027\u0027"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_73885fe8","line":119,"in_reply_to":"9aed3d3a_45264c69","updated":"2016-02-26 09:56:03.000000000","message":"Yeah, lets bump the version for safety, it gives us a hook, should we need it.","commit_id":"e6d060c33a1b2d8b27b6071eb3792e56e5a12ce3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"17a104efe1299ebfa138b8d1fd4e81167df5b0ab","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        ... Liberty supports message version 1.37.  So, any changes to"},{"line_number":118,"context_line":"        existing methods in 1.x after that point should be done such that they"},{"line_number":119,"context_line":"        can handle the version_cap being set to 1.37."},{"line_number":120,"context_line":"    \u0027\u0027\u0027"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"9aed3d3a_45264c69","line":119,"in_reply_to":"9aed3d3a_c5bedcfe","updated":"2016-02-25 22:55:46.000000000","message":"So I can see why we\u0027re not going to pass down the request spec, but I don\u0027t get why bumping the version matters, it\u0027s purely just signaling the change in case we needed to sort something out later.\n\nIf we aren\u0027t going to do that, we should probably put a note in the methods themselves that we are intentionally not passing the request_spec down b/c $reason.","commit_id":"e6d060c33a1b2d8b27b6071eb3792e56e5a12ce3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a3f56de142259c731018d20110a20d4180cacd02","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        * 1.38 - Same behaviour as in 1.37, but blocking explicitly the"},{"line_number":122,"context_line":"                 RequestSpec object to be passed down to the wire for"},{"line_number":123,"context_line":"                 live_migrate_instance() and rebuild()"},{"line_number":124,"context_line":"    \u0027\u0027\u0027"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_f47b4726","line":123,"range":{"start_line":123,"start_character":45,"end_line":123,"end_character":52},"updated":"2016-02-29 14:35:43.000000000","message":"rebuild_instance()","commit_id":"067936dd27187812b272c5c4fcc219d58f8f489e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"546c5df471b1b565b0b7d0c52dbb634afcc0ad66","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        * 1.38 - Same behaviour as in 1.37, but blocking explicitly the"},{"line_number":122,"context_line":"                 RequestSpec object to be passed down to the wire for"},{"line_number":123,"context_line":"                 live_migrate_instance() and rebuild()"},{"line_number":124,"context_line":"    \u0027\u0027\u0027"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_afae8a95","line":123,"range":{"start_line":123,"start_character":45,"end_line":123,"end_character":52},"in_reply_to":"9aed3d3a_f47b4726","updated":"2016-02-29 14:45:57.000000000","message":"Raaaaah, Atom autocompletion \u003d\u003e [trashbin]","commit_id":"067936dd27187812b272c5c4fcc219d58f8f489e"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"8a6d220e3ca918fad743559a56ddd9be97440e70","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        * 1.38 - Same behaviour as in 1.37, but blocking explicitly the"},{"line_number":122,"context_line":"                 RequestSpec object to be passed down to the wire for"},{"line_number":123,"context_line":"                 live_migrate_instance() and rebuild_instance()"},{"line_number":124,"context_line":"    \u0027\u0027\u0027"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    VERSION_ALIASES \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"9aed3d3a_bf31935c","line":123,"updated":"2016-02-29 15:55:18.000000000","message":"not sure on the wording here, but I don\u0027t have any better suggestions really.","commit_id":"3afe898200854d6a8efdaa2c3ac643e714d99246"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c74ed590d428290023f4ff15b799d2d72e95288c","unresolved":false,"context_lines":[{"line_number":573,"context_line":"    def live_migrate_instance(self, ctxt, instance, host_name,"},{"line_number":574,"context_line":"                              block_migration, disk_over_commit,"},{"line_number":575,"context_line":"                              request_spec\u003dNone):"},{"line_number":576,"context_line":"        # NOTE(sbauza): Since Cells v1 is quite feature-freeze, we don\u0027t want"},{"line_number":577,"context_line":"        # to pass down request_spec to the manager and rather keep the"},{"line_number":578,"context_line":"        # cell conductor providing a new RequestSpec like the original"},{"line_number":579,"context_line":"        # behaviour"}],"source_content_type":"text/x-python","patch_set":5,"id":"9aed3d3a_fa4b1285","line":576,"range":{"start_line":576,"start_character":42,"end_line":576,"end_character":62},"updated":"2016-02-29 22:45:37.000000000","message":"nit: feature frozen\n\nbut I get what you mean.","commit_id":"9ab6840af64d6af58baf51040afe86a3324221e5"}],"nova/tests/unit/cells/test_cells_rpcapi.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a3f56de142259c731018d20110a20d4180cacd02","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        call_info \u003d self._stub_rpc_method(\u0027cast\u0027, None)"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        self.cells_rpcapi.rebuild_instance(self.fake_context,"},{"line_number":705,"context_line":"                                                \u0027fake-instance\u0027,"},{"line_number":706,"context_line":"                                                \u0027fake-pass\u0027,"},{"line_number":707,"context_line":"                                                \u0027fake-files\u0027,"},{"line_number":708,"context_line":"                                                \u0027fake-image_ref\u0027,"},{"line_number":709,"context_line":"                                                \u0027fake-orig_image_ref\u0027,"},{"line_number":710,"context_line":"                                                \u0027fake-orig_sys_metadata\u0027,"},{"line_number":711,"context_line":"                                                \u0027fake-bdms\u0027,"},{"line_number":712,"context_line":"                                                recreate\u003dFalse,"},{"line_number":713,"context_line":"                                                on_shared_storage\u003dFalse,"},{"line_number":714,"context_line":"                                                host\u003dNone,"},{"line_number":715,"context_line":"                                                preserve_ephemeral\u003dFalse,"},{"line_number":716,"context_line":"                                                request_spec\u003d\u0027fake-spec\u0027,"},{"line_number":717,"context_line":"                                                kwargs\u003dNone)"},{"line_number":718,"context_line":"        expected_args \u003d {\u0027instance\u0027: \u0027fake-instance\u0027,"},{"line_number":719,"context_line":"                         \u0027image_href\u0027: \u0027fake-image_ref\u0027,"},{"line_number":720,"context_line":"                         \u0027admin_password\u0027: \u0027fake-pass\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_94063b84","line":717,"range":{"start_line":705,"start_character":48,"end_line":717,"end_character":60},"updated":"2016-02-29 14:35:43.000000000","message":"nit: could we fix the alignment here so these are lined up with self.fake_context *or* rather than stacking them just wrap them into fewer lines?","commit_id":"067936dd27187812b272c5c4fcc219d58f8f489e"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"546c5df471b1b565b0b7d0c52dbb634afcc0ad66","unresolved":false,"context_lines":[{"line_number":702,"context_line":"        call_info \u003d self._stub_rpc_method(\u0027cast\u0027, None)"},{"line_number":703,"context_line":""},{"line_number":704,"context_line":"        self.cells_rpcapi.rebuild_instance(self.fake_context,"},{"line_number":705,"context_line":"                                                \u0027fake-instance\u0027,"},{"line_number":706,"context_line":"                                                \u0027fake-pass\u0027,"},{"line_number":707,"context_line":"                                                \u0027fake-files\u0027,"},{"line_number":708,"context_line":"                                                \u0027fake-image_ref\u0027,"},{"line_number":709,"context_line":"                                                \u0027fake-orig_image_ref\u0027,"},{"line_number":710,"context_line":"                                                \u0027fake-orig_sys_metadata\u0027,"},{"line_number":711,"context_line":"                                                \u0027fake-bdms\u0027,"},{"line_number":712,"context_line":"                                                recreate\u003dFalse,"},{"line_number":713,"context_line":"                                                on_shared_storage\u003dFalse,"},{"line_number":714,"context_line":"                                                host\u003dNone,"},{"line_number":715,"context_line":"                                                preserve_ephemeral\u003dFalse,"},{"line_number":716,"context_line":"                                                request_spec\u003d\u0027fake-spec\u0027,"},{"line_number":717,"context_line":"                                                kwargs\u003dNone)"},{"line_number":718,"context_line":"        expected_args \u003d {\u0027instance\u0027: \u0027fake-instance\u0027,"},{"line_number":719,"context_line":"                         \u0027image_href\u0027: \u0027fake-image_ref\u0027,"},{"line_number":720,"context_line":"                         \u0027admin_password\u0027: \u0027fake-pass\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9aed3d3a_8f8aa619","line":717,"range":{"start_line":705,"start_character":48,"end_line":717,"end_character":60},"in_reply_to":"9aed3d3a_94063b84","updated":"2016-02-29 14:45:57.000000000","message":"Sure","commit_id":"067936dd27187812b272c5c4fcc219d58f8f489e"}]}