)]}'
{"nova/virt/hardware.py":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"d4f1b7fe2004e535f5f3db22b08dc4272f3fc87a","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    else:"},{"line_number":832,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":833,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":834,"context_line":"            LOG.debug(\"Host does not have hyperthreading or hyperthreading \""},{"line_number":835,"context_line":"                      \"is disabled, but \u0027require\u0027 threads policy was \""},{"line_number":836,"context_line":"                      \"requested.\")"},{"line_number":837,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_9c880873","line":834,"range":{"start_line":834,"start_character":41,"end_line":834,"end_character":42},"updated":"2016-05-10 16:55:38.000000000","message":"Nit:\n\ns/have/support/","commit_id":"c1c45a34d486175fe36be134772898fc59f0ba3e"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"618bc8652912374b02c45073fea1882c4ba9d950","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    else:"},{"line_number":832,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":833,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":834,"context_line":"            LOG.debug(\"Host does not have hyperthreading or hyperthreading \""},{"line_number":835,"context_line":"                      \"is disabled, but \u0027require\u0027 threads policy was \""},{"line_number":836,"context_line":"                      \"requested.\")"},{"line_number":837,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_a8c4065f","line":834,"range":{"start_line":834,"start_character":16,"end_line":834,"end_character":21},"updated":"2016-05-08 16:11:53.000000000","message":"shouldn\u0027t this be a warning?","commit_id":"c1c45a34d486175fe36be134772898fc59f0ba3e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5be9ec2f3c38586705fec589a121df50eecec526","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    else:"},{"line_number":832,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":833,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":834,"context_line":"            LOG.debug(\"Host does not have hyperthreading or hyperthreading \""},{"line_number":835,"context_line":"                      \"is disabled, but \u0027require\u0027 threads policy was \""},{"line_number":836,"context_line":"                      \"requested.\")"},{"line_number":837,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_1043fd6d","line":834,"range":{"start_line":834,"start_character":41,"end_line":834,"end_character":42},"in_reply_to":"dab17558_9c880873","updated":"2016-05-12 10:03:11.000000000","message":"Done","commit_id":"c1c45a34d486175fe36be134772898fc59f0ba3e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"019140707a874f350ecaf6a394c44dea5b2b9338","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    else:"},{"line_number":832,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":833,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":834,"context_line":"            LOG.debug(\"Host does not have hyperthreading or hyperthreading \""},{"line_number":835,"context_line":"                      \"is disabled, but \u0027require\u0027 threads policy was \""},{"line_number":836,"context_line":"                      \"requested.\")"},{"line_number":837,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"dab17558_5626cfce","line":834,"range":{"start_line":834,"start_character":16,"end_line":834,"end_character":21},"in_reply_to":"dab17558_a8c4065f","updated":"2016-05-09 11:23:40.000000000","message":"It probably should, yes. I\u0027ll raise it","commit_id":"c1c45a34d486175fe36be134772898fc59f0ba3e"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"eca9016ba00637b08f10f2e727555704ed6e319b","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    else:"},{"line_number":832,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":833,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":834,"context_line":"            LOG.warning(\"Host does not support hyperthreading or \""},{"line_number":835,"context_line":"                        \"hyperthreading is disabled, but \u0027require\u0027 threads \""},{"line_number":836,"context_line":"                        \"policy was requested.\")"},{"line_number":837,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_c15a2e50","line":834,"range":{"start_line":834,"start_character":12,"end_line":834,"end_character":23},"updated":"2016-05-12 17:46:24.000000000","message":"you are failing on pep8 messages require translations `_LW()`","commit_id":"e077274272d09b313ab0d8e7f8c1b7e0ce3eddb7"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"003f31116b0cbfcba353a8cae5824e73fe6af216","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    else:"},{"line_number":832,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":833,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":834,"context_line":"            LOG.warning(\"Host does not support hyperthreading or \""},{"line_number":835,"context_line":"                        \"hyperthreading is disabled, but \u0027require\u0027 threads \""},{"line_number":836,"context_line":"                        \"policy was requested.\")"},{"line_number":837,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":3,"id":"bab6814e_7bb6d6f9","line":834,"range":{"start_line":834,"start_character":12,"end_line":834,"end_character":23},"in_reply_to":"dab17558_c15a2e50","updated":"2016-05-23 10:07:19.000000000","message":"Done","commit_id":"e077274272d09b313ab0d8e7f8c1b7e0ce3eddb7"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"bc0d895daebb029b2827132647dbbee3f74d9812","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    else:"},{"line_number":832,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":833,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":834,"context_line":"            LOG.warning(_LW(\"Host does not support hyperthreading or \""},{"line_number":835,"context_line":"                            \"hyperthreading is disabled, but \u0027require\u0027 \""},{"line_number":836,"context_line":"                            \"threads policy was requested.\"))"},{"line_number":837,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"dada55a8_af0eab2f","line":834,"updated":"2016-07-25 20:14:09.000000000","message":"Agreed with @sahid on this one. Warning level is reserved for things that the cloud administrator should take action on. This isn\u0027t one of those cases. INFO level is appropriate I think here.","commit_id":"14cb4479f6e4cfa89721b5041aec6b4c16f9cb44"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e04cc834568b184a009f134881fb61531c45bec3","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    else:"},{"line_number":832,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":833,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":834,"context_line":"            LOG.warning(_LW(\"Host does not support hyperthreading or \""},{"line_number":835,"context_line":"                            \"hyperthreading is disabled, but \u0027require\u0027 \""},{"line_number":836,"context_line":"                            \"threads policy was requested.\"))"},{"line_number":837,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"7aa08908_c2c5320b","line":834,"updated":"2016-06-09 11:11:51.000000000","message":"Yes it\u0027s nice to make the compute to handle such case but not sure we want a warning here, there is no error, the host can\u0027t just support the request. That request will return to the schedule to an other try. I\u0027d recommend an info","commit_id":"14cb4479f6e4cfa89721b5041aec6b4c16f9cb44"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"0cf36a9a84ab27c143f9510840a66671fea46a68","unresolved":false,"context_lines":[{"line_number":831,"context_line":"    else:"},{"line_number":832,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":833,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":834,"context_line":"            LOG.warning(_LW(\"Host does not support hyperthreading or \""},{"line_number":835,"context_line":"                            \"hyperthreading is disabled, but \u0027require\u0027 \""},{"line_number":836,"context_line":"                            \"threads policy was requested.\"))"},{"line_number":837,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_f898981d","line":834,"in_reply_to":"7aa08908_c2c5320b","updated":"2016-08-09 12:31:24.000000000","message":"Done","commit_id":"14cb4479f6e4cfa89721b5041aec6b4c16f9cb44"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"d096644461d5d4d9b18e3aee4006e40b649d0e14","unresolved":false,"context_lines":[{"line_number":844,"context_line":"    else:"},{"line_number":845,"context_line":"        if (instance_cell.cpu_thread_policy \u003d\u003d"},{"line_number":846,"context_line":"                fields.CPUThreadAllocationPolicy.REQUIRE):"},{"line_number":847,"context_line":"            LOG.info(_LW(\"Host does not support hyperthreading or \""},{"line_number":848,"context_line":"                         \"hyperthreading is disabled, but \u0027require\u0027 \""},{"line_number":849,"context_line":"                         \"threads policy was requested.\"))"},{"line_number":850,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_8f1e5e61","line":847,"range":{"start_line":847,"start_character":22,"end_line":847,"end_character":24},"updated":"2016-08-09 18:16:22.000000000","message":"This should be LI now.","commit_id":"c72facc0b923de8cd52eba57e7d923412a3e6876"}]}