)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"92060bafcab4ee00d3f0e51f0ef98799d196e8dd","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api_version_request.matches does not accept a string or None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to devref/api_microversion_dev.rst, you should be able"},{"line_number":10,"context_line":"to use the following pattern:"},{"line_number":11,"context_line":"    req_version \u003d req.api_version_request"},{"line_number":12,"context_line":"    if req_version.matches(\"2.1\", \"2.5\"):"},{"line_number":13,"context_line":"        ....stuff...."},{"line_number":14,"context_line":"    elif req_version.matches(\"2.6\", \"2.10\"):"},{"line_number":15,"context_line":"        ....other stuff...."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"However, the api_version_request.matches() function will not accept a"},{"line_number":18,"context_line":"string, it requires an api_version_request object."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7af24918_d33a0c36","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":27},"updated":"2016-03-01 22:44:30.000000000","message":"Now all 3 callers of this method(matches) specify an instance of APIVersionRequest(). So this doc seems old and we need to fix the doc instead of changing the implementation code.","commit_id":"dcb6350ae08f8fa6da0436cd71de17c2b7e5e06a"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"11eca96333be7cbfc5b1ed6cbae70476457b2bfc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"api_version_request.matches does not accept a string or None"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to devref/api_microversion_dev.rst, you should be able"},{"line_number":10,"context_line":"to use the following pattern:"},{"line_number":11,"context_line":"    req_version \u003d req.api_version_request"},{"line_number":12,"context_line":"    if req_version.matches(\"2.1\", \"2.5\"):"},{"line_number":13,"context_line":"        ....stuff...."},{"line_number":14,"context_line":"    elif req_version.matches(\"2.6\", \"2.10\"):"},{"line_number":15,"context_line":"        ....other stuff...."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"However, the api_version_request.matches() function will not accept a"},{"line_number":18,"context_line":"string, it requires an api_version_request object."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7af24918_c485f959","line":15,"range":{"start_line":9,"start_character":0,"end_line":15,"end_character":27},"in_reply_to":"7af24918_d33a0c36","updated":"2016-03-02 13:38:36.000000000","message":"That is fine, if you do not wish to allow this pattern in the future.\nI\u0027ll submit a patch with a change to the doc.","commit_id":"dcb6350ae08f8fa6da0436cd71de17c2b7e5e06a"}]}
