)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"41b6a161045c6abba16299f7c805734ef6b358da","unresolved":false,"context_lines":[{"line_number":1911,"context_line":""},{"line_number":1912,"context_line":"@require_context"},{"line_number":1913,"context_line":"def instance_floating_address_get_all(context, instance_uuid):"},{"line_number":1914,"context_line":"    if not uuidutils.is_uuid_like(instance_uuid):"},{"line_number":1915,"context_line":"        raise exception.InvalidUUID(uuid\u003dinstance_uuid)"},{"line_number":1916,"context_line":""},{"line_number":1917,"context_line":"    fixed_ip_ids \u003d model_query(context, models.FixedIp.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FVW4%3D","line":1914,"updated":"2013-05-14 11:12:18.000000000","message":"is this the right place for this check? i think this should be done on the nova api side","commit_id":"ac9cc15164f0afcac4b3320bcd58d36c00f3232c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"8ba1c75f6370b914754f70664d7a308dd1e4296e","unresolved":false,"context_lines":[{"line_number":1911,"context_line":""},{"line_number":1912,"context_line":"@require_context"},{"line_number":1913,"context_line":"def instance_floating_address_get_all(context, instance_uuid):"},{"line_number":1914,"context_line":"    if not uuidutils.is_uuid_like(instance_uuid):"},{"line_number":1915,"context_line":"        raise exception.InvalidUUID(uuid\u003dinstance_uuid)"},{"line_number":1916,"context_line":""},{"line_number":1917,"context_line":"    fixed_ip_ids \u003d model_query(context, models.FixedIp.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FVWM%3D","line":1914,"in_reply_to":"AAAAOn%2F%2FVW4%3D","updated":"2013-05-14 11:18:07.000000000","message":"Hi garyk, this check was in fixed_ip_get_by_instance. Not sure about right place for this check.  So I would prefer to avoid refactoring it in this patch.","commit_id":"ac9cc15164f0afcac4b3320bcd58d36c00f3232c"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"1f225d80e3546fa710a28a81c6e85e057a07c7d8","unresolved":false,"context_lines":[{"line_number":1911,"context_line":""},{"line_number":1912,"context_line":"@require_context"},{"line_number":1913,"context_line":"def instance_floating_address_get_all(context, instance_uuid):"},{"line_number":1914,"context_line":"    if not uuidutils.is_uuid_like(instance_uuid):"},{"line_number":1915,"context_line":"        raise exception.InvalidUUID(uuid\u003dinstance_uuid)"},{"line_number":1916,"context_line":""},{"line_number":1917,"context_line":"    fixed_ip_ids \u003d model_query(context, models.FixedIp.id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FVSA%3D","line":1914,"in_reply_to":"AAAAOn%2F%2FVWM%3D","updated":"2013-05-14 12:10:21.000000000","message":"It does make sense that it should be validated higher up the stack.  I believe its use in the db layer is mostly for historical reasons.  The move from ids to uuids was gradual, so the db layer had to figure out what it was given and act appropriately.","commit_id":"ac9cc15164f0afcac4b3320bcd58d36c00f3232c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"dad53e8ffedcedd17664479051b2ca6bbb25ec64","unresolved":false,"context_lines":[{"line_number":1919,"context_line":"                        filter_by(instance_uuid\u003dinstance_uuid).\\"},{"line_number":1920,"context_line":"                        all()"},{"line_number":1921,"context_line":"    if not fixed_ip_ids:"},{"line_number":1922,"context_line":"        raise exception.FixedIpNotFoundForInstance(instance_uuid\u003dinstance_uuid)"},{"line_number":1923,"context_line":""},{"line_number":1924,"context_line":"    fixed_ip_ids \u003d [fixed_ip_id.id for fixed_ip_id in fixed_ip_ids]"},{"line_number":1925,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FXck%3D","line":1922,"updated":"2013-05-13 15:01:36.000000000","message":"nit: if it\u0027s acceptable to omit raising of this exception (as there is no such case in the original code), you could actually use even a bit more effective query: don\u0027t call all() on line 1919 and pass this query as a subquery directly into filter() on line 1928.","commit_id":"ac9cc15164f0afcac4b3320bcd58d36c00f3232c"},{"author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"change_message_id":"ae214b7130df32a6869c8dd95af37095a21ffb32","unresolved":false,"context_lines":[{"line_number":1919,"context_line":"                        filter_by(instance_uuid\u003dinstance_uuid).\\"},{"line_number":1920,"context_line":"                        all()"},{"line_number":1921,"context_line":"    if not fixed_ip_ids:"},{"line_number":1922,"context_line":"        raise exception.FixedIpNotFoundForInstance(instance_uuid\u003dinstance_uuid)"},{"line_number":1923,"context_line":""},{"line_number":1924,"context_line":"    fixed_ip_ids \u003d [fixed_ip_id.id for fixed_ip_id in fixed_ip_ids]"},{"line_number":1925,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FXV8%3D","line":1922,"in_reply_to":"AAAAOn%2F%2FXck%3D","updated":"2013-05-13 15:15:25.000000000","message":"This exception was raised in fixed_ip_get_by_instance method..\n\nSo we should call .all() and should raise this exception, to avoid  changes in behavior.","commit_id":"ac9cc15164f0afcac4b3320bcd58d36c00f3232c"}]}