)]}'
{"id":"openstack%2Fnova~28546","triplet_id":"openstack%2Fnova~master~Id3c515de0ca35707bbfe46b991c2d7cf591e431b","project":"openstack/nova","branch":"master","topic":"floating_ips_cleanup","hashtags":[],"change_id":"Id3c515de0ca35707bbfe46b991c2d7cf591e431b","subject":"Optimize db.instance_floating_address_get_all method","status":"MERGED","created":"2013-05-08 13:17:15.000000000","updated":"2013-05-15 10:43:05.000000000","submitted":"2013-05-15 10:43:02.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":5,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"1b814cc5dced0829239c0b30a0f22d2a86ab3b20","_number":28546,"virtual_id_number":28546,"owner":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2013-05-09 02:09:09.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},{"value":2,"date":"2013-05-15 10:43:02.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"date":"2013-05-13 15:15:25.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":2,"date":"2013-05-15 09:50:32.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":2,"date":"2013-05-14 12:10:21.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":1,"date":"2013-05-09 17:54:11.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"date":"2013-05-14 11:12:18.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2013-05-13 15:01:36.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":1,"date":"2013-05-15 09:50:32.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"date":"2013-05-14 12:10:21.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-05-09 02:09:09.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-05-09 17:54:11.000000000","updated_by":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"reviewer":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"state":"REVIEWER"},{"updated":"2013-05-13 15:01:36.000000000","updated_by":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"reviewer":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"state":"REVIEWER"},{"updated":"2013-05-14 11:12:18.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-05-14 12:10:21.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-05-15 09:50:32.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-05-15 10:43:02.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"ad4a6b0fd565403970334f750e89aefc7f488d1a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-08 14:03:11.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/28546/1/check/gate-nova-pep8/25512 : SUCCESS in 00:03:19\n- http://docs-draft.openstack.org/28546/1/check/gate-nova-docs/19730/doc/build/html/ : SUCCESS in 00:02:33\n- http://logs.openstack.org/28546/1/check/gate-nova-python26/21138 : SUCCESS in 00:18:56\n- http://logs.openstack.org/28546/1/check/gate-nova-python26-centos6/337 : SUCCESS in 00:12:09 (non-voting)\n- http://logs.openstack.org/28546/1/check/gate-nova-python27/21226 : SUCCESS in 00:08:32\n- http://logs.openstack.org/28546/1/check/gate-tempest-devstack-vm-full/15011 : SUCCESS in 00:44:35\n- http://logs.openstack.org/28546/1/check/gate-tempest-devstack-vm-postgres-full/14726 : FAILURE in 00:45:27 (non-voting)\n- http://logs.openstack.org/28546/1/check/gate-tempest-devstack-vm-quantum/21246 : SUCCESS in 00:20:37\n- http://logs.openstack.org/28546/1/check/gate-grenade-devstack-vm/2766 : SUCCESS in 00:14:38 (non-voting)\n- http://logs.openstack.org/28546/1/check/gate-nova-pylint/11223 : SUCCESS in 00:08:39 (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"4de63200d4c0ec2e31abd652c55ceae5e92a1394","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-05-09 02:09:09.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 18) Running: http://smokestack.openstack.org/?go\u003d/jobs/85882\n","accounts_in_message":[],"_revision_number":1},{"id":"d8c66cfb5ff4aee5431ea9e9e0ecbad5918602a4","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-05-09 17:54:11.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"dad53e8ffedcedd17664479051b2ca6bbb25ec64","author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"date":"2013-05-13 15:01:36.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"ae214b7130df32a6869c8dd95af37095a21ffb32","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2013-05-13 15:15:25.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"41b6a161045c6abba16299f7c805734ef6b358da","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-05-14 11:12:18.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"8ba1c75f6370b914754f70664d7a308dd1e4296e","author":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"date":"2013-05-14 11:18:07.000000000","message":"Patch Set 1: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1f225d80e3546fa710a28a81c6e85e057a07c7d8","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-05-14 12:10:21.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"9614e84e187bbde63c2f65941cb37aafcc0ad3be","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-05-15 09:50:32.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"0b02db71b3b3cefefe604b054e1ffed2c372978e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-15 09:50:40.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"82b4dcdff77738e9e39c4742fc43be0ee1ac5036","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-15 10:43:02.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://docs-draft.openstack.org/28546/1/gate/gate-nova-docs/20117/doc/build/html/ : SUCCESS in 3m 58s\n- http://logs.openstack.org/28546/1/gate/gate-nova-pep8/25899 : SUCCESS in 4m 17s\n- http://logs.openstack.org/28546/1/gate/gate-nova-python26/21523 : SUCCESS in 14m 10s\n- http://logs.openstack.org/28546/1/gate/gate-nova-python27/21613 : SUCCESS in 10m 05s\n- http://logs.openstack.org/28546/1/gate/gate-tempest-devstack-vm-full/16040 : SUCCESS in 51m 08s\n- http://logs.openstack.org/28546/1/gate/gate-tempest-devstack-vm-postgres-full/15756 : FAILURE in 52m 03s (non-voting)\n- http://logs.openstack.org/28546/1/gate/gate-tempest-devstack-vm-quantum/22521 : SUCCESS in 21m 15s\n- http://logs.openstack.org/28546/1/gate/gate-grenade-devstack-vm/3673 : FAILURE in 11m 46s (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"9cc949c1f49dc1608de8c5eb4cfcb5754177ff97","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-05-15 10:43:05.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"ac9cc15164f0afcac4b3320bcd58d36c00f3232c","revisions":{"ac9cc15164f0afcac4b3320bcd58d36c00f3232c":{"kind":"REWORK","_number":1,"created":"2013-05-08 13:17:15.000000000","uploader":{"_account_id":6172,"name":"Boris Pavlovic","email":"boris@pavlovic.me","username":"boris-42"},"ref":"refs/changes/46/28546/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/46/28546/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/46/28546/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/46/28546/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/46/28546/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/46/28546/1"}}},"commit":{"parents":[{"commit":"2e35d7177830e16abd3e919510437f48c6691d51","subject":"Session cleanup for db.floating_ip_* methods","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2e35d7177830e16abd3e919510437f48c6691d51"}]}],"author":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2013-05-08 12:25:46.000000000","tz":240},"committer":{"name":"Boris Pavlovic","email":"boris@pavlovic.me","date":"2013-05-08 13:16:46.000000000","tz":240},"subject":"Optimize db.instance_floating_address_get_all method","message":"Optimize db.instance_floating_address_get_all method\n\nOptimize db.instance_floating_address_get_all\nWas:\nGet FixedIps with corresponding instance_uuid\nFor each FixedIp get associated FloatIp (N request)\nNow:\nGet only list of FixedIps ids\nGet all corresponding FloatingIp with one query (select in)\nGet only addresses from FloatingIps (because we are using only it)\n\nAdd temporary test for db.instance_floating_address_get_all to\nensure that it works as expected.\n\nChange-Id: Id3c515de0ca35707bbfe46b991c2d7cf591e431b\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ac9cc15164f0afcac4b3320bcd58d36c00f3232c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ac9cc15164f0afcac4b3320bcd58d36c00f3232c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2e35d7177830e16abd3e919510437f48c6691d51","is_merged_in_target_branch":true,"change_id":"Ifdf9edb17746a8e5b486317c917ea69016a2b99d","change_number":28235,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}