)]}'
{"nova/tests/servicegroup/test_zk_driver.py":[{"author":{"_account_id":2998,"name":"Alexander Pugachev","email":"apugache@yahoo-inc.com","username":"apugachev"},"change_message_id":"cb4506729c943622d1647a12ff080d876a282600","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.flags(servicegroup_driver\u003d\u0027zk\u0027)"},{"line_number":41,"context_line":"        self.flags(address\u003d\u0027localhost:2181\u0027, group\u003d\"zookeeper\")"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            _unused \u003d zk.ZooKeeperDriver()"},{"line_number":44,"context_line":"        except ImportError:"},{"line_number":45,"context_line":"            self.skipTest(\"Unable to test due to lack of ZooKeeper\")"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FehY%3D","line":43,"updated":"2013-05-08 14:54:23.000000000","message":"This does not test proposed change.\nYou\u0027ll have this test skipped if someone made mistake in imported module name.","commit_id":"4a2845095c0e35336c60836050ca11c71898fb8c"},{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"612c8761ae6508b36651cd6677e05e133a80b9bd","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.flags(servicegroup_driver\u003d\u0027zk\u0027)"},{"line_number":41,"context_line":"        self.flags(address\u003d\u0027localhost:2181\u0027, group\u003d\"zookeeper\")"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            _unused \u003d zk.ZooKeeperDriver()"},{"line_number":44,"context_line":"        except ImportError:"},{"line_number":45,"context_line":"            self.skipTest(\"Unable to test due to lack of ZooKeeper\")"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbhI%3D","line":43,"in_reply_to":"AAAAOn%2F%2FecQ%3D","updated":"2013-05-09 21:42:47.000000000","message":"not sure if it\u0027s too late since it\u0027s already approved. but if we try to \"import zookeeper\" instead of instantiating the driver, at least it wouldn\u0027t pass the test on a machine that should have the driver properly installed.","commit_id":"4a2845095c0e35336c60836050ca11c71898fb8c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"54852cf1b1d6ad09b8c810e4b7e147015e18b990","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.flags(servicegroup_driver\u003d\u0027zk\u0027)"},{"line_number":41,"context_line":"        self.flags(address\u003d\u0027localhost:2181\u0027, group\u003d\"zookeeper\")"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            _unused \u003d zk.ZooKeeperDriver()"},{"line_number":44,"context_line":"        except ImportError:"},{"line_number":45,"context_line":"            self.skipTest(\"Unable to test due to lack of ZooKeeper\")"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FecQ%3D","line":43,"in_reply_to":"AAAAOn%2F%2Fee0%3D","updated":"2013-05-08 15:21:52.000000000","message":"Yep.","commit_id":"4a2845095c0e35336c60836050ca11c71898fb8c"},{"author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"change_message_id":"756a12a785ddac185988ebcbdbd1f66e97a7b2d6","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.flags(servicegroup_driver\u003d\u0027zk\u0027)"},{"line_number":41,"context_line":"        self.flags(address\u003d\u0027localhost:2181\u0027, group\u003d\"zookeeper\")"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            _unused \u003d zk.ZooKeeperDriver()"},{"line_number":44,"context_line":"        except ImportError:"},{"line_number":45,"context_line":"            self.skipTest(\"Unable to test due to lack of ZooKeeper\")"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2Fee0%3D","line":43,"in_reply_to":"AAAAOn%2F%2FehY%3D","updated":"2013-05-08 15:10:20.000000000","message":"Wouldn\u0027t it be impossible to run these tests if there was a mistake?","commit_id":"4a2845095c0e35336c60836050ca11c71898fb8c"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"22d6ef981af47527db1867ca6726dff07ccc73f0","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.flags(servicegroup_driver\u003d\u0027zk\u0027)"},{"line_number":41,"context_line":"        self.flags(address\u003d\u0027localhost:2181\u0027, group\u003d\"zookeeper\")"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            _unused \u003d zk.ZooKeeperDriver()"},{"line_number":44,"context_line":"        except ImportError:"},{"line_number":45,"context_line":"            self.skipTest(\"Unable to test due to lack of ZooKeeper\")"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FefU%3D","line":43,"in_reply_to":"AAAAOn%2F%2FehY%3D","updated":"2013-05-08 15:09:58.000000000","message":"You are correct, but it will also skip if those modules are not installed on the system which is why it\u0027s done like this.\n\nSince this is an optional driver and module, I could not come up with a test strategy that would ensure that the imported module names were correct, without hardcoding those names in the test.  How do you skip if it\u0027s not loaded but fail if it is?  How do you know the difference?\n\nAlso, note that I\u0027m fixing existing tests.  I\u0027m not trying to test my change due to the difficulty of doing so.","commit_id":"4a2845095c0e35336c60836050ca11c71898fb8c"}]}