)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"345bb3025131014ace586af972654ac84586fef5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Query procceeding status migration in confirm/revert_resize()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds procceeding status while query migration objects while"},{"line_number":10,"context_line":"doing confirm/revert resize, by doing this we can re-issue this"},{"line_number":11,"context_line":"confirm/revert operation in case of rpc message is missed after casting"},{"line_number":12,"context_line":"to compute node."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_9fa46008","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":27},"updated":"2016-03-10 13:43:31.000000000","message":"proceeding","commit_id":"a5a2f0162c3b04dcaa53fb517c7aaaf83828ba51"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"8255ec6831bbebf4a5573cbdf0610b3805f8e220","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Query procceeding status migration in confirm/revert_resize()"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds procceeding status while query migration objects while"},{"line_number":10,"context_line":"doing confirm/revert resize, by doing this we can re-issue this"},{"line_number":11,"context_line":"confirm/revert operation in case of rpc message is missed after casting"},{"line_number":12,"context_line":"to compute node."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5aef4532_af33c612","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":27},"in_reply_to":"5aef4532_9fa46008","updated":"2016-03-11 02:28:21.000000000","message":"Done","commit_id":"a5a2f0162c3b04dcaa53fb517c7aaaf83828ba51"}],"nova/compute/api.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"5a0e68861d658e383adcc89e1170bd40c1093e82","unresolved":false,"context_lines":[{"line_number":2505,"context_line":"        migration \u003d None"},{"line_number":2506,"context_line":"        for status in (\u0027finished\u0027, \u0027reverting\u0027):"},{"line_number":2507,"context_line":"            try:"},{"line_number":2508,"context_line":"                migration \u003d objects.Migration.get_by_instance_and_status("},{"line_number":2509,"context_line":"                    elevated, instance.uuid, status)"},{"line_number":2510,"context_line":"                break"},{"line_number":2511,"context_line":"            except exception.MigrationNotFoundByStatus:"},{"line_number":2512,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_9797b78f","line":2509,"range":{"start_line":2508,"start_character":16,"end_line":2509,"end_character":52},"updated":"2016-03-08 11:19:20.000000000","message":"Can we use single db call instead of two? This isn\u0027t effective.","commit_id":"f2319f3213b27fbd95cf1e560dccab7fe886fc27"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"3ee972d0356133f6fcb96c0d035899bbcdf773e5","unresolved":false,"context_lines":[{"line_number":2505,"context_line":"        migration \u003d None"},{"line_number":2506,"context_line":"        for status in (\u0027finished\u0027, \u0027reverting\u0027):"},{"line_number":2507,"context_line":"            try:"},{"line_number":2508,"context_line":"                migration \u003d objects.Migration.get_by_instance_and_status("},{"line_number":2509,"context_line":"                    elevated, instance.uuid, status)"},{"line_number":2510,"context_line":"                break"},{"line_number":2511,"context_line":"            except exception.MigrationNotFoundByStatus:"},{"line_number":2512,"context_line":"                pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_0755101c","line":2509,"range":{"start_line":2508,"start_character":16,"end_line":2509,"end_character":52},"in_reply_to":"5aef4532_9797b78f","updated":"2016-03-09 01:17:50.000000000","message":"hi Alex, I am not sure how can I make use of one single db call in this case.\n\nget_by_instance_and_status only accept one status not a list of status. \n\nI see that _confirm_resize_on_deleting is doing this. https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1707","commit_id":"f2319f3213b27fbd95cf1e560dccab7fe886fc27"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"082a4b4c00e938a64a6df17904c20700cb117cb0","unresolved":false,"context_lines":[{"line_number":2512,"context_line":"                pass"},{"line_number":2513,"context_line":""},{"line_number":2514,"context_line":"        if migration is None:"},{"line_number":2515,"context_line":"            raise exception.MigrationNotFoundByStatus("},{"line_number":2516,"context_line":"                instance_id\u003dinstance.uuid, status\u003d\u0027reverting\u0027)"},{"line_number":2517,"context_line":""},{"line_number":2518,"context_line":"        # reverse quota reservation for increased resource usage"},{"line_number":2519,"context_line":"        deltas \u003d compute_utils.reverse_upsize_quota_delta(context, migration)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_701007a9","line":2516,"range":{"start_line":2515,"start_character":11,"end_line":2516,"end_character":62},"updated":"2016-03-09 06:35:18.000000000","message":"little bit concern about this one, since we are checking for two status, maybe there could be some better ways for the exception?","commit_id":"f2319f3213b27fbd95cf1e560dccab7fe886fc27"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7e216ded31c0912e2f1e3d4ea2fd3f5aaa405eba","unresolved":false,"context_lines":[{"line_number":2553,"context_line":"            }"},{"line_number":2554,"context_line":"            migrations \u003d objects.MigrationList.get_by_filters(elevated,"},{"line_number":2555,"context_line":"                                                              filters)"},{"line_number":2556,"context_line":"            # migrations may not be found for finished or reverting, but it"},{"line_number":2557,"context_line":"            # could not be more than 2 migrations at same time."},{"line_number":2558,"context_line":"            if len(migrations) \u003c 1:"},{"line_number":2559,"context_line":"                raise exception.MigrationNotFoundByStatus("}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_1f4b305a","line":2556,"range":{"start_line":2556,"start_character":58,"end_line":2556,"end_character":67},"updated":"2016-03-10 13:42:58.000000000","message":"confiming?","commit_id":"a5a2f0162c3b04dcaa53fb517c7aaaf83828ba51"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"8255ec6831bbebf4a5573cbdf0610b3805f8e220","unresolved":false,"context_lines":[{"line_number":2553,"context_line":"            }"},{"line_number":2554,"context_line":"            migrations \u003d objects.MigrationList.get_by_filters(elevated,"},{"line_number":2555,"context_line":"                                                              filters)"},{"line_number":2556,"context_line":"            # migrations may not be found for finished or reverting, but it"},{"line_number":2557,"context_line":"            # could not be more than 2 migrations at same time."},{"line_number":2558,"context_line":"            if len(migrations) \u003c 1:"},{"line_number":2559,"context_line":"                raise exception.MigrationNotFoundByStatus("}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_af1aa67a","line":2556,"range":{"start_line":2556,"start_character":58,"end_line":2556,"end_character":67},"in_reply_to":"5aef4532_1f4b305a","updated":"2016-03-11 02:28:21.000000000","message":"Done","commit_id":"a5a2f0162c3b04dcaa53fb517c7aaaf83828ba51"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"1b6184a1cf052b1bdac30a62e82f051fbb8e523f","unresolved":false,"context_lines":[{"line_number":2555,"context_line":"                                                              filters)"},{"line_number":2556,"context_line":"            # migrations may not be found for finished or reverting, but it"},{"line_number":2557,"context_line":"            # could not be more than 2 migrations at same time."},{"line_number":2558,"context_line":"            if len(migrations) \u003c 1:"},{"line_number":2559,"context_line":"                raise exception.MigrationNotFoundByStatus("},{"line_number":2560,"context_line":"                    instance_id\u003dinstance.uuid,"},{"line_number":2561,"context_line":"                    status\u003d\u0027finished or confirming\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_5215af99","line":2558,"range":{"start_line":2558,"start_character":33,"end_line":2558,"end_character":34},"updated":"2016-03-10 14:08:43.000000000","message":"just a question, we only create a migraiton object when resize action, if it\u0027s already in resize state, further resize action will rejected\nwhich scenario can we generate 2 migrations?","commit_id":"a5a2f0162c3b04dcaa53fb517c7aaaf83828ba51"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"8ab3ce35020a091d036dacc00980f6b67400623d","unresolved":false,"context_lines":[{"line_number":2555,"context_line":"                                                              filters)"},{"line_number":2556,"context_line":"            # migrations may not be found for finished or reverting, but it"},{"line_number":2557,"context_line":"            # could not be more than 2 migrations at same time."},{"line_number":2558,"context_line":"            if len(migrations) \u003c 1:"},{"line_number":2559,"context_line":"                raise exception.MigrationNotFoundByStatus("},{"line_number":2560,"context_line":"                    instance_id\u003dinstance.uuid,"},{"line_number":2561,"context_line":"                    status\u003d\u0027finished or confirming\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afc51ec_31ac32ed","line":2558,"range":{"start_line":2558,"start_character":33,"end_line":2558,"end_character":34},"in_reply_to":"5aef4532_14dbf37c","updated":"2016-03-11 12:50:23.000000000","message":"ok, I saw more than 2 above in the comment\nmakes me think 2 is included...","commit_id":"a5a2f0162c3b04dcaa53fb517c7aaaf83828ba51"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"d7c11e3130b4cfa97b253f069c530acbd69ba689","unresolved":false,"context_lines":[{"line_number":2555,"context_line":"                                                              filters)"},{"line_number":2556,"context_line":"            # migrations may not be found for finished or reverting, but it"},{"line_number":2557,"context_line":"            # could not be more than 2 migrations at same time."},{"line_number":2558,"context_line":"            if len(migrations) \u003c 1:"},{"line_number":2559,"context_line":"                raise exception.MigrationNotFoundByStatus("},{"line_number":2560,"context_line":"                    instance_id\u003dinstance.uuid,"},{"line_number":2561,"context_line":"                    status\u003d\u0027finished or confirming\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5aef4532_14dbf37c","line":2558,"range":{"start_line":2558,"start_character":33,"end_line":2558,"end_character":34},"in_reply_to":"5aef4532_5215af99","updated":"2016-03-11 01:21:06.000000000","message":"I don\u0027t say that we can have 2 migrations at same time. this checking will only handle the case no migration is queried.","commit_id":"a5a2f0162c3b04dcaa53fb517c7aaaf83828ba51"}],"nova/objects/migration.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"f09673e5cffdedfa8be30c2fe654edd95ef86fcb","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    # Version 1.3: Added a new function to get in progress migrations"},{"line_number":161,"context_line":"    #              for an instance."},{"line_number":162,"context_line":"    # Version 1.4: Added instance_uuid support in get_by_filters filter"},{"line_number":163,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    fields \u003d {"},{"line_number":166,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027Migration\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_c3d42549","line":163,"range":{"start_line":163,"start_character":17,"end_line":163,"end_character":18},"updated":"2016-03-11 13:10:45.000000000","message":"is this bump needed? \nthis kind of version is used for rpc param, but this change is the content of the param?","commit_id":"326d8b1bfcf36d2c887bcfc308905f2b8b8a6785"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"7be1c508a3768c611a772925e4a4ba396c04b167","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    # Version 1.3: Added a new function to get in progress migrations"},{"line_number":161,"context_line":"    #              for an instance."},{"line_number":162,"context_line":"    # Version 1.4: Added instance_uuid support in get_by_filters filter"},{"line_number":163,"context_line":"    VERSION \u003d \u00271.4\u0027"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    fields \u003d {"},{"line_number":166,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027Migration\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3afc51ec_9d925856","line":163,"range":{"start_line":163,"start_character":17,"end_line":163,"end_character":18},"in_reply_to":"3afc51ec_c3d42549","updated":"2016-03-14 03:02:58.000000000","message":"typically, version bump is needed, because we passed new parameter `instance_uuid`to the object method.","commit_id":"326d8b1bfcf36d2c887bcfc308905f2b8b8a6785"}]}