)]}'
{"nova/compute/resource_tracker.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf7bbb400e0722d550f1fdc2e81aacd3c1b1cc37","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                instance_type \u003d self._get_instance_type(ctxt, instance, prefix,"},{"line_number":357,"context_line":"                                                        migration)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            if image_meta is None:"},{"line_number":360,"context_line":"                image_meta \u003d objects.ImageMeta.from_instance(instance)"},{"line_number":361,"context_line":"            # TODO(jaypipes): Remove when image_meta is always passed"},{"line_number":362,"context_line":"            # as an objects.ImageMeta"},{"line_number":363,"context_line":"            elif not isinstance(image_meta, objects.ImageMeta):"},{"line_number":364,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image_meta)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"            if (instance_type is not None and instance_type.id \u003d\u003d itype[\u0027id\u0027]):"},{"line_number":367,"context_line":"                numa_topology \u003d self._get_migration_context_resource("}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_4273cbb4","side":"PARENT","line":364,"range":{"start_line":359,"start_character":12,"end_line":364,"end_character":68},"updated":"2016-03-06 18:49:15.000000000","message":"What change was made such that image_meta that\u0027s passed in is always an ImageMeta object now? Or not None?","commit_id":"791e5421cdc2130ed80e067e43b6006a6859138b"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"e7e520a8037c2ce1d414f2890e3256d7c46edcea","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                instance_type \u003d self._get_instance_type(ctxt, instance, prefix,"},{"line_number":357,"context_line":"                                                        migration)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            if image_meta is None:"},{"line_number":360,"context_line":"                image_meta \u003d objects.ImageMeta.from_instance(instance)"},{"line_number":361,"context_line":"            # TODO(jaypipes): Remove when image_meta is always passed"},{"line_number":362,"context_line":"            # as an objects.ImageMeta"},{"line_number":363,"context_line":"            elif not isinstance(image_meta, objects.ImageMeta):"},{"line_number":364,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image_meta)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"            if (instance_type is not None and instance_type.id \u003d\u003d itype[\u0027id\u0027]):"},{"line_number":367,"context_line":"                numa_topology \u003d self._get_migration_context_resource("}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_f6b7e637","side":"PARENT","line":364,"range":{"start_line":359,"start_character":12,"end_line":364,"end_character":68},"in_reply_to":"5aef4532_9ecede81","updated":"2016-03-09 10:11:48.000000000","message":"Ok, thanks.","commit_id":"791e5421cdc2130ed80e067e43b6006a6859138b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"026e96e74af44786a36a5501121c714e87c8bbd4","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                instance_type \u003d self._get_instance_type(ctxt, instance, prefix,"},{"line_number":357,"context_line":"                                                        migration)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            if image_meta is None:"},{"line_number":360,"context_line":"                image_meta \u003d objects.ImageMeta.from_instance(instance)"},{"line_number":361,"context_line":"            # TODO(jaypipes): Remove when image_meta is always passed"},{"line_number":362,"context_line":"            # as an objects.ImageMeta"},{"line_number":363,"context_line":"            elif not isinstance(image_meta, objects.ImageMeta):"},{"line_number":364,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image_meta)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"            if (instance_type is not None and instance_type.id \u003d\u003d itype[\u0027id\u0027]):"},{"line_number":367,"context_line":"                numa_topology \u003d self._get_migration_context_resource("}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_9ecede81","side":"PARENT","line":364,"range":{"start_line":359,"start_character":12,"end_line":364,"end_character":68},"in_reply_to":"5aef4532_ea2f609f","updated":"2016-03-07 16:30:14.000000000","message":"Ah, yeah, OK, looks like 7fd3032f39cc6cc9b8e87834aa037bc4fb5e5620 made this no longer used, so can you document that in the commit message for context please?  And we should also remove the image_meta parameter to this method if it\u0027s not needed.","commit_id":"791e5421cdc2130ed80e067e43b6006a6859138b"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"2bf4db65fb4722191d06f49d2c4603aaf527d2f8","unresolved":false,"context_lines":[{"line_number":356,"context_line":"                instance_type \u003d self._get_instance_type(ctxt, instance, prefix,"},{"line_number":357,"context_line":"                                                        migration)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"            if image_meta is None:"},{"line_number":360,"context_line":"                image_meta \u003d objects.ImageMeta.from_instance(instance)"},{"line_number":361,"context_line":"            # TODO(jaypipes): Remove when image_meta is always passed"},{"line_number":362,"context_line":"            # as an objects.ImageMeta"},{"line_number":363,"context_line":"            elif not isinstance(image_meta, objects.ImageMeta):"},{"line_number":364,"context_line":"                image_meta \u003d objects.ImageMeta.from_dict(image_meta)"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"            if (instance_type is not None and instance_type.id \u003d\u003d itype[\u0027id\u0027]):"},{"line_number":367,"context_line":"                numa_topology \u003d self._get_migration_context_resource("}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_ea2f609f","side":"PARENT","line":364,"range":{"start_line":359,"start_character":12,"end_line":364,"end_character":68},"in_reply_to":"7af24918_4273cbb4","updated":"2016-03-07 15:42:55.000000000","message":"I was never user after this statement, so it has no effect, why not to remove that at all?","commit_id":"791e5421cdc2130ed80e067e43b6006a6859138b"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf7bbb400e0722d550f1fdc2e81aacd3c1b1cc37","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        overhead \u003d self.driver.estimate_instance_overhead(new_instance_type)"},{"line_number":269,"context_line":"        LOG.debug(\"Memory overhead for %(flavor)d MB instance; %(overhead)d \""},{"line_number":270,"context_line":"                  \"MB\", {\u0027flavor\u0027: new_instance_type.memory_mb,"},{"line_number":271,"context_line":"                         \u0027overhead\u0027: overhead[\u0027memory_mb\u0027]})"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        claim \u003d claims.MoveClaim(context, instance, new_instance_type,"},{"line_number":274,"context_line":"                                 image_meta, self, self.compute_node,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_e2477749","line":271,"updated":"2016-03-06 18:49:15.000000000","message":"This is unrelated.","commit_id":"329d78d7b29890202a3073d4d198c385838886ca"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"2bf4db65fb4722191d06f49d2c4603aaf527d2f8","unresolved":false,"context_lines":[{"line_number":268,"context_line":"        overhead \u003d self.driver.estimate_instance_overhead(new_instance_type)"},{"line_number":269,"context_line":"        LOG.debug(\"Memory overhead for %(flavor)d MB instance; %(overhead)d \""},{"line_number":270,"context_line":"                  \"MB\", {\u0027flavor\u0027: new_instance_type.memory_mb,"},{"line_number":271,"context_line":"                         \u0027overhead\u0027: overhead[\u0027memory_mb\u0027]})"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        claim \u003d claims.MoveClaim(context, instance, new_instance_type,"},{"line_number":274,"context_line":"                                 image_meta, self, self.compute_node,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aef4532_4a72d4e6","line":271,"in_reply_to":"7af24918_e2477749","updated":"2016-03-07 15:42:55.000000000","message":"Ok, i will make separate patch.","commit_id":"329d78d7b29890202a3073d4d198c385838886ca"}]}