)]}'
{"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"0ef9240c8a2676859435a9fd9c15639d7e0f70ce","unresolved":false,"context_lines":[{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    try:"},{"line_number":1134,"context_line":"        _check_vdi_size(context, session, instance, vdis[\u0027root\u0027][\u0027uuid\u0027])"},{"line_number":1135,"context_line":"    except Exception, e:"},{"line_number":1136,"context_line":"        for key in vdis:"},{"line_number":1137,"context_line":"            vdi \u003d vdis[key]"},{"line_number":1138,"context_line":"            vdi_uuid \u003d vdi[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FceY%3D","line":1135,"updated":"2013-05-09 13:39:16.000000000","message":"e is unused.  Also, can you narrow this to something tighter than Exception, or can _check_vdi_size truely throw anything?","commit_id":"b34f6f885a2986a36727f2f327650e036526be15"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"54390eff35c5942c606ab7ce2dc0ff7e8ced1d51","unresolved":false,"context_lines":[{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    try:"},{"line_number":1134,"context_line":"        _check_vdi_size(context, session, instance, vdis[\u0027root\u0027][\u0027uuid\u0027])"},{"line_number":1135,"context_line":"    except Exception, e:"},{"line_number":1136,"context_line":"        for key in vdis:"},{"line_number":1137,"context_line":"            vdi \u003d vdis[key]"},{"line_number":1138,"context_line":"            vdi_uuid \u003d vdi[\u0027uuid\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FcdM%3D","line":1135,"in_reply_to":"AAAAOn%2F%2FceY%3D","updated":"2013-05-09 13:59:21.000000000","message":"+1 for this.  Also, due to eventlet issues it\u0027s safer to use \"with excutils.save_and_reraise_exception():\" rather  than a bare raise.  Otherwise you can run into issues like https://bugs.launchpad.net/nova/+bug/1167515","commit_id":"b34f6f885a2986a36727f2f327650e036526be15"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"ce2fef6480511879a17ab1318b8d0f96a2d82cbb","unresolved":false,"context_lines":[{"line_number":1132,"context_line":""},{"line_number":1133,"context_line":"    try:"},{"line_number":1134,"context_line":"        _check_vdi_size(context, session, instance, vdis[\u0027root\u0027][\u0027uuid\u0027])"},{"line_number":1135,"context_line":"    except Exception:"},{"line_number":1136,"context_line":"        with excutils.save_and_reraise_exception():"},{"line_number":1137,"context_line":"            for key in vdis:"},{"line_number":1138,"context_line":"                vdi \u003d vdis[key]"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAOn%2F%2Fb4Y%3D","line":1135,"updated":"2013-05-09 18:47:45.000000000","message":"I would still rather see this not be so broad, but it doesn\u0027t appear that any exception is recoverable right now so there shouldn\u0027t be any harm in catching them all.","commit_id":"4f9d45aa4f6a805eb5cdaddaf7cef1472e37755a"}]}