)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"15bc3d36c55ddb04d66e008bbbabe98d21c6d6e4","unresolved":false,"context_lines":[{"line_number":5845,"context_line":"        if \u0027graphics_listen_addr_vnc\u0027 in migrate_data:"},{"line_number":5846,"context_line":"            listen_addrs[\u0027vnc\u0027] \u003d str("},{"line_number":5847,"context_line":"                migrate_data.graphics_listen_addr_vnc)"},{"line_number":5848,"context_line":"        if \u0027graphics_listen_addr_spice\u0027 in migrate_data:"},{"line_number":5849,"context_line":"            listen_addrs[\u0027spice\u0027] \u003d str("},{"line_number":5850,"context_line":"                migrate_data.graphics_listen_addr_spice)"},{"line_number":5851,"context_line":"        return listen_addrs"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_91b9aaec","line":5848,"updated":"2016-03-01 19:08:14.000000000","message":"I think remote access can be either vnc OR spice.  If it\u0027s the case maybe it\u0027s better to fix this block of code with an \u0027elif\u0027 statement, it would be cleaner.","commit_id":"a20ad7179d51ce330274ddb2638e19b8a4c8ec59"},{"author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"change_message_id":"d36c44ea3f161a8220acabf3fed9b7584f29e081","unresolved":false,"context_lines":[{"line_number":5845,"context_line":"        if \u0027graphics_listen_addr_vnc\u0027 in migrate_data:"},{"line_number":5846,"context_line":"            listen_addrs[\u0027vnc\u0027] \u003d str("},{"line_number":5847,"context_line":"                migrate_data.graphics_listen_addr_vnc)"},{"line_number":5848,"context_line":"        if \u0027graphics_listen_addr_spice\u0027 in migrate_data:"},{"line_number":5849,"context_line":"            listen_addrs[\u0027spice\u0027] \u003d str("},{"line_number":5850,"context_line":"                migrate_data.graphics_listen_addr_spice)"},{"line_number":5851,"context_line":"        return listen_addrs"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_91f503cd","line":5848,"in_reply_to":"7af24918_91b9aaec","updated":"2016-03-02 09:48:56.000000000","message":"I specifically did not want to change any logic in this patch. Also I am not sure what you are saying is true. These are 2 completely separate consoles that a user can request separately (but would need to double check).\n\nRegradless - this patch should not have any functional changes really","commit_id":"a20ad7179d51ce330274ddb2638e19b8a4c8ec59"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"a10fcffb8666f2b74286ba9e742d5a714262462b","unresolved":false,"context_lines":[{"line_number":5845,"context_line":"        if \u0027graphics_listen_addr_vnc\u0027 in migrate_data:"},{"line_number":5846,"context_line":"            listen_addrs[\u0027vnc\u0027] \u003d str("},{"line_number":5847,"context_line":"                migrate_data.graphics_listen_addr_vnc)"},{"line_number":5848,"context_line":"        if \u0027graphics_listen_addr_spice\u0027 in migrate_data:"},{"line_number":5849,"context_line":"            listen_addrs[\u0027spice\u0027] \u003d str("},{"line_number":5850,"context_line":"                migrate_data.graphics_listen_addr_spice)"},{"line_number":5851,"context_line":"        return listen_addrs"}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_d9a2094b","line":5848,"in_reply_to":"7af24918_91f503cd","updated":"2016-03-02 12:57:01.000000000","message":"I\u0027m good with that then.","commit_id":"a20ad7179d51ce330274ddb2638e19b8a4c8ec59"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"459e921e76bdf7aa76421b3abe0182c84a407e3d","unresolved":false,"context_lines":[{"line_number":5820,"context_line":""},{"line_number":5821,"context_line":"    def _update_xml(self, xml_str, migrate_data):"},{"line_number":5822,"context_line":"        # FIXME(ndipanov): Change this method to use nova.virt.libvirt.config"},{"line_number":5823,"context_line":"        # classes to do it\u0027s work. This will require updating them to handle"},{"line_number":5824,"context_line":"        # the slightly different XML format."},{"line_number":5825,"context_line":"        xml_doc \u003d etree.fromstring(xml_str)"},{"line_number":5826,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1af94dfe_396e7695","line":5823,"updated":"2016-03-16 23:47:11.000000000","message":"s/it\u0027s/its/","commit_id":"65738377e4c3564f1974a35e9429d2585b72bf69"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2aeff0d6d3693d461754c1cc05a2d2d530805067","unresolved":false,"context_lines":[{"line_number":5849,"context_line":""},{"line_number":5850,"context_line":"    def _update_xml(self, xml_str, migrate_data):"},{"line_number":5851,"context_line":"        # FIXME(ndipanov): Change this method to use nova.virt.libvirt.config"},{"line_number":5852,"context_line":"        # classes to do it\u0027s work. This will require updating them to handle"},{"line_number":5853,"context_line":"        # the slightly different XML format."},{"line_number":5854,"context_line":"        xml_doc \u003d etree.fromstring(xml_str)"},{"line_number":5855,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a122d0e_7313e50d","line":5852,"range":{"start_line":5852,"start_character":24,"end_line":5852,"end_character":28},"updated":"2016-04-19 09:25:37.000000000","message":"Same comment as Jay: s/it\u0027s/its","commit_id":"3108f0c3a9c633ff30d37585de70bbede1bbc8f6"}]}