)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"d1c1fa379bac6c5ef5be8a2cc06e7d33edf54595","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"glance can only tell us the size of the file, not the virtual"},{"line_number":10,"context_line":"size of the QCOW2. As such we need to check the virtual size of"},{"line_number":11,"context_line":"the image once its cached and ensure its \u003c\u003d to the flavor\u0027s"},{"line_number":12,"context_line":"root disk size."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I833467284126557eb598b8350a84e10c06292fa9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAOn%2F%2FbkA%3D","line":11,"updated":"2013-05-09 21:21:57.000000000","message":"s/its/it\u0027s/","commit_id":"8df58d8738d11584c8a5c11af62ceb03dfb24dfb"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"d1c1fa379bac6c5ef5be8a2cc06e7d33edf54595","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        if not os.path.exists(base):"},{"line_number":258,"context_line":"            prepare_template(target\u003dbase, *args, **kwargs)"},{"line_number":259,"context_line":"        if size and size \u003c disk.get_disk_size(base):"},{"line_number":260,"context_line":"            raise exception.ImageTooLarge()"},{"line_number":261,"context_line":"        if not os.path.exists(self.path):"},{"line_number":262,"context_line":"            with utils.remove_path_on_error(self.path):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbkY%3D","line":259,"updated":"2013-05-09 21:21:57.000000000","message":"if size \u003d\u003d 0 then you won\u0027t get this.  Is that the desired behavior?","commit_id":"8df58d8738d11584c8a5c11af62ceb03dfb24dfb"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fabc301587c87636a3c5d17c11359437d383b22a","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        if not os.path.exists(base):"},{"line_number":258,"context_line":"            prepare_template(target\u003dbase, *args, **kwargs)"},{"line_number":259,"context_line":"        if size and size \u003c disk.get_disk_size(base):"},{"line_number":260,"context_line":"            raise exception.ImageTooLarge()"},{"line_number":261,"context_line":"        if not os.path.exists(self.path):"},{"line_number":262,"context_line":"            with utils.remove_path_on_error(self.path):"},{"line_number":263,"context_line":"                copy_qcow2_image(base, self.path, size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FbnI%3D","line":260,"updated":"2013-05-09 20:57:26.000000000","message":"I think it would be helpful to log something here.","commit_id":"8df58d8738d11584c8a5c11af62ceb03dfb24dfb"},{"author":{"_account_id":4468,"name":"Wangpan","email":"hzwangpan@corp.netease.com","username":"hzwangpan"},"change_message_id":"5464fbfa257ce4b124228ead1c974b84520bf6bf","unresolved":false,"context_lines":[{"line_number":257,"context_line":"        if not os.path.exists(base):"},{"line_number":258,"context_line":"            prepare_template(target\u003dbase, *args, **kwargs)"},{"line_number":259,"context_line":"        if size and size \u003c disk.get_disk_size(base):"},{"line_number":260,"context_line":"            LOG.error(\u0027%s virtual size larger then flavor root disk size %s\u0027 %"},{"line_number":261,"context_line":"                      (base, size))"},{"line_number":262,"context_line":"            raise exception.ImageTooLarge()"},{"line_number":263,"context_line":"        if not os.path.exists(self.path):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAOn%2F%2FbCg%3D","line":260,"updated":"2013-05-10 02:01:12.000000000","message":"typo:then-\u003ethan","commit_id":"7fbe086153174e1b278f97f219bd30d21a1f6f26"},{"author":{"_account_id":7366,"name":"Ivan Melnikov","email":"imelnikov@griddynamics.com","username":"imelnikov"},"change_message_id":"32f59c9c2436fceba4488ed44901907a88490027","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        # NOTE(cfb): Having a flavor that sets the root size to 0 and having"},{"line_number":260,"context_line":"        #            nova effectively ignore that size and use the size of the"},{"line_number":261,"context_line":"        #            image is considered a feature at this time, not a bug."},{"line_number":262,"context_line":"        if size and size \u003c disk.get_disk_size(base):"},{"line_number":263,"context_line":"            LOG.error(\u0027%s virtual size larger than flavor root disk size %s\u0027 %"},{"line_number":264,"context_line":"                      (base, size))"},{"line_number":265,"context_line":"            raise exception.ImageTooLarge()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAO3%2F%2F84k%3D","line":262,"updated":"2013-05-16 11:03:41.000000000","message":"Correct me if I am mistaken, but from security point of view this does not fix the issue for most OpenStack installations. If flavor with zero root size is available (and most of times it is), users still seem to be able to do all the nasty stuff mentioned in OSSA 2013-012.\n\nOr am I missing something?","commit_id":"44a8aba1d5da87d54db48079103fdef946666d80"},{"author":{"_account_id":1678,"name":"Tiantian Gao","email":"gtt116@gmail.com","username":"gtt116"},"change_message_id":"5d9be467719532c1e93216683843863d1e4690a9","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        # NOTE(cfb): Having a flavor that sets the root size to 0 and having"},{"line_number":260,"context_line":"        #            nova effectively ignore that size and use the size of the"},{"line_number":261,"context_line":"        #            image is considered a feature at this time, not a bug."},{"line_number":262,"context_line":"        if size and size \u003c disk.get_disk_size(base):"},{"line_number":263,"context_line":"            LOG.error(\u0027%s virtual size larger than flavor root disk size %s\u0027 %"},{"line_number":264,"context_line":"                      (base, size))"},{"line_number":265,"context_line":"            raise exception.ImageTooLarge()"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPH%2F%2Fr%2BE%3D","line":262,"in_reply_to":"AAAAO3%2F%2F84k%3D","updated":"2013-05-27 03:35:03.000000000","message":"Maybe do not have any flavors which root size is zero can fix it.","commit_id":"44a8aba1d5da87d54db48079103fdef946666d80"}]}