)]}'
{"id":"openstack%2Fnova~2874","triplet_id":"openstack%2Fnova~master~Id75723a21c0d6dc20f446560847e5b8522ec3262","project":"openstack/nova","branch":"master","topic":"bug/885267","hashtags":[],"change_id":"Id75723a21c0d6dc20f446560847e5b8522ec3262","subject":"Bug 885267: Fix GET /servers during instance delete","status":"MERGED","created":"2012-01-06 16:38:04.000000000","updated":"2012-01-09 23:45:06.000000000","submitted":"2012-01-09 23:45:06.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"81586c9e753298d6cb309c80b6ac4e8469f78813","_number":2874,"virtual_id_number":2874,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":1,"date":"2012-01-09 23:45:04.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"all":[{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":2,"date":"2012-01-09 23:34:33.000000000","_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"date":"2012-01-09 22:45:14.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2012-01-09 21:33:35.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"date":"2012-01-09 23:45:04.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"all":[{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":1,"date":"2012-01-09 23:34:33.000000000","_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2012-01-09 21:33:35.000000000","_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"value":0,"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-01-06 16:52:42.000000000","updated_by":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"reviewer":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"state":"REVIEWER"},{"updated":"2012-01-06 17:30:38.000000000","updated_by":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"reviewer":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"state":"REVIEWER"},{"updated":"2012-01-09 21:33:35.000000000","updated_by":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"reviewer":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"state":"REVIEWER"},{"updated":"2012-01-09 22:45:14.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2012-01-09 23:34:33.000000000","updated_by":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"reviewer":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"state":"REVIEWER"},{"updated":"2012-01-09 23:45:04.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"779bc3b9f4a3cf360a153b765c545bdec32fe4d4","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-01-06 16:43:36.000000000","message":"Patch Set 1:\n\nI\u0027m not 100% convinced that this is the correct solution to the issue; don\u0027t we just set the \u0027deleted\u0027 column to 1 to \"delete\" the instance?  In that case, changing the search to include deleted instances should be sufficient.","accounts_in_message":[],"_revision_number":1},{"id":"677a32896039cb011faef40de23d3727b051cea7","author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"date":"2012-01-06 16:52:42.000000000","message":"Patch Set 1: (1 inline comment)\n\nThis looks like the right idea to me. The API docs explicitly state that \"Servers that have been deleted are not included in this list.\" so I don\u0027t think including deleted servers in the query would be prudent.\n\nOne small comment.","accounts_in_message":[],"_revision_number":1},{"id":"0879155dd877bb102aedb28c4025fa7ab7887e55","author":{"_account_id":1155,"name":"sleepsonthefloor","username":"sleepsonthefloor"},"date":"2012-01-06 17:30:38.000000000","message":"Patch Set 1:\n\nnice job tracking this down, dean.  I agree with mdietz inline comment, that this is an odd extension (and inefficient).  It also seems to have produced a rather subtle bug that was hard to isolate.  So I\u0027d be for making this functionality -not- an extension.","accounts_in_message":[],"_revision_number":1},{"id":"20f2bab61946a240c43940eef17cee143d15cafa","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-01-06 17:34:27.000000000","message":"Patch Set 1:\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/8205\n\tLibvirt Success: http://smokestack.openstack.org/?go\u003d/jobs/8206\n\tXenServer Success: http://smokestack.openstack.org/?go\u003d/jobs/8204","accounts_in_message":[],"_revision_number":1},{"id":"1b6bd0cb12959c48e19b6d624e766357134e6a41","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-01-06 17:36:30.000000000","message":"Patch Set 1: (1 inline comment)\n\nKevin, compute.routing_get() and compute.get() don\u0027t have the ability to ignore deleted servers afaik.  I certainly don\u0027t want to change those interfaces for this although there may be a better API to call that would allow to filter on deleted?","accounts_in_message":[],"_revision_number":1},{"id":"b2594a4de8c47243b3f7b4062c72c7a603e97bcc","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-01-06 17:37:50.000000000","message":"Patch Set 1:\n\nBrian: There is the point, though, that the instance was clearly *not* deleted at the point of return of the originally invoked action...","accounts_in_message":[],"_revision_number":1},{"id":"7d01200b66973ff69f0e93254f3c1c4bdfe881f2","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-01-09 21:20:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4e1cf902d0c1c957d3a30565a48bb8f83d51d871","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-01-09 21:32:06.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f065085abd0b09f313d4b1d0fcdd8e4ad38b2673","author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"date":"2012-01-09 21:33:35.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"950dcceab1272338bda8781db1005a35eb9b49bf","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2012-01-09 22:45:14.000000000","message":"Patch Set 3:\n\nSmokeStack Results (patch set 3):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/8377\n\tLibvirt Success: http://smokestack.openstack.org/?go\u003d/jobs/8375\n\tXenServer Success: http://smokestack.openstack.org/?go\u003d/jobs/8376","accounts_in_message":[],"_revision_number":3},{"id":"5390bd22f83559e35c438357fc956868f7af70f6","author":{"_account_id":693,"name":"Christopher MacGown","email":"chris@pistoncloud.com","username":"0x44"},"date":"2012-01-09 23:34:33.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"6cd5b7f7e80e1facb9647f373a2c89c42321cf15","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-09 23:45:04.000000000","message":"Patch Set 3: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-integration-tests-devstack-vm/367/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/832/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-unittests/444/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/2207/ : SUCCESS","accounts_in_message":[],"_revision_number":3},{"id":"f9520c24bb5ad16939a282abf7332b5c70697afd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-01-09 23:45:06.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"51c0d545253b9f5618d1923aea3f7061da6cd60b","revisions":{"c9898120a4d460d409c9acbcc23c3cf1993f906a":{"kind":"REWORK","_number":1,"created":"2012-01-06 16:38:04.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/74/2874/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/74/2874/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/2874/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/2874/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/2874/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/74/2874/1"}}},"commit":{"parents":[{"commit":"613d1dbc87d9af5d07dc277f0264d6fe1e2e073b","subject":"Adds workaround check for mox in to_primitive","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/613d1dbc87d9af5d07dc277f0264d6fe1e2e073b"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-01-06 06:22:52.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-01-06 16:36:47.000000000","tz":-360},"subject":"Bug 885267: Fix GET /servers during instance delete","message":"Bug 885267: Fix GET /servers during instance delete\n\nThere is a period during an instance delete when GET /servers\nwill fail occasionally.  The race condition is during GET /servers\nbetween the initial get_all() and when the extended_status extension\nre-retrieves individual servers via compute.api.routing_get().\nWe log a warning and remove the offending server from the list\nas it no longer exists.\n\nChange-Id: Id75723a21c0d6dc20f446560847e5b8522ec3262\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c9898120a4d460d409c9acbcc23c3cf1993f906a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c9898120a4d460d409c9acbcc23c3cf1993f906a"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"613d1dbc87d9af5d07dc277f0264d6fe1e2e073b","is_merged_in_target_branch":true,"change_id":"I3e57b60886a94c5e7a337b73716759c9a6838e04","change_number":2859,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"},"37057955f9bac7d0f8538baf5c611eee3eb9db90":{"kind":"REWORK","_number":2,"created":"2012-01-09 21:20:54.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/74/2874/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/74/2874/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/2874/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/2874/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/2874/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/74/2874/2"}}},"commit":{"parents":[{"commit":"c27e1ccd3f1a9cda6fff70d87aece6e50eba887d","subject":"Refactors utils.load_cached_file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c27e1ccd3f1a9cda6fff70d87aece6e50eba887d"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-01-06 06:22:52.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-01-09 21:20:49.000000000","tz":-360},"subject":"Bug 885267: Fix GET /servers during instance delete","message":"Bug 885267: Fix GET /servers during instance delete\n\nThere is a period during an instance delete when GET /servers\nwill fail occasionally.  The race condition is during GET /servers\nbetween the initial get_all() and when the extended_status extension\nre-retrieves individual servers via compute.api.routing_get().\nWe log a warning and remove the offending server from the list\nas it no longer exists.\n\nChange-Id: Id75723a21c0d6dc20f446560847e5b8522ec3262\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/37057955f9bac7d0f8538baf5c611eee3eb9db90"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/37057955f9bac7d0f8538baf5c611eee3eb9db90"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c27e1ccd3f1a9cda6fff70d87aece6e50eba887d","is_merged_in_target_branch":true,"change_id":"I4d998c34caa6dde65aaf780c188778477b7f6753","change_number":2828,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"},"51c0d545253b9f5618d1923aea3f7061da6cd60b":{"kind":"REWORK","_number":3,"created":"2012-01-09 21:32:06.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/74/2874/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/74/2874/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/2874/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/2874/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/74/2874/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/74/2874/3"}}},"commit":{"parents":[{"commit":"c27e1ccd3f1a9cda6fff70d87aece6e50eba887d","subject":"Refactors utils.load_cached_file","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/c27e1ccd3f1a9cda6fff70d87aece6e50eba887d"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-01-06 06:22:52.000000000","tz":-360},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-01-09 21:32:01.000000000","tz":-360},"subject":"Bug 885267: Fix GET /servers during instance delete","message":"Bug 885267: Fix GET /servers during instance delete\n\nThere is a period during an instance delete when GET /servers\nwill fail occasionally.  The race condition is during GET /servers\nbetween the initial get_all() and when the extended_status extension\nre-retrieves individual servers via compute.api.routing_get().\nWe log a warning and remove the offending server from the list\nas it no longer exists.\n\nChange-Id: Id75723a21c0d6dc20f446560847e5b8522ec3262\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/51c0d545253b9f5618d1923aea3f7061da6cd60b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/51c0d545253b9f5618d1923aea3f7061da6cd60b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"c27e1ccd3f1a9cda6fff70d87aece6e50eba887d","is_merged_in_target_branch":true,"change_id":"I4d998c34caa6dde65aaf780c188778477b7f6753","change_number":2828,"patch_set_number":6,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}