)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"3fdd3d6e411dbde7fa09533eaaf8189447b79cdd","unresolved":false,"context_lines":[{"line_number":6396,"context_line":"        # compute nodes to delete below, as we can end up doing greenthread"},{"line_number":6397,"context_line":"        # switches there. Best to have everyone using the newest cache"},{"line_number":6398,"context_line":"        # ASAP."},{"line_number":6399,"context_line":"        self._resource_tracker_dict \u003d new_resource_tracker_dict"},{"line_number":6400,"context_line":""},{"line_number":6401,"context_line":"        # Delete orphan compute node not reported by driver but still in db"},{"line_number":6402,"context_line":"        for cn in compute_nodes_in_db:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_988e7177","side":"PARENT","line":6399,"updated":"2016-03-03 10:39:01.000000000","message":"Should this line be called after looping through nodes to update resource tracked dict?","commit_id":"8d0d3dbf9ba0cf47abd43383d51c0761d98b6908"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"d67e450a3a86360720fee2e1c4e8f9080eec3e47","unresolved":false,"context_lines":[{"line_number":6396,"context_line":"        # compute nodes to delete below, as we can end up doing greenthread"},{"line_number":6397,"context_line":"        # switches there. Best to have everyone using the newest cache"},{"line_number":6398,"context_line":"        # ASAP."},{"line_number":6399,"context_line":"        self._resource_tracker_dict \u003d new_resource_tracker_dict"},{"line_number":6400,"context_line":""},{"line_number":6401,"context_line":"        # Delete orphan compute node not reported by driver but still in db"},{"line_number":6402,"context_line":"        for cn in compute_nodes_in_db:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_bb952734","side":"PARENT","line":6399,"in_reply_to":"7af24918_988e7177","updated":"2016-03-03 10:56:29.000000000","message":"Please have look at line 6384 _resource_tracker_dict is updated per node.","commit_id":"8d0d3dbf9ba0cf47abd43383d51c0761d98b6908"},{"author":{"_account_id":12712,"name":"Gleb Stepanov","email":"gstepanov@mirantis.com","username":"stgleb"},"change_message_id":"a815482c4fb818c25828661ceee52afd323f1fc7","unresolved":false,"context_lines":[{"line_number":6396,"context_line":"        # compute nodes to delete below, as we can end up doing greenthread"},{"line_number":6397,"context_line":"        # switches there. Best to have everyone using the newest cache"},{"line_number":6398,"context_line":"        # ASAP."},{"line_number":6399,"context_line":"        self._resource_tracker_dict \u003d new_resource_tracker_dict"},{"line_number":6400,"context_line":""},{"line_number":6401,"context_line":"        # Delete orphan compute node not reported by driver but still in db"},{"line_number":6402,"context_line":"        for cn in compute_nodes_in_db:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7af24918_81b9d817","side":"PARENT","line":6399,"in_reply_to":"7af24918_bb952734","updated":"2016-03-03 11:25:43.000000000","message":"ok, i\u0027ve missed that thing.","commit_id":"8d0d3dbf9ba0cf47abd43383d51c0761d98b6908"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"48a9425dbbd2f48a0d5bda067e6f89c8f2a1a885","unresolved":false,"context_lines":[{"line_number":6430,"context_line":"                                    \"instance: %s\"),"},{"line_number":6431,"context_line":"                                e, instance\u003dinstance)"},{"line_number":6432,"context_line":""},{"line_number":6433,"context_line":"    def update_available_resource_for_node(self, context, nodename):"},{"line_number":6434,"context_line":""},{"line_number":6435,"context_line":"        rt \u003d self._get_resource_tracker(nodename)"},{"line_number":6436,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa0719c6_d7754cfa","line":6433,"updated":"2016-03-23 19:13:44.000000000","message":"Minor thing, but nobody is calling this method from outside of this class so it would be better to have a _ prefix.","commit_id":"7f803b75ced198a0dede529fb9cfa7f51d9fb607"}]}
