)]}'
{"nova/api/openstack/compute/plugins/v3/flavors.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"c03d533fc486eeeaefc8ed66be303cada57f8cba","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class Flavors(extensions.V3APIExtensionBase):"},{"line_number":149,"context_line":"    name \u003d \"Flavors\""},{"line_number":150,"context_line":"    alias \u003d \"flavors\" "},{"line_number":151,"context_line":"    namespace \u003d \"http://docs.openstack.org/compute/core/flavors/v3\""},{"line_number":152,"context_line":"    version \u003d 1"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FZss%3D","line":150,"updated":"2013-05-10 19:33:16.000000000","message":"Looks like some rogue whitespace here","commit_id":"20096f8c274ee1ed12b98d9f84ce027cf2e2dd6c"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"c03d533fc486eeeaefc8ed66be303cada57f8cba","unresolved":false,"context_lines":[{"line_number":156,"context_line":"        resources \u003d ["},{"line_number":157,"context_line":"            extensions.ResourceExtension("},{"line_number":158,"context_line":"                \u0027flavors\u0027,"},{"line_number":159,"context_line":"                FalvorsController(extension_info\u003dself.extension_info),"},{"line_number":160,"context_line":"                collection_actions\u003dcollection_actions)]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    return resources"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FZsU%3D","line":159,"updated":"2013-05-10 19:33:16.000000000","message":"I think this a typo here? Falvors? \nAnd does the flavors controller need the extension info? Probably only if its going to implement provide for an extension point in the future","commit_id":"20096f8c274ee1ed12b98d9f84ce027cf2e2dd6c"},{"author":{"_account_id":1711,"name":"Yun Mao","email":"yunmao@gmail.com","username":"yunmao"},"change_message_id":"08ad5bec97c944d804a1be69189680f8b87ff090","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                collection_actions\u003dcollection_actions)]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    return resources"},{"line_number":163,"context_line":"}"},{"line_number":164,"context_line":"        "},{"line_number":165,"context_line":"    def get_controller_extensions(self):"},{"line_number":166,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FZIc%3D","line":163,"updated":"2013-05-11 03:19:21.000000000","message":"invalid syntax","commit_id":"20096f8c274ee1ed12b98d9f84ce027cf2e2dd6c"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"c03d533fc486eeeaefc8ed66be303cada57f8cba","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    return resources"},{"line_number":163,"context_line":"}"},{"line_number":164,"context_line":"        "},{"line_number":165,"context_line":"    def get_controller_extensions(self):"},{"line_number":166,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FZso%3D","line":164,"updated":"2013-05-10 19:33:16.000000000","message":"here as well.","commit_id":"20096f8c274ee1ed12b98d9f84ce027cf2e2dd6c"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"cba1ca422895675968075c4078097dc0f4055a84","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_is_public(self, req):"},{"line_number":96,"context_line":"        \"\"\"Parse is_public into something usable.\"\"\""},{"line_number":97,"context_line":"        is_public \u003d req.params.get(\u0027is_public\u0027, None)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        if is_public is None:"},{"line_number":100,"context_line":"            # preserve default value of showing only public flavors"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPX%2F%2F9Zs%3D","line":97,"updated":"2013-06-05 04:58:48.000000000","message":"nit: we don\u0027t need the , None) here","commit_id":"6e04c5f8b322849c2ff9a65d6da70bab66a927cf"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"cba1ca422895675968075c4078097dc0f4055a84","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if is_public is None:"},{"line_number":100,"context_line":"            # preserve default value of showing only public flavors"},{"line_number":101,"context_line":"            return True"},{"line_number":102,"context_line":"        elif is_public is True or \\"},{"line_number":103,"context_line":"            is_public.lower() in [\u0027t\u0027, \u0027true\u0027, \u0027yes\u0027, \u00271\u0027]:"},{"line_number":104,"context_line":"            return True"},{"line_number":105,"context_line":"        elif is_public is False or \\"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPX%2F%2F9ZY%3D","line":102,"updated":"2013-06-05 04:58:48.000000000","message":"nit: would be better to use: \n\nfrom openstack.common import strutils\n\nstrutils.bool_from_string(is_public)","commit_id":"6e04c5f8b322849c2ff9a65d6da70bab66a927cf"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"cba1ca422895675968075c4078097dc0f4055a84","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        elif is_public is True or \\"},{"line_number":103,"context_line":"            is_public.lower() in [\u0027t\u0027, \u0027true\u0027, \u0027yes\u0027, \u00271\u0027]:"},{"line_number":104,"context_line":"            return True"},{"line_number":105,"context_line":"        elif is_public is False or \\"},{"line_number":106,"context_line":"            is_public.lower() in [\u0027f\u0027, \u0027false\u0027, \u0027no\u0027, \u00270\u0027]:"},{"line_number":107,"context_line":"            return False"},{"line_number":108,"context_line":"        elif is_public.lower() \u003d\u003d \u0027none\u0027:"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAPX%2F%2F9ZM%3D","line":105,"updated":"2013-06-05 04:58:48.000000000","message":"ditto","commit_id":"6e04c5f8b322849c2ff9a65d6da70bab66a927cf"},{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"bdfdb0f5a8bfcf20b48338345cc23df9d2e31fda","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        resources \u003d ["},{"line_number":161,"context_line":"            extensions.ResourceExtension(\u0027flavors\u0027,"},{"line_number":162,"context_line":"                                         FlavorsController(),"},{"line_number":163,"context_line":"                                         member_name\u003d\u0027flavors\u0027,"},{"line_number":164,"context_line":"                                         collection_actions\u003dcollection_actions,"},{"line_number":165,"context_line":"                                         member_actions\u003dmember_actions)"},{"line_number":166,"context_line":"            ]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAPX%2F%2Fv2o%3D","line":163,"updated":"2013-06-11 13:50:07.000000000","message":"I think the member_name should be the singular \"flavor\"","commit_id":"70e0a838eba26026eb8895c87a25814af76afc31"}],"nova/tests/api/openstack/compute/plugins/v3/test_flavors.py":[{"author":{"_account_id":5292,"name":"Christopher Yeoh","email":"cbkyeoh@gmail.com","username":"cyeoh-0"},"change_message_id":"c03d533fc486eeeaefc8ed66be303cada57f8cba","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import urlparse"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from nova.api.openstack.compute import flavors"},{"line_number":24,"context_line":"from nova.api.openstack import xmlutil"},{"line_number":25,"context_line":"import nova.compute.flavors"},{"line_number":26,"context_line":"from nova import context"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAOn%2F%2FZsE%3D","line":23,"updated":"2013-05-10 19:33:16.000000000","message":"You need to import nova.api.openstack.compute.plugins.v3 or you\u0027ll be testing the V2 interface","commit_id":"20096f8c274ee1ed12b98d9f84ce027cf2e2dd6c"}]}