)]}'
{"nova/api/validation/validators.py":[{"author":{"_account_id":17714,"name":"Augustina Ragwitz","email":"auggy@cpan.org","username":"mmmpork"},"change_message_id":"439d225c55b114052017062b4688bfbec6a943cd","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    try:"},{"line_number":95,"context_line":"        if re.search(regex.regex, instance):"},{"line_number":96,"context_line":"            return True"},{"line_number":97,"context_line":"    except TypeError:"},{"line_number":98,"context_line":"        pass"},{"line_number":99,"context_line":"    raise exception.InvalidName(reason\u003dregex.reason)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_52d0d6c9","line":97,"updated":"2016-03-05 00:20:09.000000000","message":"Could you leave a comment to explain why the TypeError needs to be ignored?","commit_id":"c127000207e9de1372b7e56d312645d1d5629b7b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"227c645fb4ee7046f5ce543804b72131937a1086","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if re.search(regex.regex, instance):"},{"line_number":96,"context_line":"            return True"},{"line_number":97,"context_line":"    except TypeError:"},{"line_number":98,"context_line":"        pass"},{"line_number":99,"context_line":"    raise exception.InvalidName(reason\u003dregex.reason)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_33fba57a","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":12},"updated":"2016-03-04 16:11:49.000000000","message":"I am concern on this kind of hacking..not sure it\u0027s too generic\n\nand , this will raise a Invalidname if None is input?","commit_id":"c127000207e9de1372b7e56d312645d1d5629b7b"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"1f0ec4e56576037f360e95667cfd44641cd7a28d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        if re.search(regex.regex, instance):"},{"line_number":96,"context_line":"            return True"},{"line_number":97,"context_line":"    except TypeError:"},{"line_number":98,"context_line":"        pass"},{"line_number":99,"context_line":"    raise exception.InvalidName(reason\u003dregex.reason)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7af24918_55b3a00a","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":12},"in_reply_to":"7af24918_33fba57a","updated":"2016-03-05 00:37:34.000000000","message":"@Augustina, @jichenjc, this is for this format checks only works for \u0027string\u0027 type. If the \u0027instance\u0027 is other type, there will be TypeError raised. I will add comment at here to explain what happened.","commit_id":"c127000207e9de1372b7e56d312645d1d5629b7b"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9457d40064f67a6487683d9df765996d4278af17","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            return True"},{"line_number":86,"context_line":"    except TypeError:"},{"line_number":87,"context_line":"        # The name must be string type. If instance isn\u0027t string type, the"},{"line_number":88,"context_line":"        # TypeError will be raised at here."},{"line_number":89,"context_line":"        pass"},{"line_number":90,"context_line":"    raise exception.InvalidName(reason\u003dregex.reason)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_cdf8b07f","line":88,"range":{"start_line":88,"start_character":10,"end_line":88,"end_character":19},"updated":"2016-03-07 19:50:57.000000000","message":"ok, this comment make sense, but I don\u0027t know how we handle the None case? \nsince None will raise Type error and line 90 will raise InvalidName exception, however, ti\u0027s a value input?\nI may need dig more on how this is handled..","commit_id":"923cf20eca35b551ae1fb4a77835f8104ea6cbed"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"d6f1d4486f2176f6a77a3d7e3a7a689cf6c2890b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            return True"},{"line_number":86,"context_line":"    except TypeError:"},{"line_number":87,"context_line":"        # The name must be string type. If instance isn\u0027t string type, the"},{"line_number":88,"context_line":"        # TypeError will be raised at here."},{"line_number":89,"context_line":"        pass"},{"line_number":90,"context_line":"    raise exception.InvalidName(reason\u003dregex.reason)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_69a063a0","line":88,"range":{"start_line":88,"start_character":10,"end_line":88,"end_character":19},"in_reply_to":"5aef4532_cdf8b07f","updated":"2016-03-08 01:14:15.000000000","message":"@jichenjc, you will get idea from here https://review.openstack.org/#/c/288260/2/nova/api/openstack/compute/schemas/aggregates.py","commit_id":"923cf20eca35b551ae1fb4a77835f8104ea6cbed"}],"nova/tests/unit/test_api_validation.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"046ed15b36a898571c0fd4d785f98debfd39fb72","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"        detail \u003d (\"Invalid input for field/attribute foo. Value: localhost.\""},{"line_number":1299,"context_line":"                  \" \u0027localhost\u0027 is not a \u0027ipv6\u0027\")"},{"line_number":1300,"context_line":"        self.check_validation_error(self.post, body\u003d{\u0027foo\u0027: \u0027localhost\u0027},"},{"line_number":1301,"context_line":"                                        expected_detail\u003ddetail)"},{"line_number":1302,"context_line":""},{"line_number":1303,"context_line":"        detail \u003d (\"Invalid input for field/attribute foo.\""},{"line_number":1304,"context_line":"                  \" Value: 192.168.0.100. \u0027192.168.0.100\u0027 is not a \u0027ipv6\u0027\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5aef4532_334d929a","line":1301,"updated":"2016-03-10 11:22:22.000000000","message":"Nit: should drop this change.","commit_id":"923cf20eca35b551ae1fb4a77835f8104ea6cbed"}]}